From nobody Thu Nov 13 16:35:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582206141; cv=none; d=zohomail.com; s=zohoarc; b=INdkka2fiNDdKtwe3mfpFzHZkJz8dU7MjHxWsCjZU/oWLRS8Xq7N5TihaHDZYUimMArEUUcy8lCostkvs7XyfIvDSejQimU1erhDoXAg2Uy61verv6AM0E8PxXfbPDEViu3i2HBpztpBBiPbRFB3OSwFFxieArGH3QN0DgGqE5Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582206141; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=R/jYQKF+YyM/kE5WKZctViRycmJgb6xbZJ/vWym63e4=; b=ecgJvV0QuK9tCDgpBQ7Jv8uzQvR0s/kNg9SUyYYSN6FvdYnLsBuoT5UQklHPfhno1dsAMNZzmksnQjwCbfoSfCc+WBkRFpgoJA0wWA6VpbrTlQVtdKZ8Ge36a4HL1KPlJat1gX+9jCM0wSvXp45YC4TAnPeUbNxPn9AKestr10E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582206140987311.25916940499303; Thu, 20 Feb 2020 05:42:20 -0800 (PST) Received: from localhost ([::1]:42408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4m5r-0007z9-DZ for importer@patchew.org; Thu, 20 Feb 2020 08:42:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34300) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4m50-0007Qk-30 for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:41:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4m4y-00080n-Sz for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:41:25 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3239 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4m4y-0007pi-He; Thu, 20 Feb 2020 08:41:24 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CABEFBD4CB1A8257D996; Thu, 20 Feb 2020 21:41:14 +0800 (CST) Received: from HGHY4C002233111.china.huawei.com (10.133.205.93) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Thu, 20 Feb 2020 21:41:07 +0800 From: To: Subject: [PATCH v2] test-vmstate: Fix memleaks in test_load_qlist Date: Thu, 20 Feb 2020 21:41:03 +0800 Message-ID: <20200220134103.26224-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, zhang.zhanghailiang@huawei.com, quintela@redhat.com, qemu-trivial@nongnu.org, dgilbert@redhat.com, Chen Qun , ehabkost@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun There is memleak in test_load_qlist().It's not a big deal, but test-vmstate will fail if sanitizers is enabled. In addition, "ret" is written twice with the same value in test_gtree_load_iommu(). Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Juan Quintela Reviewed-by: Laurent Vivier --- tests/test-vmstate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index cea363dd69..f7b3868881 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1241,7 +1241,6 @@ static void test_gtree_load_iommu(void) TestGTreeIOMMU *orig_iommu =3D create_iommu(); QEMUFile *fsave, *fload; char eof; - int ret; =20 fsave =3D open_test_file(true); qemu_put_buffer(fsave, iommu_dump, sizeof(iommu_dump)); @@ -1250,10 +1249,8 @@ static void test_gtree_load_iommu(void) =20 fload =3D open_test_file(false); vmstate_load_state(fload, &vmstate_iommu, dest_iommu, 1); - ret =3D qemu_file_get_error(fload); eof =3D qemu_get_byte(fload); - ret =3D qemu_file_get_error(fload); - g_assert(!ret); + g_assert(!qemu_file_get_error(fload)); g_assert_cmpint(orig_iommu->id, =3D=3D, dest_iommu->id); g_assert_cmpint(eof, =3D=3D, QEMU_VM_EOF); =20 @@ -1395,6 +1392,7 @@ static void test_load_qlist(void) compare_containers(orig_container, dest_container); free_container(orig_container); free_container(dest_container); + qemu_fclose(fload); } =20 typedef struct TmpTestStruct { --=20 2.23.0