From nobody Sun Feb 8 22:57:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582129262; cv=none; d=zohomail.com; s=zohoarc; b=EQ7eW1lwY0YlD85al+y6RUnueY0WFbHAadPEdiw/ErMHxPt3muWcPvO5FkQsD0kH1/Yhwjt9w5kvbrbhAKfVDHjVtFuWCn0tpylaQMnsx/J5KX5wHnG+eS1D8Dk1ulGsngpj+iQzMJmsMQhbhNAssL9//Wq1exwuaG0KYi38spE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582129262; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jvuF79cMIGsQ8QGVX6BBYuntFAsFgSJ2Z2doNxKKuaw=; b=iwAdIPM74po+aV9Kkz1So8H0IlMlxvWpTR9xQhyPmKWI1Qi04+LSbFfkyDWfniwMoMN62lfIMU4FH/1Cw5zKaOSDlKqsbR5bRejI3IzFsbSraM2CgRlZaxp+7/NXD5DwE+6Ch0TQkgXofGnIiJiIz3L7Rd79vWwOjF3FCIpU+WM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582129262498426.0332044492451; Wed, 19 Feb 2020 08:21:02 -0800 (PST) Received: from localhost ([::1]:55622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4S5t-0005E7-CV for importer@patchew.org; Wed, 19 Feb 2020 11:21:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37254) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Rvi-0002sZ-US for qemu-devel@nongnu.org; Wed, 19 Feb 2020 11:10:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4Rvh-0000hK-Fr for qemu-devel@nongnu.org; Wed, 19 Feb 2020 11:10:30 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:40493 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4Rvh-0000gv-AH for qemu-devel@nongnu.org; Wed, 19 Feb 2020 11:10:29 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-MhX1A1vvO_W_nZI3WJvs_Q-1; Wed, 19 Feb 2020 11:10:27 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECD7E477; Wed, 19 Feb 2020 16:10:25 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20DA88ECF3; Wed, 19 Feb 2020 16:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582128628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jvuF79cMIGsQ8QGVX6BBYuntFAsFgSJ2Z2doNxKKuaw=; b=KTbl9yjnN3S+1TMeCgaisKOscWji7jX+DQHTFBuIog/fsWvwePq6YOu3tug7LSsubyxxlP BkDjXDMfuR26zhzXZuZ7CbJO4PDPhikGsAanLNcXWxuqxdHG0NcFumdql2uCOPbjBH1R70 dXaSpRPk+GXPU/s3dvK3pEOeMKu7XZk= From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH v6 25/79] arm/nseries: use memdev for RAM Date: Wed, 19 Feb 2020 11:08:59 -0500 Message-Id: <20200219160953.13771-26-imammedo@redhat.com> In-Reply-To: <20200219160953.13771-1-imammedo@redhat.com> References: <20200219160953.13771-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: MhX1A1vvO_W_nZI3WJvs_Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing MachineClass::default_ram_id and using MachineState::ram instead of manually initializing RAM memory region. PS: while at it add check for user supplied RAM size and error out if it mismatches board expected value. Signed-off-by: Igor Mammedov Reviewed-by: Andrew Jones Reviewed-by: Richard Henderson --- v2: * fix format string causing build failure on 32-bit host (Philippe Mathieu-Daud=C3=A9 ) CC: balrogg@gmail.com --- hw/arm/nseries.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 3fd196fb30..eae800b5c1 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -47,7 +47,6 @@ =20 /* Nokia N8x0 support */ struct n800_s { - MemoryRegion sdram; struct omap_mpu_state_s *mpu; =20 struct rfbi_chip_s blizzard; @@ -1311,13 +1310,19 @@ static void n8x0_init(MachineState *machine, struct arm_boot_info *binfo, int model) { struct n800_s *s =3D (struct n800_s *) g_malloc0(sizeof(*s)); - uint64_t sdram_size =3D binfo->ram_size; + MachineClass *mc =3D MACHINE_GET_CLASS(machine); =20 - memory_region_allocate_system_memory(&s->sdram, NULL, "omap2.dram", - sdram_size); - memory_region_add_subregion(get_system_memory(), OMAP2_Q2_BASE, &s->sd= ram); + if (machine->ram_size !=3D mc->default_ram_size) { + char *sz =3D size_to_str(mc->default_ram_size); + error_report("Invalid RAM size, should be %s", sz); + g_free(sz); + exit(EXIT_FAILURE); + } + + memory_region_add_subregion(get_system_memory(), OMAP2_Q2_BASE, + machine->ram); =20 - s->mpu =3D omap2420_mpu_init(&s->sdram, machine->cpu_type); + s->mpu =3D omap2420_mpu_init(machine->ram, machine->cpu_type); =20 /* Setup peripherals * @@ -1383,9 +1388,8 @@ static void n8x0_init(MachineState *machine, * * The code above is for loading the `zImage' file from Nokia * images. */ - load_image_targphys(option_rom[0].name, - OMAP2_Q2_BASE + 0x400000, - sdram_size - 0x400000); + load_image_targphys(option_rom[0].name, OMAP2_Q2_BASE + 0x400000, + machine->ram_size - 0x400000); =20 n800_setup_nolo_tags(nolo_tags); cpu_physical_memory_write(OMAP2_SRAM_BASE, nolo_tags, 0x10000); @@ -1395,16 +1399,12 @@ static void n8x0_init(MachineState *machine, =20 static struct arm_boot_info n800_binfo =3D { .loader_start =3D OMAP2_Q2_BASE, - /* Actually two chips of 0x4000000 bytes each */ - .ram_size =3D 0x08000000, .board_id =3D 0x4f7, .atag_board =3D n800_atag_setup, }; =20 static struct arm_boot_info n810_binfo =3D { .loader_start =3D OMAP2_Q2_BASE, - /* Actually two chips of 0x4000000 bytes each */ - .ram_size =3D 0x08000000, /* 0x60c and 0x6bf (WiMAX Edition) have been assigned but are not * used by some older versions of the bootloader and 5555 is used * instead (including versions that shipped with many devices). */ @@ -1431,6 +1431,9 @@ static void n800_class_init(ObjectClass *oc, void *da= ta) mc->default_boot_order =3D ""; mc->ignore_memory_transaction_failures =3D true; mc->default_cpu_type =3D ARM_CPU_TYPE_NAME("arm1136-r2"); + /* Actually two chips of 0x4000000 bytes each */ + mc->default_ram_size =3D 0x08000000; + mc->default_ram_id =3D "omap2.dram"; } =20 static const TypeInfo n800_type =3D { @@ -1448,6 +1451,9 @@ static void n810_class_init(ObjectClass *oc, void *da= ta) mc->default_boot_order =3D ""; mc->ignore_memory_transaction_failures =3D true; mc->default_cpu_type =3D ARM_CPU_TYPE_NAME("arm1136-r2"); + /* Actually two chips of 0x4000000 bytes each */ + mc->default_ram_size =3D 0x08000000; + mc->default_ram_id =3D "omap2.dram"; } =20 static const TypeInfo n810_type =3D { --=20 2.18.1