From nobody Sat May 4 02:50:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582123319; cv=none; d=zohomail.com; s=zohoarc; b=OvAg/4fN/eihk/6kQPbwOmYg65y4NMfveK8vqj2BG4Q8DX0qegGp8zGAvl9v/+Ds9oGejs8cUcMK3JCNZ4oznwg1z7r3/2fxqmhwkqbP2NbB2RyqbrZrf+pghiKufZcjI/Yc8mk7UesrnF93u5qHGgfXKnXbnrjK3uXHkAkYE0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582123319; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TNZGMq3v5Sfpze0h3lmh7dsr8i5R1MRQMTFOSQ6ZVi0=; b=Mmd+Qzxl5uXAQkqOzm27zu2ctZZPxdjT14fkmu8YUX4WZEySw/uyeGCPAmgvyVYhY0dQXKAwHC6dtfPBot3EjLIThUmnpa2bA5vqSP9MJiKsPYqHlFCFvEDCkJesfWuoNwIhkZfRj0OQWvM3lR2U1CwiP5du3CArasWFGQ/xAkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582123319199777.7571611232453; Wed, 19 Feb 2020 06:41:59 -0800 (PST) Received: from localhost ([::1]:53680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4QY1-0004T9-P6 for importer@patchew.org; Wed, 19 Feb 2020 09:41:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51500) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4QXK-0003qr-5d for qemu-devel@nongnu.org; Wed, 19 Feb 2020 09:41:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4QXJ-0004sC-5h for qemu-devel@nongnu.org; Wed, 19 Feb 2020 09:41:14 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:23575 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4QXJ-0004oG-1s for qemu-devel@nongnu.org; Wed, 19 Feb 2020 09:41:13 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-maQGhvMLPd-xKWrrTBRPbQ-1; Wed, 19 Feb 2020 09:41:07 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C046C1088386; Wed, 19 Feb 2020 14:41:05 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-180.phx2.redhat.com [10.3.116.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27FDF60C84; Wed, 19 Feb 2020 14:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582123271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TNZGMq3v5Sfpze0h3lmh7dsr8i5R1MRQMTFOSQ6ZVi0=; b=freBB3zGPvrWjJ+PBEjBIk5KnVrVeCJAWVznxqtZCQ8CGMIKwZG68dvyVuMFkCKXurRE8L bflnXA5S1O0WhuNk6lDdi+reKLsj+X9uwSdmMqFgOPCOAsm+UwGyG0UB3uhH0tB69PD67Z VDMeSmw9TBWYP1uQudfnO+ZIgJ1IPRc= From: Eric Blake To: qemu-devel@nongnu.org Subject: [PATCH] iotests: Fix nonportable use of od --endian Date: Wed, 19 Feb 2020 08:41:03 -0600 Message-Id: <20200219144103.2919292-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: maQGhvMLPd-xKWrrTBRPbQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, andrey.shinkevich@virtuozzo.com, Kevin Wolf , qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Tests 261 and 272 fail on RHEL 7 with coreutils 8.22, since od --endian was not added until coreutils 8.23. Fix this by manually constructing the final value one byte at a time. Fixes: fc8ba423 Reported-by: Andrey Shinkevich Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- tests/qemu-iotests/common.rc | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 8a6366c09daf..b77ef3d22cd1 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -56,6 +56,12 @@ poke_file() # peek_file_le 'test.img' 512 2 =3D> 65534 peek_file_le() { - # Wrap in echo $() to strip spaces - echo $(od -j"$2" -N"$3" --endian=3Dlittle -An -vtu"$3" "$1") + local val=3D0 shift=3D0 i + + # coreutils' od --endian is not portable, so manually assemble bytes. + for i in $(od -j"$2" -N"$3" -An -v -tu1 "$1"); do + val=3D$(( val | (i << shift) )) + shift=3D$((shift + 8)) + done + echo $val } # peek_file_be 'test.img' 512 2 =3D> 65279 peek_file_be() { - # Wrap in echo $() to strip spaces - echo $(od -j"$2" -N"$3" --endian=3Dbig -An -vtu"$3" "$1") + local val=3D0 i + + # coreutils' od --endian is not portable, so manually assemble bytes. + for i in $(od -j"$2" -N"$3" -An -v -tu1 "$1"); do + val=3D$(( (val << 8) | i )) + done + echo $val } -# peek_file_raw 'test.img' 512 2 =3D> '\xff\xfe' +# peek_file_raw 'test.img' 512 2 =3D> '\xff\xfe'. Do not use if the raw da= ta +# is likely to contain \0 or trailing \n. peek_file_raw() { dd if=3D"$1" bs=3D1 skip=3D"$2" count=3D"$3" status=3Dnone --=20 2.24.1