From nobody Thu Nov 13 19:25:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582078589192110.3804903077696; Tue, 18 Feb 2020 18:16:29 -0800 (PST) Received: from localhost ([::1]:44434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Eua-0006ju-0v for importer@patchew.org; Tue, 18 Feb 2020 21:16:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43088) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Esc-0004A7-M8 for qemu-devel@nongnu.org; Tue, 18 Feb 2020 21:14:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4Esa-00018J-SN for qemu-devel@nongnu.org; Tue, 18 Feb 2020 21:14:26 -0500 Received: from ozlabs.org ([203.11.71.1]:38955) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4EsZ-00014k-1a; Tue, 18 Feb 2020 21:14:24 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 48Mh9g3c45z9sSd; Wed, 19 Feb 2020 13:14:15 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1582078455; bh=5V3Fkwnhhaf99LksVVnXh9d+PmvLqtote/We8hZMvyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NojVsu74goq/oAL2ZdroTeU0xRO0aOxb8zXISmBzCETC29l/uW1M4E/5YXelvK+K/ oFjwIwoWpSOBBISxLS4VfwjRoof9w99SxE1QmGmAapqAL44KN9hOcfqyDyEO3GuzuQ haDitRHI0pg0yqcp+W/kGnfsfe0wderxvugjx12E= From: David Gibson To: groug@kaod.org, clg@kaod.org, philmd@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 09/12] target/ppc: Correct RMLS table Date: Wed, 19 Feb 2020 13:14:06 +1100 Message-Id: <20200219021409.21332-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200219021409.21332-1-david@gibson.dropbear.id.au> References: <20200219021409.21332-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-ppc@nongnu.org, Thomas Huth , Xiao Guangrong , "Michael S. Tsirkin" , aik@ozlabs.ru, Mark Cave-Ayland , paulus@samba.org, Paolo Bonzini , Igor Mammedov , "Edgar E. Iglesias" , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The table of RMA limits based on the LPCR[RMLS] field is slightly wrong. We're missing the RMLS =3D=3D 0 =3D> 256 GiB RMA option, which is available= on POWER8, so add that. The comment that goes with the table is much more wrong. We *don't* filter invalid RMLS values when writing the LPCR, and there's not really a sensible way to do so. Furthermore, while in theory the set of RMLS values is implementation dependent, it seems in practice the same set has been available since around POWER4+ up until POWER8, the last model which supports RMLS at all. So, correct that as well. Signed-off-by: David Gibson Reviewed-by: C=C3=A9dric Le Goater --- target/ppc/mmu-hash64.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c index 4e6c1f722b..46690bc79b 100644 --- a/target/ppc/mmu-hash64.c +++ b/target/ppc/mmu-hash64.c @@ -762,12 +762,12 @@ static target_ulong rmls_limit(PowerPCCPU *cpu) { CPUPPCState *env =3D &cpu->env; /* - * This is the full 4 bits encoding of POWER8. Previous - * CPUs only support a subset of these but the filtering - * is done when writing LPCR + * In theory the meanings of RMLS values are implementation + * dependent. In practice, this seems to have been the set from + * POWER4+..POWER8, and RMLS is no longer supported in POWER9. */ const target_ulong rma_sizes[] =3D { - [0] =3D 0, + [0] =3D 256 * GiB, [1] =3D 16 * GiB, [2] =3D 1 * GiB, [3] =3D 64 * MiB, --=20 2.24.1