From nobody Mon Feb 9 07:17:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158205487542088.86917144782524; Tue, 18 Feb 2020 11:41:15 -0800 (PST) Received: from localhost ([::1]:41058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48k5-0005G4-G9 for importer@patchew.org; Tue, 18 Feb 2020 14:41:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54912) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j48iW-0003Z1-O5 for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j48iV-0004GJ-Qs for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:36 -0500 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:45753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j48iV-0004EM-KJ for qemu-devel@nongnu.org; Tue, 18 Feb 2020 14:39:35 -0500 Received: by mail-pf1-x42c.google.com with SMTP id 2so11142079pfg.12 for ; Tue, 18 Feb 2020 11:39:35 -0800 (PST) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id y15sm424395pgj.78.2020.02.18.11.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 11:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9xp9YT+6BXF/GDcu+K5TvURlBEjt56+scFGDcoCg8XI=; b=rdq+mRnlGdvIWcenw2xPzU7WNU/j2DqSZy2NjxrUkjLMMGLByuPfYOhu9vlhDipfcm KlC50yJ3NYUnW6g+6l127yLp8lnj5yxhDCRCrnc6hfi/yh52v6THJrlx90ZzthLVkHr1 KRC6c5vEKqSm2ZbqXqSVqNWHZPdC6WKJdXKwdE6lhM9jMqYjM4kNPBrJLY/xU5985nok ZQ6mhaDTGq8nbuG8AzaE1TUc0sWdBoNgyHazJrdppLwppQbmcHOa+srx1xKooESfO9vS h+3SbgWCpkpDp29UjSTPk2G6vW7J8hZpts5sJDKpzWuiDS4wWgB0yvOTvjBCyHIxAmui chjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9xp9YT+6BXF/GDcu+K5TvURlBEjt56+scFGDcoCg8XI=; b=XfkzOo/Qb7ZCgJfr5tUILzGx/SJKcpmnJck4HyHhuzDqU1/xkC4J/SJ0+VWF8WGYPW ttbl3NdIFQc+hzlQEZcWWJW0J/lD20JDQhI2E+x9DDL7TNleXbboaO1Ew35DDKF3vhfv BdWQ9k91t2jHH0Jx3Yr1mWDZJ4KoEXZW9i1xa8dlJ01D5Up+csUggBtCSqFwUs4zoGcZ tveq3rUDDyrS8z4Glux9aqcjxkMLxKJW7/HcSNROv/wEsQ2bXRkZGS+0SLCfxOSbT3qy YRFyP50YbLbI2UyuzLI+1/uAe37+A2NHk1xL6Tm3/v5rSMNemmP9vtEfMa+Kk0VwkTbm alaQ== X-Gm-Message-State: APjAAAVmW+MhWgiXyBBMBHfL2vLozBCqdK9xLnZyD/0kxorJQn4gMDmS Y+bAPk2Ia6YyeB7uZydDM6K2owVMfR4= X-Google-Smtp-Source: APXvYqzmav0L416/hgm6vkFmeVjp5sbY85GYkqbfi3wYw+wnmMhnLT/L0EpYqCzCK+djgjDNuAsTBA== X-Received: by 2002:a63:78c4:: with SMTP id t187mr21661123pgc.88.1582054774237; Tue, 18 Feb 2020 11:39:34 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 2/9] hw/display/artist: Remove pointless initialization Date: Tue, 18 Feb 2020 11:39:22 -0800 Message-Id: <20200218193929.11404-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200218193929.11404-1-richard.henderson@linaro.org> References: <20200218193929.11404-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 We are initializating incy inconditionally: if (y1 <=3D y2) { incy =3D 1; } else { incy =3D -1; } Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Sven Schnelle Message-Id: <20200214001303.12873-3-f4bug@amsat.org> Signed-off-by: Richard Henderson --- hw/display/artist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index abacb0e27d..47f0e9f0bc 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -572,7 +572,6 @@ static void draw_line(ARTISTState *s, int x1, int y1, i= nt x2, int y2, buf =3D &s->vram_buffer[ARTIST_BUFFER_AP]; =20 c1 =3D false; - incy =3D 1; =20 if (x2 > x1) { dx =3D x2 - x1; --=20 2.20.1