From nobody Mon Feb 9 04:42:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158203599008934.19568172518825; Tue, 18 Feb 2020 06:26:30 -0800 (PST) Received: from localhost ([::1]:36128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j43pV-0002hM-3F for importer@patchew.org; Tue, 18 Feb 2020 09:26:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53520) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j43YK-00007D-CF for qemu-devel@nongnu.org; Tue, 18 Feb 2020 09:08:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j43YJ-0001oN-6Z for qemu-devel@nongnu.org; Tue, 18 Feb 2020 09:08:44 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:57330 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j43YJ-0001nw-2q for qemu-devel@nongnu.org; Tue, 18 Feb 2020 09:08:43 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-jiast7bzMIy3jvuUauWMHw-1; Tue, 18 Feb 2020 09:08:35 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82B638010C7; Tue, 18 Feb 2020 14:08:34 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-181.ams2.redhat.com [10.36.117.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FA8419E9C; Tue, 18 Feb 2020 14:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582034922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65XsTSh/O+rcZpanfq6WZ+01FMlFRFOs93zVQdh40lU=; b=i26axotDrZhcYkokxiwNWjutnA6lgM5hk7sQoEAbBIxnd+PQNwJV29sU23i0qrjfQ57jFj rkOJucDawblCMFNOpfqXhq3jsz28qneVHGEi8DtoE9EtzJHO7xmaBfR1XPYMBl+jgIsoIV 1m5GbjVgjTJi85SiyDR4pEWMWgXF0rQ= From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 32/36] iotests/041: Drop superfluous shutdowns Date: Tue, 18 Feb 2020 15:07:18 +0100 Message-Id: <20200218140722.23876-33-kwolf@redhat.com> In-Reply-To: <20200218140722.23876-1-kwolf@redhat.com> References: <20200218140722.23876-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: jiast7bzMIy3jvuUauWMHw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Max Reitz All tearDowns in 041 shutdown the VM. Thus, test cases do not need to do it themselves (unless they need the VM to be down for some post-operation check). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200218103454.296704-16-mreitz@redhat.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index aa7d54d968..7b2cf5c2f8 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -80,7 +80,6 @@ class TestSingleDrive(iotests.QMPTestCase): self.cancel_and_wait(force=3DTrue) result =3D self.vm.qmp('query-block') self.assert_qmp(result, 'return[0]/inserted/file', test_img) - self.vm.shutdown() =20 def test_cancel_after_ready(self): self.assert_no_active_block_jobs() @@ -201,8 +200,6 @@ class TestSingleDrive(iotests.QMPTestCase): self.assert_qmp(result, 'return[0]/node-name', 'top') self.assert_qmp(result, 'return[0]/backing/node-name', 'base') =20 - self.vm.shutdown() - def test_medium_not_found(self): if iotests.qemu_default_machine !=3D 'pc': return @@ -455,7 +452,6 @@ new_state =3D "1" self.assert_qmp(event, 'data/id', 'drive0') =20 self.assert_no_active_block_jobs() - self.vm.shutdown() =20 def test_ignore_read(self): self.assert_no_active_block_jobs() @@ -475,7 +471,6 @@ new_state =3D "1" result =3D self.vm.qmp('query-block-jobs') self.assert_qmp(result, 'return[0]/paused', False) self.complete_and_wait() - self.vm.shutdown() =20 def test_large_cluster(self): self.assert_no_active_block_jobs() @@ -540,7 +535,6 @@ new_state =3D "1" =20 self.complete_and_wait(wait_ready=3DFalse) self.assert_no_active_block_jobs() - self.vm.shutdown() =20 class TestWriteErrors(iotests.QMPTestCase): image_len =3D 2 * 1024 * 1024 # MB @@ -614,7 +608,6 @@ new_state =3D "1" completed =3D True =20 self.assert_no_active_block_jobs() - self.vm.shutdown() =20 def test_ignore_write(self): self.assert_no_active_block_jobs() @@ -631,7 +624,6 @@ new_state =3D "1" result =3D self.vm.qmp('query-block-jobs') self.assert_qmp(result, 'return[0]/paused', False) self.complete_and_wait() - self.vm.shutdown() =20 def test_stop_write(self): self.assert_no_active_block_jobs() @@ -667,7 +659,6 @@ new_state =3D "1" =20 self.complete_and_wait(wait_ready=3DFalse) self.assert_no_active_block_jobs() - self.vm.shutdown() =20 class TestSetSpeed(iotests.QMPTestCase): image_len =3D 80 * 1024 * 1024 # MB @@ -936,7 +927,6 @@ class TestRepairQuorum(iotests.QMPTestCase): # here we check that the last registered quorum file has not been # swapped out and unref self.assert_has_block_node(None, quorum_img3) - self.vm.shutdown() =20 def test_cancel_after_ready(self): self.assert_no_active_block_jobs() @@ -1043,7 +1033,6 @@ class TestRepairQuorum(iotests.QMPTestCase): self.assert_has_block_node("repair0", quorum_repair_img) # TODO: a better test requiring some QEMU infrastructure will be a= dded # to check that this file is really driven by quorum - self.vm.shutdown() =20 # Test mirroring with a source that does not have any parents (not even a # BlockBackend) --=20 2.20.1