From nobody Tue Feb 10 12:14:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582021033883992.6262118197138; Tue, 18 Feb 2020 02:17:13 -0800 (PST) Received: from localhost ([::1]:60024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3zwG-0004gw-DS for importer@patchew.org; Tue, 18 Feb 2020 05:17:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48915) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3zvB-00035f-So for qemu-devel@nongnu.org; Tue, 18 Feb 2020 05:16:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3zv9-0007uc-8m for qemu-devel@nongnu.org; Tue, 18 Feb 2020 05:16:05 -0500 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:58770) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3zv3-0007qI-Jm; Tue, 18 Feb 2020 05:15:57 -0500 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7E91436DF; Tue, 18 Feb 2020 11:08:12 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: qemu-devel@nongnu.org Subject: [RFC qemu 6/6] mirror: move some checks to QMP Date: Tue, 18 Feb 2020 11:07:40 +0100 Message-Id: <20200218100740.2228521-7-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200218100740.2228521-1-f.gruenbichler@proxmox.com> References: <20200218100740.2228521-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, John Snow , Markus Armbruster , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" and assert the passing conditions in block/mirror.c. while incremental mode was never available for drive-mirror, it makes the interface more uniform w.r.t. backup block jobs. Signed-off-by: Fabian Gr=C3=BCnbichler --- block/mirror.c | 28 +++------------ blockdev.c | 29 +++++++++++++++ tests/qemu-iotests/284.out | 72 +++++++++++++++++++------------------- 3 files changed, 70 insertions(+), 59 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index d6aca2874e..7a3373fca7 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1562,31 +1562,13 @@ static BlockJob *mirror_start_job( Error *local_err =3D NULL; int ret; =20 - if (sync_mode =3D=3D MIRROR_SYNC_MODE_INCREMENTAL) { - error_setg(errp, "Sync mode '%s' not supported", - MirrorSyncMode_str(sync_mode)); - return NULL; - } else if (sync_mode =3D=3D MIRROR_SYNC_MODE_BITMAP) { - if (!bitmap) { - error_setg(errp, "Must provide a valid bitmap name for '%s'" - " sync mode", - MirrorSyncMode_str(sync_mode)); - return NULL; - } - } else if (bitmap) { - error_setg(errp, - "sync mode '%s' is not compatible with bitmaps", - MirrorSyncMode_str(sync_mode)); - return NULL; - } + /* QMP interface protects us from these cases */ + assert(sync_mode !=3D MIRROR_SYNC_MODE_INCREMENTAL); + assert((bitmap && sync_mode =3D=3D MIRROR_SYNC_MODE_BITMAP) || + (!bitmap && sync_mode !=3D MIRROR_SYNC_MODE_BITMAP)); + assert(!(bitmap && granularity)); =20 if (bitmap) { - if (granularity) { - error_setg(errp, "granularity (%d)" - "cannot be specified when a bitmap is provided", - granularity); - return NULL; - } granularity =3D bdrv_dirty_bitmap_granularity(bitmap); =20 if (bitmap_mode !=3D BITMAP_SYNC_MODE_NEVER) { diff --git a/blockdev.c b/blockdev.c index 23df9f76ba..87bde0a4f4 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3847,7 +3847,36 @@ static void blockdev_mirror_common(const char *job_i= d, BlockDriverState *bs, sync =3D MIRROR_SYNC_MODE_FULL; } =20 + if ((sync =3D=3D MIRROR_SYNC_MODE_BITMAP) || + (sync =3D=3D MIRROR_SYNC_MODE_INCREMENTAL)) { + /* done before desugaring 'incremental' to print the right message= */ + if (!has_bitmap) { + error_setg(errp, "Must provide a valid bitmap name for " + "'%s' sync mode", MirrorSyncMode_str(sync)); + return; + } + } + + if (sync =3D=3D MIRROR_SYNC_MODE_INCREMENTAL) { + if (has_bitmap_mode && + bitmap_mode !=3D BITMAP_SYNC_MODE_ON_SUCCESS) { + error_setg(errp, "Bitmap sync mode must be '%s' " + "when using sync mode '%s'", + BitmapSyncMode_str(BITMAP_SYNC_MODE_ON_SUCCESS), + MirrorSyncMode_str(sync)); + return; + } + has_bitmap_mode =3D true; + sync =3D MIRROR_SYNC_MODE_BITMAP; + bitmap_mode =3D BITMAP_SYNC_MODE_ON_SUCCESS; + } + if (has_bitmap) { + if (sync !=3D MIRROR_SYNC_MODE_BITMAP) { + error_setg(errp, "Sync mode '%s' not supported with bitmap.", + MirrorSyncMode_str(sync)); + return; + } if (granularity) { error_setg(errp, "Granularity and bitmap cannot both be set"); return; diff --git a/tests/qemu-iotests/284.out b/tests/qemu-iotests/284.out index 9b7408b6d6..06a2e29058 100644 --- a/tests/qemu-iotests/284.out +++ b/tests/qemu-iotests/284.out @@ -2681,45 +2681,45 @@ qemu_img compare "TEST_DIR/PID-img" "TEST_DIR/PID-f= mirror3" =3D=3D> Identical, OK! -- Sync mode incremental tests -- =20 {"execute": "blockdev-mirror", "arguments": {"bitmap-mode": "on-success", = "device": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", = "sync": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'incremental' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap-mode": "always", "dev= ice": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "syn= c": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'incremental' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap-mode": "never", "devi= ce": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync= ": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'incremental' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"device": "drive0", "filter-n= ode-name": "mirror-top", "job-id": "api_job", "sync": "incremental", "targe= t": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Sync mode 'incremental' not s= upported"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'incremental' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top"= , "job-id": "api_job", "sync": "incremental", "target": "mirror_target"}} {"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "j= ob-id": "api_job", "sync": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Bitmap sync mode must be 'on-= success' when using sync mode 'incremental'"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "jo= b-id": "api_job", "sync": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Bitmap sync mode must be 'on-= success' when using sync mode 'incremental'"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "devic= e": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync"= : "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "job= -id": "api_job", "sync": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Sync mode 'incremental' not s= upported"}} +{"error": {"class": "GenericError", "desc": "Bitmap sync mode must be 'on-= success' when using sync mode 'incremental'"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "job-= id": "api_job", "sync": "incremental", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Sync mode 'incremental' not s= upported"}} +{"error": {"class": "GenericError", "desc": "Bitmap sync mode must be 'on-= success' when using sync mode 'incremental'"}} =20 -- Sync mode bitmap tests -- =20 {"execute": "blockdev-mirror", "arguments": {"bitmap-mode": "on-success", = "device": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", = "sync": "bitmap", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'bitmap' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap-mode": "always", "dev= ice": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "syn= c": "bitmap", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'bitmap' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap-mode": "never", "devi= ce": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync= ": "bitmap", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} +{"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'bitmap' sync mode"}} =20 {"execute": "blockdev-mirror", "arguments": {"device": "drive0", "filter-n= ode-name": "mirror-top", "job-id": "api_job", "sync": "bitmap", "target": "= mirror_target"}} {"error": {"class": "GenericError", "desc": "Must provide a valid bitmap n= ame for 'bitmap' sync mode"}} @@ -2751,28 +2751,28 @@ qemu_img compare "TEST_DIR/PID-img" "TEST_DIR/PID-f= mirror3" =3D=3D> Identical, OK! {"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top"= , "job-id": "api_job", "sync": "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "j= ob-id": "api_job", "sync": "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "jo= b-id": "api_job", "sync": "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "devic= e": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync"= : "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top", = "job-id": "api_job", "sync": "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'full' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "job= -id": "api_job", "sync": "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'full' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "job-= id": "api_job", "sync": "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'full' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "device"= : "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync": = "full", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 -- Sync mode top tests -- =20 @@ -2786,28 +2786,28 @@ qemu_img compare "TEST_DIR/PID-img" "TEST_DIR/PID-f= mirror3" =3D=3D> Identical, OK! {"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top"= , "job-id": "api_job", "sync": "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "j= ob-id": "api_job", "sync": "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "jo= b-id": "api_job", "sync": "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "devic= e": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync"= : "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top", = "job-id": "api_job", "sync": "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'full' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "job= -id": "api_job", "sync": "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'full' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "job-= id": "api_job", "sync": "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'full' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "device"= : "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync": = "top", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'full' not supporte= d with bitmap."}} =20 -- Sync mode none tests -- =20 @@ -2821,26 +2821,26 @@ qemu_img compare "TEST_DIR/PID-img" "TEST_DIR/PID-f= mirror3" =3D=3D> Identical, OK! {"error": {"class": "GenericError", "desc": "Cannot specify bitmap sync mo= de without a bitmap"}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top"= , "job-id": "api_job", "sync": "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "j= ob-id": "api_job", "sync": "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "bitma= p-mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "jo= b-id": "api_job", "sync": "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "Dirty bitmap 'bitmap404' not = found"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap404", "devic= e": "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync"= : "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "on-success", "device": "drive0", "filter-node-name": "mirror-top", = "job-id": "api_job", "sync": "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'none' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "always", "device": "drive0", "filter-node-name": "mirror-top", "job= -id": "api_job", "sync": "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'none' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "bitmap-= mode": "never", "device": "drive0", "filter-node-name": "mirror-top", "job-= id": "api_job", "sync": "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "sync mode 'none' is not compa= tible with bitmaps"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 {"execute": "blockdev-mirror", "arguments": {"bitmap": "bitmap0", "device"= : "drive0", "filter-node-name": "mirror-top", "job-id": "api_job", "sync": = "none", "target": "mirror_target"}} -{"error": {"class": "GenericError", "desc": "bitmap-mode must be specified= if a bitmap is provided"}} +{"error": {"class": "GenericError", "desc": "Sync mode 'none' not supporte= d with bitmap."}} =20 --=20 2.20.1