From nobody Thu Nov 13 16:34:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581946305299821.9324716169241; Mon, 17 Feb 2020 05:31:45 -0800 (PST) Received: from localhost ([::1]:45576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3gUx-0000ND-Jb for importer@patchew.org; Mon, 17 Feb 2020 08:31:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54668) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3gSl-00069H-3a for qemu-devel@nongnu.org; Mon, 17 Feb 2020 08:29:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3gSk-0001jL-6V for qemu-devel@nongnu.org; Mon, 17 Feb 2020 08:29:27 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:37031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3gSk-0001it-16; Mon, 17 Feb 2020 08:29:26 -0500 Received: by mail-wm1-x341.google.com with SMTP id a6so18488697wme.2; Mon, 17 Feb 2020 05:29:25 -0800 (PST) Received: from x1w.redhat.com (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id z10sm578945wmk.31.2020.02.17.05.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 05:29:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X+VUpOyrP1K99lWKDQzsDNVHm6OjkjeFpNl83oieryk=; b=MbrhbUoMSP03+fIiB0nFu8tl2W9xI4yB/SEQx4Gxnwi+gMjztbgMU6pAwhZPh3MKCS izaUyZrLKa2FOXxtp7e/6ixZArXZ52GQGoGSFIYhEVJwCvKS2ZkYK75BXp+GyH34Qcbj o75bbb4sVfSP2j0on/waKXKumt10pLzVSrZx5WiU1pJRlE0y7pUHPmQFi1xoRdwNxdjW PFD2Qq01vUtFxTpuPgKprQH463uhPAbF08n8ULOCKEMRdbUn+FoXPX7zaV9Au+eS70ZC u+gelUStzBdJ3tLO+LAmoJLFB0IVus3FVwJqsWvyTP+oF+/y179u2ouvdYDw1YBUz1Ta jBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=X+VUpOyrP1K99lWKDQzsDNVHm6OjkjeFpNl83oieryk=; b=XiHYzztid578VG95Pwyl6/f2+f/rQma3DqC2XyoTEu8PURWt/QG6yR7eOtfVYTdhBG PBouNrJEqNmMQ6KyKVPRlGQqHLoaGQNLM/Lp1oejCV6air67QdQsTYXBr1wvIK3farYU Ouv6Y6vdXpNDih0OKYCzrcWd4KinwMAi1X+0BXCoDfexYHYN/7drp3G0NB/yGy31EEau t0kFEA+FRxJqvpvzSIxxUjDKkTXCnmZhEjmAspA3oAcbWCa6RbAkrixWAHAmMrA5lzvC He6gsYu04Fwl3SS3fY2fZHpmGRm4kaKdQxNEZRbIsPIOTw/rrMpyF/yg6DJ0UxTg/86v dygg== X-Gm-Message-State: APjAAAW2CQQsmvjLdYzbpyVml+s7PwQ/a/zDOkuaMBLegyns1GlOD+St P69IuWEW+z0d7WvBB7chDv5PS8IsDGc= X-Google-Smtp-Source: APXvYqy8By6qk+qJlzlxKdqLjG4m1+JliPYwYaVTIINQa2rN5HTBpjNqzXbO4XQgXVTs2dpyeAklDQ== X-Received: by 2002:a1c:a4c3:: with SMTP id n186mr22367859wme.25.1581946164404; Mon, 17 Feb 2020 05:29:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register Date: Mon, 17 Feb 2020 14:29:22 +0100 Message-Id: <20200217132922.24607-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Fix warning reported by Clang static code analyzer: CC hw/misc/iotkit-secctl.o hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never = read value &=3D 0x00f000f3; ^ ~~~~~~~~~~ Fixes: b3717c23e1c Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v3: AND the register... (pm215) v2: Corrected bitwise-not precedence (pm215) --- hw/misc/iotkit-secctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/iotkit-secctl.c b/hw/misc/iotkit-secctl.c index 609869821a..9fdb82056a 100644 --- a/hw/misc/iotkit-secctl.c +++ b/hw/misc/iotkit-secctl.c @@ -340,7 +340,7 @@ static MemTxResult iotkit_secctl_s_write(void *opaque, = hwaddr addr, qemu_set_irq(s->sec_resp_cfg, s->secrespcfg); break; case A_SECPPCINTCLR: - value &=3D 0x00f000f3; + s->secppcintstat &=3D ~(value & 0x00f000f3); foreach_ppc(s, iotkit_secctl_ppc_update_irq_clear); break; case A_SECPPCINTEN: --=20 2.21.1