From nobody Thu Nov 13 16:34:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15819370856321001.3426559526908; Mon, 17 Feb 2020 02:58:05 -0800 (PST) Received: from localhost ([::1]:43492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3e6E-0005mt-1c for importer@patchew.org; Mon, 17 Feb 2020 05:58:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34709) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3e5G-0004to-LW for qemu-devel@nongnu.org; Mon, 17 Feb 2020 05:57:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3e5F-0005l8-J1 for qemu-devel@nongnu.org; Mon, 17 Feb 2020 05:57:02 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:35495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3e5F-0005kR-BW; Mon, 17 Feb 2020 05:57:01 -0500 Received: by mail-wr1-x441.google.com with SMTP id w12so19135401wrt.2; Mon, 17 Feb 2020 02:57:01 -0800 (PST) Received: from x1w.redhat.com (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id a9sm135149wmm.15.2020.02.17.02.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 02:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QefSIhzsJ5EzH0dIBGDnIAWhsi6Ouz7g5ZmP1cUfx+k=; b=qYCGkTjXajFbzKAvzqglT1rLluAgxi+fFNBav4fwQufVtBhNR1sPNNoqW+6q9RYLBV IIMdfwT8pQWCfGaOZYSJ2vp24lRg8dW6IhsqG95H3yIyj5vCUcIP/I+5uc45GPtOgeZ2 /AZbwAq8ZBskxJ0JsofCa8kM6ax5MPT6q7MBzoGXvZSoXznjGYfmI7r29fBnhxb2Anjx KRzsNsiPP0dwAsToccwEnmg9qi+EPQa8X0VuG7ff53fB4vymzB9SXLOOnp3/puW696Tm BQyZhA9NNx/c2EaOGwtiaLAbc/sQZTDJWJ9x+t9l3Iv6BdCAaCplNkoo46hLR1F7ghnU +fOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=QefSIhzsJ5EzH0dIBGDnIAWhsi6Ouz7g5ZmP1cUfx+k=; b=kNEWfELjtB7G6b0Lo89NqHe6mEzyRRw/FbSOqqsKksCeNnLl4bexAaQpu7VBWaOfd/ BeYNTrQsYVdBS3/AX+orJOeZjz9mZqOqExy3T+lpkc/8nsiSItXRulZtSgRKRkHWAmj2 MenRjcSfr1+HmOGlACKfw2LHzDD8iV0mr9PC+UNOggOqfaTDLxywn8CgvjqU1Vfb4/hE ZGnqVkb9LCgzAoQPPJFAlmW1qBdYS/blKwgL3Nsnwefp8B9v7SYWS6iSZygOFpd3YDSN ZhGa5y/Vj2y9f136PMvRWVy6BV3omBoYh0lujM8qFk6IyziLmuwu6+WfS9uHLzNXPRut e3kg== X-Gm-Message-State: APjAAAVR0h6xVy3njAPGgRv9CXF4JWSDWPeMwDMjUegnvzmepkkfgNLo sezmkdXsA2nAxeC8SQE7CMMjBwGMg3M= X-Google-Smtp-Source: APXvYqzNJhOoVK078PqjEChm7aUSDm0o+pkWvQV8Kaa5UZvzHgR2DDA8FoEuhwGNmhbDES0U1gXHvQ== X-Received: by 2002:a5d:4750:: with SMTP id o16mr21335146wrs.91.1581937019783; Mon, 17 Feb 2020 02:56:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register Date: Mon, 17 Feb 2020 11:56:57 +0100 Message-Id: <20200217105657.31506-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Fix warning reported by Clang static code analyzer: CC hw/misc/iotkit-secctl.o hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never = read value &=3D 0x00f000f3; ^ ~~~~~~~~~~ Fixes: b3717c23e1c Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Corrected bitwise-not precedence (pm215) --- hw/misc/iotkit-secctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/iotkit-secctl.c b/hw/misc/iotkit-secctl.c index 609869821a..43cf0f9970 100644 --- a/hw/misc/iotkit-secctl.c +++ b/hw/misc/iotkit-secctl.c @@ -340,7 +340,7 @@ static MemTxResult iotkit_secctl_s_write(void *opaque, = hwaddr addr, qemu_set_irq(s->sec_resp_cfg, s->secrespcfg); break; case A_SECPPCINTCLR: - value &=3D 0x00f000f3; + s->secppcintstat =3D ~(value & 0x00f000f3); foreach_ppc(s, iotkit_secctl_ppc_update_irq_clear); break; case A_SECPPCINTEN: --=20 2.21.1