From nobody Thu Nov 13 16:35:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581783623076269.20408392251363; Sat, 15 Feb 2020 08:20:23 -0800 (PST) Received: from localhost ([::1]:52452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j30B3-0007fF-Sw for importer@patchew.org; Sat, 15 Feb 2020 11:20:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48145) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j30AE-0006ns-2f for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:19:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j30AC-0000C6-1d for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:19:29 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:51435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j30AB-0000B3-SF; Sat, 15 Feb 2020 11:19:28 -0500 Received: by mail-wm1-x342.google.com with SMTP id t23so13098689wmi.1; Sat, 15 Feb 2020 08:19:27 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id c13sm11899255wrn.46.2020.02.15.08.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2020 08:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eTn2oK2dQxQzFgBTTAIiys0g5gffJIiQC/GfhEVlsF4=; b=H9HuCdzNLNf5wF5E9yZCwWovzZFqAKQ08jQSCepYUtrA+g5tne/7ID+2V6XXf3oDpI DtjRFNn3c+BLKf/ssniyT13Z8WBTrv5ze6E1AkSzHD3MIVqu9tvgkUC7DUaG5y4oC0EG GjBnjd+/QtzwEvJpBRX1qOSv/P3W1HMGfMDF+4SrTWR07vO1RQbHXl1ufUNpMQ3+6QxV 9i1+5QAvmsVsMaduNB8HMwuoj2ddXPA2UeZ0jjIxkJdlqRpJDZMN1SYPDmN2xL9g+9h+ LBNyrJaPZy4zjB1ko8GAnpkfsYkNzOgys/d9FE8zGOaY9gmTUGxzLMQy4M0JEA+Uq2QQ HW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=eTn2oK2dQxQzFgBTTAIiys0g5gffJIiQC/GfhEVlsF4=; b=VznbnAy+ysgifIkEdkh6oRNzu6+Ezp2jKDvESuUFKsm/cIeJf1VR7JKfu8dNzFK/I7 Q8lZKrkA2ndSxAz/PpmrUlh4PxEqBYVrL2JPHlQk+rZAYYx20rwlev09ekdNNjX3xTo+ KQ7mz+C/NIcePRcj4sROdLUcv1p+7genVwwTw3RWyT2obprpJItDPt5l1DqfXyDASTuG 0YdFwzQ2ccGDun6EgW22W5BfL9nEKoYQWdDKLh+BW7A7XRvWpOl+/p6B0EmnZNOUyDRC 09o9lCV8gHj8+f2Mn8jS3sgrmAEJfb9GK/+cjZqsDE2oqHE6XCHCxV5tu1G2E7prpJ5t GKhA== X-Gm-Message-State: APjAAAXoUumVMD7IlXEgZH2zEBaRt9sXn7fTHrGwfALGThuj7jYXnVLS mgAotUUKBoeoIfuM7BztSrwUsP4/O1M= X-Google-Smtp-Source: APXvYqwDeqCcaHBmMOZ7xTwSxEXmBVriU1c/6subQ0Wwg+sgp86ZRj9hZTq7zZa+rIaRuzWBCYFfZQ== X-Received: by 2002:a1c:65d6:: with SMTP id z205mr11205173wmb.38.1581783565941; Sat, 15 Feb 2020 08:19:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] hw/misc/iotkit-secctl: Fix writing to 'PPC Interrupt Clear' register Date: Sat, 15 Feb 2020 17:19:23 +0100 Message-Id: <20200215161923.4741-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Fix warning reported by Clang static code analyzer: CC hw/misc/iotkit-secctl.o hw/misc/iotkit-secctl.c:343:9: warning: Value stored to 'value' is never = read value &=3D 0x00f000f3; ^ ~~~~~~~~~~ Fixes: b3717c23e1c Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/iotkit-secctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/iotkit-secctl.c b/hw/misc/iotkit-secctl.c index 609869821a..0d5556dd17 100644 --- a/hw/misc/iotkit-secctl.c +++ b/hw/misc/iotkit-secctl.c @@ -340,7 +340,7 @@ static MemTxResult iotkit_secctl_s_write(void *opaque, = hwaddr addr, qemu_set_irq(s->sec_resp_cfg, s->secrespcfg); break; case A_SECPPCINTCLR: - value &=3D 0x00f000f3; + s->secppcintstat =3D ~value & 0x00f000f3; foreach_ppc(s, iotkit_secctl_ppc_update_irq_clear); break; case A_SECPPCINTEN: --=20 2.21.1