From nobody Thu Nov 13 18:06:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581783445556965.0433739680939; Sat, 15 Feb 2020 08:17:25 -0800 (PST) Received: from localhost ([::1]:52404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j308B-0003Hs-4R for importer@patchew.org; Sat, 15 Feb 2020 11:17:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47657) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j306w-00029q-Rf for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:16:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j306v-0005bA-NS for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:16:06 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:43295 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j306v-0005Zj-Jv for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:16:05 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-Uyx69B92Pc2ZYxHDdjVEDA-1; Sat, 15 Feb 2020 11:16:03 -0500 Received: by mail-wm1-f72.google.com with SMTP id w12so4854684wmc.3 for ; Sat, 15 Feb 2020 08:16:03 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id w26sm11855872wmi.8.2020.02.15.08.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2020 08:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581783365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z2UBuAZivxQ/t2LSYWdCfVvdvGAny5juqMvDOKi7+08=; b=YNlpnn41v51SHNGdA2nFXgR0x/oRIOxmxj7rGAMgTtP9VeI968fh54qsa4lQXIwngQTUT6 NGRG4Cl4ngtrWkbrTzDGDbhZM7/wqJRfMpjR8TGsDyoOpy9TjMfqxnSPMTSvlOlMZ2L1JG MA/azoHWF0gITp7hcCd7s+A90gq99sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1vNqWmtTfqRpFkSvpFeliBtBQdDhN9OVYIDlRsAhO9E=; b=jl+gSiCsHl3JYt5momQsQXVCNwHlEzWqOwEH7uT3wVvt0llmKoKX1gO7Rxst7c1VJQ 8qNlm06ODJuB2Km/NFQo9oKZ6sGQCLSw7NH40GtqM/Q5Pk6EMbcm/CA35UbP3Sx0LHb2 7JOVu3FliazEbouNu0qlBAmXALQgQVp0D/FBYboPQuO//Apxs8uV93pG8qbpsenoeN0m nSht1f4H5EeNVU7+x+x2eMKogYHHX6xtZsgdv4H84Ir5rsilJqhqZE2bEs0iTbFkyQzM H6zK+9c6e529cXNHQj1zyTbFNL5lW0zMbLOuX7GYBrIEYBIaHpLjh4si1UN5v64m8iWl Ye8w== X-Gm-Message-State: APjAAAVWykPiO/itoW0NynkW3knix+qxCcpubRrd2cu0fJy6xuJ1rWw7 XzZ52S+yIubLz7pCCi4O6V6tl+Eaw9jb1JI9vGcTEWfWYdF15XKKV/P2tFZ6ND0lA3KaRUgsGEE i3Bc8R2pi11jziWU= X-Received: by 2002:a1c:f60e:: with SMTP id w14mr11469963wmc.188.1581783361888; Sat, 15 Feb 2020 08:16:01 -0800 (PST) X-Google-Smtp-Source: APXvYqyHKeFfmpvOVz4HkZc7Il/FeQ6MQBGmlkbYvmqQyW1P76z6ZX7+OATJk6WrR8Udh7QO5nTWmA== X-Received: by 2002:a1c:f60e:: with SMTP id w14mr11469954wmc.188.1581783361731; Sat, 15 Feb 2020 08:16:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment Date: Sat, 15 Feb 2020 17:15:55 +0100 Message-Id: <20200215161557.4077-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200215161557.4077-1-philmd@redhat.com> References: <20200215161557.4077-1-philmd@redhat.com> MIME-Version: 1.0 X-MC-Unique: Uyx69B92Pc2ZYxHDdjVEDA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Reitz , Gerd Hoffmann , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC block/qcow2-bitmap.o block/qcow2-bitmap.c:650:5: warning: Value stored to 'ret' is never read ret =3D -EINVAL; ^ ~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: J=C3=A1n Tomko Reviewed-by: Richard Henderson Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c index d41f5d049b..8cccc2c9f3 100644 --- a/block/qcow2-bitmap.c +++ b/block/qcow2-bitmap.c @@ -647,7 +647,6 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverSta= te *bs, uint64_t offset, return bm_list; =20 broken_dir: - ret =3D -EINVAL; error_setg(errp, "Broken bitmap directory"); =20 fail: --=20 2.21.1