From nobody Thu Nov 13 17:45:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581639251799240.07058789249834; Thu, 13 Feb 2020 16:14:11 -0800 (PST) Received: from localhost ([::1]:32994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2OcU-0005uq-E6 for importer@patchew.org; Thu, 13 Feb 2020 19:14:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42568) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2ObW-0004Wm-TA for qemu-devel@nongnu.org; Thu, 13 Feb 2020 19:13:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2ObV-0006yP-Qd for qemu-devel@nongnu.org; Thu, 13 Feb 2020 19:13:10 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:39509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2ObV-0006xO-LA for qemu-devel@nongnu.org; Thu, 13 Feb 2020 19:13:09 -0500 Received: by mail-wr1-x432.google.com with SMTP id y11so8911343wrt.6 for ; Thu, 13 Feb 2020 16:13:09 -0800 (PST) Received: from x1w.redhat.com (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id a16sm4679230wrx.87.2020.02.13.16.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 16:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BURr7oChrNXkwDXgH5BYlsw5Omt/vezePcTIQ4aD6qU=; b=YvTojqqNlH6r1jEo+Lmf9lgk5mUKXhz0GgfAyXMu+38Ji33j+u4OJ5lCR62AGCP9Ws MrbbeF4ugdqjDRkOlJ7Vb9lhGJFdTqbRUUHWXbSJ4+0kQH3/43tjniJZIu6u85LqmyOK oLXjWwgLYrRDYUyJz1ZLH7Stt/B57sbWqFZFfYAswEof31V9mWZMT4G69mvl3FO6uwtD jO3cwYLTFMv8uxb5787x0l1bUxpTvXZ5ZsVBp24jFhsgp62CWoHyybizlLvcJ32Iy1iI xEurRRYeZfKgAYGhQlAovirQ6NY+f7teI/S9/fID9UQGJKgEUGFBo9qP7EVFJKnUuswv SrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BURr7oChrNXkwDXgH5BYlsw5Omt/vezePcTIQ4aD6qU=; b=cpHf5RQhHtzHpUngyDD5yK7ddUMca4SvqRSo1f1GdU1Fa78F4DDSBuLv1qX0TqrGZn sA84Xp/Www/N6b82jlCh+3ELra5QCwDfb7Wd3/UeGzs/OMd7Pf0SiusDPli76c0m7/B7 QrDJ5szoprCoOpYdSJUvP1Cz+x5oKijM0OP2zxUQ3c1No+WnL+ASpeZy/lZnE8BIg6nc faVIjPN8wUeQqjAmfMg1ft3+O1zNhmvYMx77jEZlygVg4h8yJivH8tr1HynvSrU13bo3 vC8YeNdh2WEPwPr7d0BqNHPx7UIe/SRrLCh9dL/2inIAT1/C8cQkGWuo7gIMZ10026Fz fbMw== X-Gm-Message-State: APjAAAW8J4mhVmapqFttIcxxv+FAjxVKaowjnOoi6Rl/d1BofbOevTVj sHA7fVlcnbK1st7LfISyx/A= X-Google-Smtp-Source: APXvYqwfLHQ8DuKrtSlctxFPyN4v5UR/b1UmD5QasLCJkSquNgJhtjxtcV+7fFud89h0zoWgJrFSgQ== X-Received: by 2002:a5d:61c2:: with SMTP id q2mr14492wrv.425.1581639188745; Thu, 13 Feb 2020 16:13:08 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Helge Deller , qemu-devel@nongnu.org, Sven Schnelle Subject: [PATCH 2/5] hw/display/artist: Remove pointless initialization Date: Fri, 14 Feb 2020 01:12:59 +0100 Message-Id: <20200214001303.12873-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200214001303.12873-1-f4bug@amsat.org> References: <20200214001303.12873-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We are initializating incy inconditionally: if (y1 <=3D y2) { incy =3D 1; } else { incy =3D -1; } Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Sven Schnelle --- hw/display/artist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index abacb0e27d..47f0e9f0bc 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -557,91 +557,90 @@ static void fill_window(ARTISTState *s, int startx, i= nt starty, static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2, bool update_start, int skip_pix, int max_pix) { struct vram_buffer *buf; uint8_t color =3D artist_get_color(s); int dx, dy, t, e, x, y, incy, diago, horiz; bool c1; uint8_t *p; =20 trace_artist_draw_line(x1, y1, x2, y2); =20 if (update_start) { s->vram_start =3D (x2 << 16) | y2; } =20 buf =3D &s->vram_buffer[ARTIST_BUFFER_AP]; =20 c1 =3D false; - incy =3D 1; =20 if (x2 > x1) { dx =3D x2 - x1; } else { dx =3D x1 - x2; } if (y2 > y1) { dy =3D y2 - y1; } else { dy =3D y1 - y2; } if (dy > dx) { t =3D y2; y2 =3D x2; x2 =3D t; =20 t =3D y1; y1 =3D x1; x1 =3D t; =20 t =3D dx; dx =3D dy; dy =3D t; =20 c1 =3D true; } =20 if (x1 > x2) { t =3D y2; y2 =3D y1; y1 =3D t; =20 t =3D x1; x1 =3D x2; x2 =3D t; } =20 horiz =3D dy << 1; diago =3D (dy - dx) << 1; e =3D (dy << 1) - dx; =20 if (y1 <=3D y2) { incy =3D 1; } else { incy =3D -1; } x =3D x1; y =3D y1; =20 do { if (c1) { p =3D buf->data + x * s->width + y; } else { p =3D buf->data + y * s->width + x; } =20 if (skip_pix > 0) { skip_pix--; } else { artist_rop8(s, p, color); } =20 if (e > 0) { artist_invalidate_lines(buf, y, 1); y +=3D incy; e +=3D diago; } else { e +=3D horiz; } x++; } while (x <=3D x2 && (max_pix =3D=3D -1 || --max_pix > 0)); } --=20 2.21.1