From nobody Thu Nov 13 16:14:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581414630821761.447236639854; Tue, 11 Feb 2020 01:50:30 -0800 (PST) Received: from localhost ([::1]:46700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1SBZ-00061b-4f for importer@patchew.org; Tue, 11 Feb 2020 04:50:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46635) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1SAS-0004d3-B9 for qemu-devel@nongnu.org; Tue, 11 Feb 2020 04:49:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1SAR-0000mW-7F for qemu-devel@nongnu.org; Tue, 11 Feb 2020 04:49:20 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:53301 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j1SAR-0000mG-3I for qemu-devel@nongnu.org; Tue, 11 Feb 2020 04:49:19 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-OohDAN-eMte_NIqyMjbGAQ-1; Tue, 11 Feb 2020 04:49:15 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2059B800D48; Tue, 11 Feb 2020 09:49:14 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-79.ams2.redhat.com [10.36.117.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD958165D3; Tue, 11 Feb 2020 09:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581414558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fxq5/54+kseiSxGsPENC/qqBcAO/y7qe+/OvFgzHB98=; b=ABwhAb8p+YN9iZh+9g9WRj8j35aTJDyjWfUTgTEI10tEftU6SmDFGVN1lr6VzJ5NgCAPm0 3P9hhcozUKKFwLKrSVEjgiGaRSfZAanprCgWvxb4UL4y76vJes2uBJefq5eVEIygPfDsAi CXAws7ooVm31gB34lGQI2piMT5295Kw= From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PATCH 3/3] iotests: Test copy offloading with external data file Date: Tue, 11 Feb 2020 10:49:00 +0100 Message-Id: <20200211094900.17315-4-kwolf@redhat.com> In-Reply-To: <20200211094900.17315-1-kwolf@redhat.com> References: <20200211094900.17315-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: OohDAN-eMte_NIqyMjbGAQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, pbutsykin@virtuozzo.com, jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This adds a test for 'qemu-img convert' with copy offloading where the target image has an external data file. If the test hosts supports it, it tests both the case where copy offloading is supported and the case where it isn't (otherwise we just test unsupported twice). More specifically, the case with unsupported copy offloading tests qcow2_alloc_cluster_abort() with external data files. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/244 | 14 ++++++++++++++ tests/qemu-iotests/244.out | 6 ++++++ 2 files changed, 20 insertions(+) diff --git a/tests/qemu-iotests/244 b/tests/qemu-iotests/244 index 0d1efee6ef..2ec1815e6f 100755 --- a/tests/qemu-iotests/244 +++ b/tests/qemu-iotests/244 @@ -197,6 +197,20 @@ $QEMU_IO -c 'read -P 0x11 0 1M' -f $IMGFMT "$TEST_IMG"= | _filter_qemu_io $QEMU_IMG map --output=3Dhuman "$TEST_IMG" | _filter_testdir $QEMU_IMG map --output=3Djson "$TEST_IMG" =20 +echo +echo "=3D=3D=3D Copy offloading =3D=3D=3D" +echo + +# Make use of copy offloading if the test host can provide it +_make_test_img -o "data_file=3D$TEST_IMG.data" 64M +$QEMU_IMG convert -f $IMGFMT -O $IMGFMT -n -C "$TEST_IMG.src" "$TEST_IMG" +$QEMU_IMG compare -f $IMGFMT -F $IMGFMT "$TEST_IMG.src" "$TEST_IMG" + +# blkdebug doesn't support copy offloading, so this tests the error path +$QEMU_IMG amend -f $IMGFMT -o "data_file=3Dblkdebug::$TEST_IMG.data" "$TES= T_IMG" +$QEMU_IMG convert -f $IMGFMT -O $IMGFMT -n -C "$TEST_IMG.src" "$TEST_IMG" +$QEMU_IMG compare -f $IMGFMT -F $IMGFMT "$TEST_IMG.src" "$TEST_IMG" + # success, all done echo "*** done" rm -f $seq.full diff --git a/tests/qemu-iotests/244.out b/tests/qemu-iotests/244.out index 6a3d0067cc..e6f4dc7993 100644 --- a/tests/qemu-iotests/244.out +++ b/tests/qemu-iotests/244.out @@ -122,4 +122,10 @@ Offset Length Mapped to File 0 0x100000 0 TEST_DIR/t.qcow2.data [{ "start": 0, "length": 1048576, "depth": 0, "zero": false, "data": true,= "offset": 0}, { "start": 1048576, "length": 66060288, "depth": 0, "zero": true, "data": = false}] + +=3D=3D=3D Copy offloading =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D67108864 data_file=3DT= EST_DIR/t.IMGFMT.data +Images are identical. +Images are identical. *** done --=20 2.20.1