From nobody Thu Nov 13 16:15:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1581024628296884.0231609927642; Thu, 6 Feb 2020 13:30:28 -0800 (PST) Received: from localhost ([::1]:46426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izojD-0002ve-2g for importer@patchew.org; Thu, 06 Feb 2020 16:30:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34791) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izoap-0001DX-5t for qemu-devel@nongnu.org; Thu, 06 Feb 2020 16:21:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izoan-00070I-U5 for qemu-devel@nongnu.org; Thu, 06 Feb 2020 16:21:47 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52528 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izoan-0006y8-Pa for qemu-devel@nongnu.org; Thu, 06 Feb 2020 16:21:45 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-eyAeFl50OB2MPeBv0W30Qw-1; Thu, 06 Feb 2020 16:21:38 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A11C66124F for ; Thu, 6 Feb 2020 21:21:37 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-120.brq.redhat.com [10.40.204.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A11060BEC; Thu, 6 Feb 2020 21:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581024105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0IMXt0m0218x0UlqeNnfj4SNNwPOIT8m1iA4SS91+Vc=; b=eF3S9HKxeFW9kCVddRu//9X9izfM/E1k7JGMwX9uXMYqCoDHQh/GaP8gSrhxnIKuZsq25a 47jvmutuZnEfhMELS2g1iby3lHz2w5n4s0ZTfr4mEs2s1xFrmeDfd1KfN0GjAv78LCWGHM Ff6/ZqzrSkGVZjippRQJCcFEezWhBuQ= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 31/46] scripts/checkpatch.pl: Only allow Python 3 interpreter Date: Thu, 6 Feb 2020 22:19:21 +0100 Message-Id: <20200206211936.17098-32-philmd@redhat.com> In-Reply-To: <20200206211936.17098-1-philmd@redhat.com> References: <20200206211936.17098-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: eyAeFl50OB2MPeBv0W30Qw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Since commit ddf9069963 QEMU requires Python >=3D 3.5. PEP 0394 [*] states that 'python3' should be available and that 'python' is optional. To avoid problem with unsupported versions, enforce the shebang interpreter to Python 3. [*] https://www.python.org/dev/peps/pep-0394/ Reported-by: John Snow Acked-by: Paolo Bonzini Message-Id: <20200130163232.10446-2-philmd@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3aef6e3dfe..ce43a306f8 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1460,6 +1460,12 @@ sub process { } } =20 +# Only allow Python 3 interpreter + if ($realline =3D=3D 1 && + $line =3D~ /^\+#!\ *\/usr\/bin\/(?:env )?python$/) { + ERROR("please use python3 interpreter\n" . $herecurr); + } + # Accept git diff extended headers as valid patches if ($line =3D~ /^(?:rename|copy) (?:from|to) [\w\/\.\-]+\s*$/) { $is_patch =3D 1; --=20 2.21.1