From nobody Thu Nov 13 13:41:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158045105618669.06432413004518; Thu, 30 Jan 2020 22:10:56 -0800 (PST) Received: from localhost ([::1]:48666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixPW1-0008QR-Ji for importer@patchew.org; Fri, 31 Jan 2020 01:10:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59031) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixPUo-0006af-Ak for qemu-devel@nongnu.org; Fri, 31 Jan 2020 01:09:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixPUm-0000Ia-VS for qemu-devel@nongnu.org; Fri, 31 Jan 2020 01:09:37 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:45669) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixPUm-0008UR-6e; Fri, 31 Jan 2020 01:09:36 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4886Hr5TRRz9sRR; Fri, 31 Jan 2020 17:09:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1580450968; bh=dCdn1ruMSLsjZuuCJv7VxVhSfR0TgqtIsrQxGA4YTIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hyh5BhzR9XryLL/qHuv79n/GajVrhk7NO2MD39VNPsoffkIvbTg99ljqr015BvoNG AJ7ZR/neLDgbb2JuKQypqxSHjRNMufOYMKZQbaFx5Ax8RA43YKEzSmuzDeYh8XbQHe SZ7UW5Vp5lbh2OC0IXENqG4EL6JLWZ/iQLJ6awEM= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 02/34] ppc/pnv: improve error logging when a PNOR update fails Date: Fri, 31 Jan 2020 17:08:52 +1100 Message-Id: <20200131060924.147449-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200131060924.147449-1-david@gibson.dropbear.id.au> References: <20200131060924.147449-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: C=C3=A9dric Le Goater Print out the offset at which the error occured. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20200108090348.21224-3-clg@kaod.org> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_pnor.c index 060c6e6a31..c365ee58b8 100644 --- a/hw/ppc/pnv_pnor.c +++ b/hw/ppc/pnv_pnor.c @@ -47,7 +47,8 @@ static void pnv_pnor_update(PnvPnor *s, int offset, int s= ize) ret =3D blk_pwrite(s->blk, offset, s->storage + offset, offset_end - offset, 0); if (ret < 0) { - error_report("Could not update PNOR: %s", strerror(-ret)); + error_report("Could not update PNOR offset=3D0x%" PRIx32" : %s", o= ffset, + strerror(-ret)); } } =20 --=20 2.24.1