From nobody Thu Nov 13 13:37:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1580420559468175.60398860401142; Thu, 30 Jan 2020 13:42:39 -0800 (PST) Received: from localhost ([::1]:39526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixHaA-00087s-Ay for importer@patchew.org; Thu, 30 Jan 2020 16:42:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixHWc-0002Ov-NT for qemu-devel@nongnu.org; Thu, 30 Jan 2020 16:38:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixHWb-0000sY-16 for qemu-devel@nongnu.org; Thu, 30 Jan 2020 16:38:58 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:48611 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixHWa-0000qA-BG for qemu-devel@nongnu.org; Thu, 30 Jan 2020 16:38:56 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-138-Srb6hHFnMDO8bl6-4fxtgQ-1; Thu, 30 Jan 2020 16:38:47 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5AE92800D48; Thu, 30 Jan 2020 21:38:46 +0000 (UTC) Received: from localhost (unknown [10.36.118.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 048E987B00; Thu, 30 Jan 2020 21:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580420329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOdBGk8Ti42m26thpGsTgXlNQcjGRQeyLHjmuldSczI=; b=edXKZc8p/UahxnfOE2N+CEwR/0tNJMpI8HiuLHVAtuslqxAljjahWC6hxlX5IprJ5v+je/ 8NQob//8Ij8yvm8OSCGgNa2jP2UrSU9/MbzeTlEb+7RbeLmDoTt87p69EgqLHVb8PgYHJS 2jV2QvtnYE9QUVJClweaexDBWMP2BKM= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 4/5] hw/display/qxl.c: Use trace_event_get_state_backends() Date: Thu, 30 Jan 2020 21:38:13 +0000 Message-Id: <20200130213814.334195-5-stefanha@redhat.com> In-Reply-To: <20200130213814.334195-1-stefanha@redhat.com> References: <20200130213814.334195-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: Srb6hHFnMDO8bl6-4fxtgQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Peter Maydell The preferred way to test whether a trace event is enabled is to use trace_event_get_state_backends(), because this will give the correct answer (allowing expensive computations to be skipped) whether the trace event is compile-time or run-time disabled. Convert the old-style direct use of TRACE_FOO_ENABLED. Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann Message-id: 20200120151142.18954-4-peter.maydell@linaro.org Message-Id: <20200120151142.18954-4-peter.maydell@linaro.org> Signed-off-by: Stefan Hajnoczi --- hw/display/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 944c02ce56..c33b1915a5 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1764,7 +1764,7 @@ async_common: qxl_set_mode(d, val, 0); break; case QXL_IO_LOG: - if (TRACE_QXL_IO_LOG_ENABLED || d->guestdebug) { + if (trace_event_get_state_backends(TRACE_QXL_IO_LOG) || d->guestde= bug) { /* We cannot trust the guest to NUL terminate d->ram->log_buf = */ char *log_buf =3D g_strndup((const char *)d->ram->log_buf, sizeof(d->ram->log_buf)); --=20 2.24.1