From nobody Thu Nov 13 13:37:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1580341946306884.461172670554; Wed, 29 Jan 2020 15:52:26 -0800 (PST) Received: from localhost ([::1]:53181 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwx8C-0007be-Ux for importer@patchew.org; Wed, 29 Jan 2020 18:52:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43016) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwx6d-0005yo-AS for qemu-devel@nongnu.org; Wed, 29 Jan 2020 18:50:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwx6c-0001ra-07 for qemu-devel@nongnu.org; Wed, 29 Jan 2020 18:50:47 -0500 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:36660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwx6b-0001pk-Qc for qemu-devel@nongnu.org; Wed, 29 Jan 2020 18:50:45 -0500 Received: by mail-pf1-x441.google.com with SMTP id 185so497754pfv.3 for ; Wed, 29 Jan 2020 15:50:45 -0800 (PST) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id 13sm3740195pfi.78.2020.01.29.15.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 15:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qyfFVuPo0F6BFeJ8jXlvXMSw2kK/b7kOhlz/lPj6CW4=; b=wasyW8lczuJDXuFCGuK87RFtGHo2fiX/qHP4QFWT5uOLKqeej16kyCfcznIpOzsBv1 SyT3NWKNVpQZu4roVe+U2VCClqjOPSgicYjnAblP8AgjducFq4Ol+4rKzv7ou56vLd6j v71MK6YLGFcovaxGBA8oDdwCJBy1RzM9kvBylR0U5SfE2CxF1qPG0BE1MNynUXnijqc8 4A47r+lRxX8/Z7poZLOvyQ33QybW/g+ZepcJrpkDGobiEf1p3Gs9afq9+JBD7seDOVsX k0NSX6awFobRSjuqV+vzlJwxtVVWfkdODDXkVEF3ASRn6SJl86sQKqUtul+Vq2NjWwnF eDMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qyfFVuPo0F6BFeJ8jXlvXMSw2kK/b7kOhlz/lPj6CW4=; b=TKbIqzusQOI4W/sQ9sCG8NPcCdmQ9yYNX9QaHlxxnKvFYdDfzGftR935MDNI7aGOYm CVu7C9enu+U6u9S1Q08VvpNcY3wnzZwhXrgnEpXgNg88jusl4KulMt3gMolrxxaAQrzD pwMuJYNrxUZvIC2zCnskATE7CujA+lM+9iWme+1PpmHMOFtXvTYhzHD8IqC5oZkSaFn7 xgLtguJiuEs7VyliIQacxbEXbNTcsUEAYLqhv6QcQ4J/PLcCVVYe+4m1ORdFClc5Jkcr rKXbNn59sV/2aoqs+0La20t6iI0WAr0SSErHzQxsaLP/+VcME+Vx0vLvNJi+R/tI7EVs LlIw== X-Gm-Message-State: APjAAAW4YD3z0XMXIhSZ9Eqyfy31GnhceGvsOkf57HDgSfANj/FQG2cw mBzVF4pxrsA5oqZZrx54UQ9hB6rBkEM= X-Google-Smtp-Source: APXvYqxVwNqNiRVK4W15aA9wFuyCT9DJsBYp0WrqCiOdBFRpw590VjVVdrHabUI9kY+OP6jKmcmOsg== X-Received: by 2002:a62:fc93:: with SMTP id e141mr2029742pfh.262.1580341844438; Wed, 29 Jan 2020 15:50:44 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/4] target/ppc: Use probe_access for LSW, STSW Date: Wed, 29 Jan 2020 15:50:37 -0800 Message-Id: <20200129235040.24022-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200129235040.24022-1-richard.henderson@linaro.org> References: <20200129235040.24022-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hsp.cat7@gmail.com, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Use a minimum number of mmu lookups for the contiguous bytes that are accessed. If the lookup succeeds, we can finish the operation with host addresses only. Reported-by: Howard Spoelstra Signed-off-by: Richard Henderson --- target/ppc/mem_helper.c | 148 ++++++++++++++++++++++++++++++++++------ 1 file changed, 128 insertions(+), 20 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index e8e2a8ac2a..508d472a2f 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -56,6 +56,32 @@ static inline target_ulong addr_add(CPUPPCState *env, ta= rget_ulong addr, } } =20 +static void *probe_contiguous(CPUPPCState *env, target_ulong addr, uint32_= t nb, + MMUAccessType access_type, int mmu_idx, + uintptr_t raddr) +{ + void *host1, *host2; + uint32_t nb_pg1, nb_pg2; + + nb_pg1 =3D -(addr | TARGET_PAGE_MASK); + if (likely(nb <=3D nb_pg1)) { + /* The entire operation is on a single page. */ + return probe_access(env, addr, nb, access_type, mmu_idx, raddr); + } + + /* The operation spans two pages. */ + nb_pg2 =3D nb - nb_pg1; + host1 =3D probe_access(env, addr, nb_pg1, access_type, mmu_idx, raddr); + addr =3D addr_add(env, addr, nb_pg1); + host2 =3D probe_access(env, addr, nb_pg2, access_type, mmu_idx, raddr); + + /* If the two host pages are contiguous, optimize. */ + if (host2 =3D=3D host1 + nb_pg1) { + return host1; + } + return NULL; +} + void helper_lmw(CPUPPCState *env, target_ulong addr, uint32_t reg) { for (; reg < 32; reg++) { @@ -84,23 +110,65 @@ void helper_stmw(CPUPPCState *env, target_ulong addr, = uint32_t reg) static void do_lsw(CPUPPCState *env, target_ulong addr, uint32_t nb, uint32_t reg, uintptr_t raddr) { - int sh; + int mmu_idx; + void *host; + uint32_t val; =20 - for (; nb > 3; nb -=3D 4) { - env->gpr[reg] =3D cpu_ldl_data_ra(env, addr, raddr); - reg =3D (reg + 1) % 32; - addr =3D addr_add(env, addr, 4); + if (unlikely(nb =3D=3D 0)) { + return; } - if (unlikely(nb > 0)) { - env->gpr[reg] =3D 0; - for (sh =3D 24; nb > 0; nb--, sh -=3D 8) { - env->gpr[reg] |=3D cpu_ldub_data_ra(env, addr, raddr) << sh; - addr =3D addr_add(env, addr, 1); + + mmu_idx =3D cpu_mmu_index(env, false); + host =3D probe_contiguous(env, addr, nb, MMU_DATA_LOAD, mmu_idx, raddr= ); + + if (likely(host)) { + /* Fast path -- the entire operation is in RAM at host. */ + for (; nb > 3; nb -=3D 4) { + env->gpr[reg] =3D (uint32_t)ldl_be_p(host); + reg =3D (reg + 1) % 32; + host +=3D 4; + } + switch (nb) { + default: + return; + case 1: + val =3D ldub_p(host) << 24; + break; + case 2: + val =3D lduw_be_p(host) << 16; + break; + case 3: + val =3D (lduw_be_p(host) << 16) | (ldub_p(host + 2) << 8); + break; + } + } else { + /* Slow path -- at least some of the operation requires i/o. */ + for (; nb > 3; nb -=3D 4) { + env->gpr[reg] =3D cpu_ldl_mmuidx_ra(env, addr, mmu_idx, raddr); + reg =3D (reg + 1) % 32; + addr =3D addr_add(env, addr, 4); + } + switch (nb) { + default: + return; + case 1: + val =3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 24; + break; + case 2: + val =3D cpu_lduw_mmuidx_ra(env, addr, mmu_idx, raddr) << 16; + break; + case 3: + val =3D cpu_lduw_mmuidx_ra(env, addr, mmu_idx, raddr) << 16; + addr =3D addr_add(env, addr, 2); + val |=3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 8; + break; } } + env->gpr[reg] =3D val; } =20 -void helper_lsw(CPUPPCState *env, target_ulong addr, uint32_t nb, uint32_t= reg) +void helper_lsw(CPUPPCState *env, target_ulong addr, + uint32_t nb, uint32_t reg) { do_lsw(env, addr, nb, reg, GETPC()); } @@ -130,17 +198,57 @@ void helper_lswx(CPUPPCState *env, target_ulong addr,= uint32_t reg, void helper_stsw(CPUPPCState *env, target_ulong addr, uint32_t nb, uint32_t reg) { - int sh; + uintptr_t raddr =3D GETPC(); + int mmu_idx; + void *host; + uint32_t val; =20 - for (; nb > 3; nb -=3D 4) { - cpu_stl_data_ra(env, addr, env->gpr[reg], GETPC()); - reg =3D (reg + 1) % 32; - addr =3D addr_add(env, addr, 4); + if (unlikely(nb =3D=3D 0)) { + return; } - if (unlikely(nb > 0)) { - for (sh =3D 24; nb > 0; nb--, sh -=3D 8) { - cpu_stb_data_ra(env, addr, (env->gpr[reg] >> sh) & 0xFF, GETPC= ()); - addr =3D addr_add(env, addr, 1); + + mmu_idx =3D cpu_mmu_index(env, false); + host =3D probe_contiguous(env, addr, nb, MMU_DATA_STORE, mmu_idx, radd= r); + + if (likely(host)) { + /* Fast path -- the entire operation is in RAM at host. */ + for (; nb > 3; nb -=3D 4) { + stl_be_p(host, env->gpr[reg]); + reg =3D (reg + 1) % 32; + host +=3D 4; + } + val =3D env->gpr[reg]; + switch (nb) { + case 1: + stb_p(host, val >> 24); + break; + case 2: + stw_be_p(host, val >> 16); + break; + case 3: + stw_be_p(host, val >> 16); + stb_p(host + 2, val >> 8); + break; + } + } else { + for (; nb > 3; nb -=3D 4) { + cpu_stl_mmuidx_ra(env, addr, env->gpr[reg], mmu_idx, raddr); + reg =3D (reg + 1) % 32; + addr =3D addr_add(env, addr, 4); + } + val =3D env->gpr[reg]; + switch (nb) { + case 1: + cpu_stb_mmuidx_ra(env, addr, val >> 24, mmu_idx, raddr); + break; + case 2: + cpu_stw_mmuidx_ra(env, addr, val >> 16, mmu_idx, raddr); + break; + case 3: + cpu_stw_mmuidx_ra(env, addr, val >> 16, mmu_idx, raddr); + addr =3D addr_add(env, addr, 2); + cpu_stb_mmuidx_ra(env, addr, val >> 8, mmu_idx, raddr); + break; } } } --=20 2.20.1