From nobody Mon Feb 9 17:42:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1580141314547978.2862371780154; Mon, 27 Jan 2020 08:08:34 -0800 (PST) Received: from localhost ([::1]:47352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iw6wD-0004Xj-GK for importer@patchew.org; Mon, 27 Jan 2020 11:08:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55273) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iw6rC-0000Gi-FA for qemu-devel@nongnu.org; Mon, 27 Jan 2020 11:03:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iw6rB-00005b-Bi for qemu-devel@nongnu.org; Mon, 27 Jan 2020 11:03:22 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:39430) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iw6rB-00005B-1O for qemu-devel@nongnu.org; Mon, 27 Jan 2020 11:03:21 -0500 Received: by mail-wr1-x444.google.com with SMTP id y11so11984846wrt.6 for ; Mon, 27 Jan 2020 08:03:20 -0800 (PST) Received: from f2.redhat.com (bzq-79-177-42-131.red.bezeqint.net. [79.177.42.131]) by smtp.gmail.com with ESMTPSA id q6sm23201735wrx.72.2020.01.27.08.03.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2020 08:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=AIWtQBvIG6Lr4Ru2WkatZ9cwdRhOTo31fuXr+snCDZI=; b=Cn9rPD9h1owjIAnoXorZwUk9leD1DOl8+bckgAVPTLXo7hNSYcngASblPQU6yg+FrD JzMVV1bYRBwHhGOSS/PbxbqdWaVcYtqRUtBaqUQMDoLJBQZS7CL1R1t4YfIf5nNbgh8e BEw4ZncYsREGmoPevCXtZN48MQsV7Zo+odcwy4RcFY6XfQ9Et5U5B60IxsIl2pNdf3Vn NiKJ6wmoe2zAx9ZzVAO2TdcqLpcwx0MLe0gc453uC+myPbCY+cuOxGIdzqqctIEYvBLL 64p4/IYUMCdWP+YUEbKg4AacgWCMmGai/w+22vBR1C7ZSRmNTm0FD65kJvYPxwLFWTlc vuFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AIWtQBvIG6Lr4Ru2WkatZ9cwdRhOTo31fuXr+snCDZI=; b=bkNXpS51v3ss8XPuLrBgGohO4mdo7cKYKey/z60tivz3DBDe9kgdHt1lobLVLjfS+Q dy6GpGBJbkaUsVnQaIpZnNmwZyXv11HTqD0agSxHyv7jyKFcSmBIoQG1GYi/anODI3D2 3XszchP/bN0odWlIbxyYhkEUdaBZeHNOcMFsIVCJoofuiPxFi7jOKVUPeERmGcT7EBfo YcsN1+zShA7V7H+r7qtKWhsTL4mUrdFO9FjzzH4Ul+Se/w7Z4TnFVmeoaA7q+pYuS1E0 Sp5CjalzZA1YcW4t0qBVQ2uq1C15gM0uv7jxsrmSXHeNZAh1KAC3H19oBYIwaqW6ipab k3Sg== X-Gm-Message-State: APjAAAXYdZXCfVugDGVPtowrUoFXJ+CPkbYdNL8UvRHJzQ3J0kRfCEhX sTkx1iIAYfjVnLcOUtJQml7jHw== X-Google-Smtp-Source: APXvYqxIvdX/a2dKldyy9qpr8Gq0V0VTfA14Qh7lZoOH+CehGuHU0Mc4wR5DrdedvcRGagCwwJh23A== X-Received: by 2002:adf:eb8e:: with SMTP id t14mr22297089wrn.384.1580140999839; Mon, 27 Jan 2020 08:03:19 -0800 (PST) From: Yuri Benditovich To: dmitry.fleytman@gmail.com, jasowang@redhat.com, qemu-devel@nongnu.org Subject: [PATCH] e1000e: Avoid hw_error if legacy mode used Date: Mon, 27 Jan 2020 18:03:12 +0200 Message-Id: <20200127160312.31367-1-yuri.benditovich@daynix.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yan@daynix.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @daynix-com.20150623.gappssmtp.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" https://bugzilla.redhat.com/show_bug.cgi?id=3D1787142 The emulation issues hw_error if PSRCTL register is written, for example, with zero value. Such configuration does not present any problem when DTYP bits of RCTL register define legacy format of transfer descriptors. Current commit discards check for BSIZE0 and BSIZE1 when legacy mode used. Signed-off-by: Yuri Benditovich Acked-by: Dmitry Fleytman --- hw/net/e1000e_core.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 5b05c8ea8a..94ea34dca5 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2813,12 +2813,15 @@ e1000e_set_eitr(E1000ECore *core, int index, uint32= _t val) static void e1000e_set_psrctl(E1000ECore *core, int index, uint32_t val) { - if ((val & E1000_PSRCTL_BSIZE0_MASK) =3D=3D 0) { - hw_error("e1000e: PSRCTL.BSIZE0 cannot be zero"); - } + if (core->mac[RCTL] & E1000_RCTL_DTYP_MASK) { + + if ((val & E1000_PSRCTL_BSIZE0_MASK) =3D=3D 0) { + hw_error("e1000e: PSRCTL.BSIZE0 cannot be zero"); + } =20 - if ((val & E1000_PSRCTL_BSIZE1_MASK) =3D=3D 0) { - hw_error("e1000e: PSRCTL.BSIZE1 cannot be zero"); + if ((val & E1000_PSRCTL_BSIZE1_MASK) =3D=3D 0) { + hw_error("e1000e: PSRCTL.BSIZE1 cannot be zero"); + } } =20 core->mac[PSRCTL] =3D val; --=20 2.17.1