From nobody Tue Feb 10 19:15:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1579908185; cv=none; d=zohomail.com; s=zohoarc; b=Xq8GXn96G3M9xDm6UPcp9wYjyhX4IAQYjdUVHVhvW4xcwRqK9UBelLzEorpbxAKqeel2hf9hEqN4Uw+c8zO/XhgG7qdTb/BwBv1aEMKV8o+OP/EsmVQ41EVxTYWL3EmvQKRRFgPT4qceIycBcd2FMcUIvlonVLGOzDhNDKLY/Qc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579908185; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ByWTVem8tb3au/b4x5fdyhlm60dqCY2c6IfxCbm59X0=; b=ltwVVFG3j3N4V+uFvtSa5+B8aoEMQiEPGJHHYV93OVoNaisMiG6NN2CK07ZueB/OzQJvOYWwM/GbKst9+5MkCTdDjL8PDN7t9+iuNHc66++C+IOwJkRuFelQ27jOzreS4U+wM+5un6YmlDCeCWa9AoUP6Pm6uxneiBuoA+ZzDu0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579908184836956.5161339437433; Fri, 24 Jan 2020 15:23:04 -0800 (PST) Received: from localhost ([::1]:49216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iv8I3-0000DY-L8 for importer@patchew.org; Fri, 24 Jan 2020 18:23:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58645) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iv8FS-0004AZ-BO for qemu-devel@nongnu.org; Fri, 24 Jan 2020 18:20:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iv8FR-0005ck-8F for qemu-devel@nongnu.org; Fri, 24 Jan 2020 18:20:22 -0500 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:32816) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iv8FR-0005bZ-2B for qemu-devel@nongnu.org; Fri, 24 Jan 2020 18:20:21 -0500 Received: by mail-pf1-x442.google.com with SMTP id n7so1811146pfn.0 for ; Fri, 24 Jan 2020 15:20:20 -0800 (PST) Received: from localhost.localdomain (rrcs-173-198-77-92.west.biz.rr.com. [173.198.77.92]) by smtp.gmail.com with ESMTPSA id v4sm8377880pgo.63.2020.01.24.15.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 15:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ByWTVem8tb3au/b4x5fdyhlm60dqCY2c6IfxCbm59X0=; b=Br9LTCmb3fHHoMJ2MWzIPXAkX+oT9fIPBUN4JkUqmr6mG0rdlgG51lo2u9oxbMomou ffTMej6qVXVDZSDcMyoM82RUkqWWFR31hIF3L6g+z/xb8lp5zaLd5X/Rr5nwnMkkVU0F zaY3csbaNz9J/wRpFXtVi2l8HhOS843J8kmc58zJr1xKil776RJ6OdnuN3tfKyF9Q3YW sOAPJYBMZo7itF7F0s/wc72uc/MC22/o2PEBmLky04/NmX7wkourPBhf5oCU9v0RQWDV MH9XUDVTPN7mCAmGNlgZT2eWHO6ZYFGsSOlRmHBDqzHDcGCGJv7qaqLAFh+oY9SiNgSC 4oCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ByWTVem8tb3au/b4x5fdyhlm60dqCY2c6IfxCbm59X0=; b=Tl0JBtZiQaIKlJ/rbBq3YGu2daJFSQn788zx5bAQLemAvhSnWa8/Fpg2GJ7N9FEY1U CsKYuUL0qUp1KprbHGnf91AvCMOHmKPnnugt93jH9VMcTsReVDh8xdp5PyL2i3GFX/9Y igwvKsgFJHUBBu50xt4E8X1JKSuXDi7kvYwOsEshWwt7p528VvsiywZvsKd9Mr69lghY T2zLC8FiBlHAf1HJl7g8cLLa8CvB3rnxJQ8BaIHdib9FdpdG3my2MaK1cOJh1fnrgYr9 JBCl4goRjDTC4gAuNZPVIj8L7pkKsp3mg4vUd1k4T4Lgu7jwhL7MzJHp7c5GFnSAYzaU LhGw== X-Gm-Message-State: APjAAAVtLyGJQqXGZkFepAOYcjja3j0ZieqMMhQrSBv9eH/6tcCV031u u5ZeX6XGxQ8qMzs0P33G8BhagLjNuK0= X-Google-Smtp-Source: APXvYqyZa76WxCEGXd3jfRbB28Pv+pyanPvYmGnJrdWZ1QKCvUyyLGk0b8CFUv9tWr5HyxeYMoL5lQ== X-Received: by 2002:aa7:94a4:: with SMTP id a4mr5436833pfl.178.1579908019143; Fri, 24 Jan 2020 15:20:19 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL v3 03/11] ps2: accept 'Set Key Make and Break' commands Date: Fri, 24 Jan 2020 13:20:01 -1000 Message-Id: <20200124232009.12928-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200124232009.12928-1-richard.henderson@linaro.org> References: <20200124232009.12928-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, deller@gmx.de, svens@stackframe.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Sven Schnelle HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven Schnelle Message-Id: <20191220211512.3289-4-svens@stackframe.org> Signed-off-by: Richard Henderson --- hw/input/ps2.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 67f92f6112..0b671b6339 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -49,6 +49,8 @@ #define KBD_CMD_RESET_DISABLE 0xF5 /* reset and disable scanning */ #define KBD_CMD_RESET_ENABLE 0xF6 /* reset and enable scanning */ #define KBD_CMD_RESET 0xFF /* Reset */ +#define KBD_CMD_SET_MAKE_BREAK 0xFC /* Set Make and Break mode */ +#define KBD_CMD_SET_TYPEMATIC 0xFA /* Set Typematic Make and Break mo= de */ =20 /* Keyboard Replies */ #define KBD_REPLY_POR 0xAA /* Power on reset */ @@ -573,6 +575,7 @@ void ps2_write_keyboard(void *opaque, int val) case KBD_CMD_SCANCODE: case KBD_CMD_SET_LEDS: case KBD_CMD_SET_RATE: + case KBD_CMD_SET_MAKE_BREAK: s->common.write_cmd =3D val; ps2_queue(&s->common, KBD_REPLY_ACK); break; @@ -592,11 +595,18 @@ void ps2_write_keyboard(void *opaque, int val) KBD_REPLY_ACK, KBD_REPLY_POR); break; + case KBD_CMD_SET_TYPEMATIC: + ps2_queue(&s->common, KBD_REPLY_ACK); + break; default: ps2_queue(&s->common, KBD_REPLY_RESEND); break; } break; + case KBD_CMD_SET_MAKE_BREAK: + ps2_queue(&s->common, KBD_REPLY_ACK); + s->common.write_cmd =3D -1; + break; case KBD_CMD_SCANCODE: if (val =3D=3D 0) { if (s->common.queue.count <=3D PS2_QUEUE_SIZE - 2) { --=20 2.20.1