From nobody Fri Oct 3 11:40:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579805458; cv=none; d=zohomail.com; s=zohoarc; b=SIGozICqsCwdDjsgI3eTBpcrPiJMCfx16yHE75DdEoOEdipME/Scfmnoks2EWDDPHXwQbp8g1TPL3MrlnQV7bcJQhae0b4+nehHAehSv0Htr/7faR21rieZZa6EFHCFXWHaxCAiNWM34Vgu+WOQ4ByWh7AHXcCdzd+Q/H1WK4Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579805458; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qHRBtI8mqc/+h6vY0sDSH8KnWBJyk6xG64HuaxZqdiY=; b=b5UKe9xhqKmWpk0UzhFXPzU8FWAPd68XWI6NtzGp64VNvv2nSuyKg5uwqjOZ5MCnEf0di2AxMHcdR//QcSG1u6afiKza6QI+F4Sm/20Q6SqfCTRnlcspjqmgJ5dlgW/D+2z9g3XZhAzbafawiJO6kcjzQX2C8CiPVvhsyMUTJZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579805458287511.63233605300684; Thu, 23 Jan 2020 10:50:58 -0800 (PST) Received: from localhost ([::1]:35078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuhZA-0006cn-DT for importer@patchew.org; Thu, 23 Jan 2020 13:50:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42250) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufea-0005kI-MK for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:48:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iufeZ-0007j0-Iz for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:48:24 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53621 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iufeZ-0007iN-G3 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:48:23 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-wuhlraj7No21MxkWntpDiQ-1; Thu, 23 Jan 2020 11:48:21 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDE8C10883AD for ; Thu, 23 Jan 2020 16:48:20 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-116-110.ams2.redhat.com [10.36.116.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 330E728991; Thu, 23 Jan 2020 16:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579798103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qHRBtI8mqc/+h6vY0sDSH8KnWBJyk6xG64HuaxZqdiY=; b=ieOkSR7qli3dmivWRIz9zuXsm3jp9JMYrFU2o6KSgCLtGWhb5QuxrJYk9uJF5h9UvBuCnv 3dDMGEfXqsBNWJJrmlHSvgyZqwQoFq+uYF5nnZt1hT22khzuZO+O2CK/3RbAO20Ugb9h8Y Zsaebvh0t9a8w6X1EksE2ERfvzBsE58= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com Subject: [PULL 079/108] virtiofsd: fix memory leak on lo.source Date: Thu, 23 Jan 2020 16:46:01 +0000 Message-Id: <20200123164630.91498-80-dgilbert@redhat.com> In-Reply-To: <20200123164630.91498-1-dgilbert@redhat.com> References: <20200123164630.91498-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: wuhlraj7No21MxkWntpDiQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Liu Bo valgrind reported that lo.source is leaked on quiting, but it was defined as (const char*) as it may point to a const string "/". Signed-off-by: Liu Bo Reviewed-by: Misono Tomohiro Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index af050c6d97..056ebe8556 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -115,7 +115,7 @@ struct lo_data { int writeback; int flock; int xattr; - const char *source; + char *source; double timeout; int cache; int timeout_set; @@ -2497,9 +2497,8 @@ int main(int argc, char *argv[]) fuse_log(FUSE_LOG_ERR, "source is not a directory\n"); exit(1); } - } else { - lo.source =3D "/"; + lo.source =3D strdup("/"); } if (!lo.timeout_set) { switch (lo.cache) { @@ -2570,5 +2569,7 @@ err_out1: close(lo.root.fd); } =20 + free(lo.source); + return ret ? 1 : 0; } --=20 2.24.1