From nobody Fri Oct 3 11:25:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579807397; cv=none; d=zohomail.com; s=zohoarc; b=jmi8sLg9tFfRcAY4U1Ei98o1UBsS2l9KdCj+/+TxyooItQ4fG4yh81xTqFe/ykApZEM15UvbfLIp1DQImxnXByzfQe2Eaj/X2D6Eu5lGZbLbeLOi58XTT5dlHaDkv2x1EdtO8VRZ9eXQwK16llHYJ7TmVUaTmiy4rPIQTeb/ywQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579807397; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7tel/nd2zE/ZyJVWTivJ5OAyTm2pwU+ekwsLBhz3zxc=; b=JUyfIxK40Hw7p8NDkX4PIkV9yGB9BWzckFe33wMHnU/NAvkTTFyAkIqtZhnnPZfs86Bb4W0jweBW4Xvs3mALjD5cm+6bXFpTEFgHdn+3bAx2WjT97l805nP04n9Vz5QOMbiNziHN5WWUq8QdtRuNUsHm+ehMBG/c44tTPyXQCkw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579807397492610.7566195462936; Thu, 23 Jan 2020 11:23:17 -0800 (PST) Received: from localhost ([::1]:35606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iui4R-0003AC-Q2 for importer@patchew.org; Thu, 23 Jan 2020 14:23:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40940) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufdO-0004Nd-6S for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:47:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iufdN-0006F2-2y for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:47:10 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54747 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iufdM-0006Ej-W2 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:47:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-TNwM0dhHOyWLOBjQn-q-Ww-1; Thu, 23 Jan 2020 11:47:05 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C44F78C7AD2 for ; Thu, 23 Jan 2020 16:47:04 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-116-110.ams2.redhat.com [10.36.116.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D21C28991; Thu, 23 Jan 2020 16:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579798028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tel/nd2zE/ZyJVWTivJ5OAyTm2pwU+ekwsLBhz3zxc=; b=ByEXoCbaYMnaF8fXUC3LnppZ5XFjfSh+K2UZ1fG/LsCxTzUzP1P5lzBLrdVfgQ1lqfzrnS o8Und7VUy9WdqcvCzdbpPKpYgh5GX+Bziph17Z/5/6pPpoHWfhjKQcK1A33rZwnzZRXjzQ BlvjE0vEujUVWfbBfWioPYD3g4uIxdE= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com Subject: [PULL 015/108] virtiofsd: Make fsync work even if only inode is passed in Date: Thu, 23 Jan 2020 16:44:57 +0000 Message-Id: <20200123164630.91498-16-dgilbert@redhat.com> In-Reply-To: <20200123164630.91498-1-dgilbert@redhat.com> References: <20200123164630.91498-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: TNwM0dhHOyWLOBjQn-q-Ww-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Vivek Goyal If caller has not sent file handle in request, then using inode, retrieve the fd opened using O_PATH and use that to open file again and issue fsync. This will be needed when dax_flush() calls fsync. At that time we only have inode information (and not file). Signed-off-by: Vivek Goyal Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 6 +++++- tools/virtiofsd/passthrough_ll.c | 28 ++++++++++++++++++++++++++-- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowleve= l.c index 514d79cb24..8552cfb8af 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -1075,7 +1075,11 @@ static void do_fsync(fuse_req_t req, fuse_ino_t node= id, const void *inarg) fi.fh =3D arg->fh; =20 if (req->se->op.fsync) { - req->se->op.fsync(req, nodeid, datasync, &fi); + if (fi.fh =3D=3D (uint64_t)-1) { + req->se->op.fsync(req, nodeid, datasync, NULL); + } else { + req->se->op.fsync(req, nodeid, datasync, &fi); + } } else { fuse_reply_err(req, ENOSYS); } diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index 6c4da18075..26ac87013b 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -903,10 +903,34 @@ static void lo_fsync(fuse_req_t req, fuse_ino_t ino, = int datasync, { int res; (void)ino; + int fd; + char *buf; + + fuse_log(FUSE_LOG_DEBUG, "lo_fsync(ino=3D%" PRIu64 ", fi=3D0x%p)\n", i= no, + (void *)fi); + + if (!fi) { + res =3D asprintf(&buf, "/proc/self/fd/%i", lo_fd(req, ino)); + if (res =3D=3D -1) { + return (void)fuse_reply_err(req, errno); + } + + fd =3D open(buf, O_RDWR); + free(buf); + if (fd =3D=3D -1) { + return (void)fuse_reply_err(req, errno); + } + } else { + fd =3D fi->fh; + } + if (datasync) { - res =3D fdatasync(fi->fh); + res =3D fdatasync(fd); } else { - res =3D fsync(fi->fh); + res =3D fsync(fd); + } + if (!fi) { + close(fd); } fuse_reply_err(req, res =3D=3D -1 ? errno : 0); } --=20 2.24.1