From nobody Mon Feb 9 15:09:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1579790760; cv=none; d=zohomail.com; s=zohoarc; b=A8ILc+YybmLMRo4XRR4432Yz2x5XsJp24aMZHzIw/0a534XZNMBd4NyrSfMfQ8aqgy3gKagAI0ANOGTQZEUS2C7M32NBqMoTJPauNS6Zz9pYZk7kjXdglm9ZdwA48YkAdoSLLAT5z5sC4PZpoor4jOMEzNfBIgsJexFyLpsFnM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579790760; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aJJM0vtTHXXmtrVHVv2W28wyOU8ZxR/iN7ySpCdtVXQ=; b=BXcRPQ/9R1bAiaqcGHAresjpjhkqIEpeUfvmMhOIo8YsPwvrP85qe3+LPjRGHGdnpT6mYf/oIQ0tzpja87C8sKWqsG8lYbkc5OSkwNDzrhGeOWIELqOJbi3puOQTrYbCEOCuC7Y1YDfBTicSHDPU7UlJb+UF5ABI1UnRDfS2+F4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579790760747873.9713788383012; Thu, 23 Jan 2020 06:46:00 -0800 (PST) Received: from localhost ([::1]:58346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iudk6-0003yD-Tg for importer@patchew.org; Thu, 23 Jan 2020 09:45:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46121) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iucUO-0001Fl-Ip for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:25:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iucUM-0000r1-Cu for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:25:40 -0500 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:52540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iucUM-0000oh-1I for qemu-devel@nongnu.org; Thu, 23 Jan 2020 08:25:38 -0500 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id 48E8643AD6; Thu, 23 Jan 2020 22:25:37 +0900 (JST) Received: from yo-satoh-debian.localdomain (v046114.dynamic.ppp.asahi-net.or.jp [124.155.46.114]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 1A2D7240091; Thu, 23 Jan 2020 22:25:37 +0900 (JST) From: Yoshinori Sato To: qemu-devel@nongnu.org Subject: [PATCH v29 18/22] hw/rx: Honor -accel qtest Date: Thu, 23 Jan 2020 22:25:21 +0900 Message-Id: <20200123132525.80891-19-ysato@users.sourceforge.jp> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200123132525.80891-1-ysato@users.sourceforge.jp> References: <20200123132525.80891-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.13 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: philmd@redhat.com, Richard Henderson , Yoshinori Sato Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-16-ysato@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- We could squash this with the previous patch --- hw/rx/rx62n.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/rx/rx62n.c b/hw/rx/rx62n.c index ac47f2a397..a0986fd15e 100644 --- a/hw/rx/rx62n.c +++ b/hw/rx/rx62n.c @@ -21,12 +21,14 @@ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "qemu/error-report.h" #include "hw/hw.h" #include "hw/rx/rx62n.h" #include "hw/loader.h" #include "hw/sysbus.h" #include "hw/qdev-properties.h" #include "sysemu/sysemu.h" +#include "sysemu/qtest.h" #include "cpu.h" =20 /* @@ -191,8 +193,14 @@ static void rx62n_realize(DeviceState *dev, Error **er= rp) memory_region_init_rom(&s->c_flash, NULL, "codeflash", RX62N_CFLASH_SIZE, errp); memory_region_add_subregion(s->sysmem, RX62N_CFLASH_BASE, &s->c_flash); + if (!s->kernel) { - rom_add_file_fixed(bios_name, RX62N_CFLASH_BASE, 0); + if (bios_name) { + rom_add_file_fixed(bios_name, RX62N_CFLASH_BASE, 0); + } else if (!qtest_enabled()) { + error_report("No bios or kernel specified"); + exit(1); + } } =20 /* Initialize CPU */ --=20 2.20.1