From nobody Mon Feb 9 08:09:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579788945; cv=none; d=zohomail.com; s=zohoarc; b=SJUVhaect9ev6QIJWBq25JcwLOI8S+rXyGO6zqPWMKY8EjblY5LdOnG2xlfrefMRpz+4VJuVzBEsrGkXFDTkKb7N+33ErVNgqhSZ99a/iuSH1tHzAgT9uXLs01iL9oFxzC9QAWDhI31LaUXU5KlI/d4dcWG23ekyXDh2aV1lWw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579788945; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qHRBtI8mqc/+h6vY0sDSH8KnWBJyk6xG64HuaxZqdiY=; b=gQ+b690Ar+EpGZSVG4TjBRvaJ/6TuzYHqWuA1O6cECTCWrFyQM1THaHx30ABDsEFDewYOijUQ8vlPR25GNoBoPYfLLcpxajic0xSE1r823WB9b6X6FdnCS07kXwc+ayC7uAWRT9c6Jl7N4AXtXctObooDdTr6Yfi5YoAuOXd4fU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579788945345708.925661700074; Thu, 23 Jan 2020 06:15:45 -0800 (PST) Received: from localhost ([::1]:57796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iudGo-0005eK-RK for importer@patchew.org; Thu, 23 Jan 2020 09:15:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41372) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iubAS-00042L-UI for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:01:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iubAR-0006KD-9M for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:01:00 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:60587 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iubAR-0006BJ-1w for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:00:59 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-jjnH9IxyP0eYgxfL9pcUZw-1; Thu, 23 Jan 2020 07:00:48 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E6E88010FE for ; Thu, 23 Jan 2020 12:00:47 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id 566A01CB; Thu, 23 Jan 2020 12:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579780850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qHRBtI8mqc/+h6vY0sDSH8KnWBJyk6xG64HuaxZqdiY=; b=aKcyZUVWmcBIUX1IKIH12OYJsmtkqHcbQnozwWHoVBXptZ6Qh1on/Xqf5WPbm3yg+LdhFH XLsWK3B8N0Ms9ePRTkzYsOHtkRH4SpRdjv4DLH7BzMqc7YePATHrvBZf4zLoUxRuh7DRYA k5YAU7fuprpkYQbGVcoK8DgEKWEyj5A= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com Subject: [PULL 081/111] virtiofsd: fix memory leak on lo.source Date: Thu, 23 Jan 2020 11:58:11 +0000 Message-Id: <20200123115841.138849-82-dgilbert@redhat.com> In-Reply-To: <20200123115841.138849-1-dgilbert@redhat.com> References: <20200123115841.138849-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: jjnH9IxyP0eYgxfL9pcUZw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Liu Bo valgrind reported that lo.source is leaked on quiting, but it was defined as (const char*) as it may point to a const string "/". Signed-off-by: Liu Bo Reviewed-by: Misono Tomohiro Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index af050c6d97..056ebe8556 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -115,7 +115,7 @@ struct lo_data { int writeback; int flock; int xattr; - const char *source; + char *source; double timeout; int cache; int timeout_set; @@ -2497,9 +2497,8 @@ int main(int argc, char *argv[]) fuse_log(FUSE_LOG_ERR, "source is not a directory\n"); exit(1); } - } else { - lo.source =3D "/"; + lo.source =3D strdup("/"); } if (!lo.timeout_set) { switch (lo.cache) { @@ -2570,5 +2569,7 @@ err_out1: close(lo.root.fd); } =20 + free(lo.source); + return ret ? 1 : 0; } --=20 2.24.1