From nobody Tue Feb 10 04:14:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579788107; cv=none; d=zohomail.com; s=zohoarc; b=EzS5/TNlZkNBNcpwUAkyJA6cV53Wkv+xaImd5cpi3247nHwUEY/7aUqQOeP6uvpLROLrTJTgNouhYW6EelgKffYIugsPhY1+5Lxtzjt4+V+yhvMUFOqFrmX00tdAncILLG4u0BlEdumA1eTUYQbOgpMK225VcqZRrPTYB8iC6i8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579788107; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TTHm9Jt/ZwkRilrjifGOycxUrgPWy6KWn81baKXTvRA=; b=X/r6N2+t9sM4I85YXzdTGKWCX5yOaSG8WdQxn3WplaY7DSXoGjgldExTsFKOkERND+z/9r4Abe/drLdH35hg8DW6OEpKpZ5E7FcqC9mq7NC6k1G03FCyDgHw1SKJJbsSRhilU51iZQKVCjOi4etiMFGB2S8HYkwSZ3t9LeUmjaE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579788107223793.0591798293843; Thu, 23 Jan 2020 06:01:47 -0800 (PST) Received: from localhost ([::1]:57586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iud3J-0003nl-5Z for importer@patchew.org; Thu, 23 Jan 2020 09:01:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40995) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iub9e-0003AN-9N for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:00:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iub9Z-0005aD-9b for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:00:10 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:39187 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iub9Z-0005a7-6F for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:00:05 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-4I3zU2K4NsaqJMbSkcLeRQ-1; Thu, 23 Jan 2020 07:00:03 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1C878017CC for ; Thu, 23 Jan 2020 12:00:01 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.0]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF66F1CB; Thu, 23 Jan 2020 12:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579780805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TTHm9Jt/ZwkRilrjifGOycxUrgPWy6KWn81baKXTvRA=; b=Jxdq4JuYYoymANkfUSb5i3hsMY7yzBRhrU0CYN+4xygdjQK2js5NoqY3+X8rxZ+Fzf/MbQ gnTx9QDRMN6OJKnjdRqdHeNtWnv7/naspYQQctiZaCbVXkz5uTStd0BRcRUg++oxxWkzaL WjjeL9wn7ihRFJKL01jhD6pgADFrJIg= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com Subject: [PULL 062/111] virtiofsd: Add ID to the log with FUSE_LOG_DEBUG level Date: Thu, 23 Jan 2020 11:57:52 +0000 Message-Id: <20200123115841.138849-63-dgilbert@redhat.com> In-Reply-To: <20200123115841.138849-1-dgilbert@redhat.com> References: <20200123115841.138849-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 4I3zU2K4NsaqJMbSkcLeRQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma virtiofsd has some threads, so we see a lot of logs with debug option. It would be useful for debugging if we can identify the specific thread from the log. Add ID, which is got by gettid(), to the log with FUSE_LOG_DEBUG level so that we can grep the specific thread. The log is like as: ]# ./virtiofsd -d -o vhost_user_socket=3D/tmp/vhostqemu0 -o source=3D/tmp= /share0 -o cache=3Dauto ... [ID: 00000097] unique: 12696, success, outsize: 120 [ID: 00000097] virtio_send_msg: elem 18: with 2 in desc of length 120 [ID: 00000003] fv_queue_thread: Got queue event on Queue 1 [ID: 00000003] fv_queue_thread: Queue 1 gave evalue: 1 available: in: 655= 52 out: 80 [ID: 00000003] fv_queue_thread: Waiting for Queue 1 event [ID: 00000071] fv_queue_worker: elem 33: with 2 out desc of length 80 bad= _in_num=3D0 bad_out_num=3D0 [ID: 00000071] unique: 12694, opcode: READ (15), nodeid: 2, insize: 80, p= id: 2014 [ID: 00000071] lo_read(ino=3D2, size=3D65536, off=3D131072) Signed-off-by: Masayoshi Mizuma Signed-off-by: Dr. David Alan Gilbert added rework as suggested by Daniel P. Berrang=C3=A9 during review Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index ff6910fd73..f08324f000 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include @@ -2268,10 +2269,17 @@ static void setup_nofile_rlimit(void) =20 static void log_func(enum fuse_log_level level, const char *fmt, va_list a= p) { + g_autofree char *localfmt =3D NULL; + if (current_log_level < level) { return; } =20 + if (current_log_level =3D=3D FUSE_LOG_DEBUG) { + localfmt =3D g_strdup_printf("[ID: %08ld] %s", syscall(__NR_gettid= ), fmt); + fmt =3D localfmt; + } + if (use_syslog) { int priority =3D LOG_ERR; switch (level) { --=20 2.24.1