From nobody Tue Feb 10 00:41:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1579766234; cv=none; d=zohomail.com; s=zohoarc; b=mOt5YuJyt60TwSkjywXWyc3jNaUqdC4z0ol0kpXLd/6Y7NVai3aAwo3RPYe/v9pfp9X3Vnq9fgECY5LxpfmIWd+XU8AqSqHB/3kTngndFdbHQlVkc5n9Rs0v9sx8foB08ZVQBt9dTe1fJEWeBWLMloJvt5JW2KNqVPU+yUyf4sI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579766234; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=baVusElI3Onx0/FnFY3BhS7qWJ/0fPBEpIRxgepbEgU=; b=T51sxacq2KkgOiQOrOsnI27EjM5O5PueNg43QADKrC/p9GgkO4hVJqTKYXoI9KKbbZMyBhF4jDlrZv8TZrPHiY77lAlQpZw0VUlpYwB2UE8OM+ziNzBT4BuczeqiesIzagdAe5ZWY35/yStpOMNveXVEvAE0vNb3dc5fSLWxgiM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579766234011133.71779833056564; Wed, 22 Jan 2020 23:57:14 -0800 (PST) Received: from localhost ([::1]:52460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuXMW-000692-Mz for importer@patchew.org; Thu, 23 Jan 2020 02:57:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46175) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuXFd-00061d-R3 for qemu-devel@nongnu.org; Thu, 23 Jan 2020 02:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuXFc-0004j0-UB for qemu-devel@nongnu.org; Thu, 23 Jan 2020 02:50:05 -0500 Received: from mailout03.t-online.de ([194.25.134.81]:50686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuXFc-0004hu-OE for qemu-devel@nongnu.org; Thu, 23 Jan 2020 02:50:04 -0500 Received: from fwd06.aul.t-online.de (fwd06.aul.t-online.de [172.20.26.150]) by mailout03.t-online.de (Postfix) with SMTP id CAC18426D4ED; Thu, 23 Jan 2020 08:50:02 +0100 (CET) Received: from linpower.localnet (bdOpmsZawhWbFhK9XojQt-0+cJTgGNpHSj4-Vdy8o65QU2oaeQz3Suo1r9mdc4wwHq@[46.86.62.122]) by fwd06.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1iuXFU-12fW7M0; Thu, 23 Jan 2020 08:49:56 +0100 Received: by linpower.localnet (Postfix, from userid 1000) id 5CBB8200F75; Thu, 23 Jan 2020 08:49:43 +0100 (CET) From: =?UTF-8?q?Volker=20R=C3=BCmelin?= To: Gerd Hoffmann Subject: [PATCH 6/9] ossaudio: prevent SIGSEGV in oss_enable_out Date: Thu, 23 Jan 2020 08:49:40 +0100 Message-Id: <20200123074943.6699-6-vr_qemu@t-online.de> X-Mailer: git-send-email 2.16.4 In-Reply-To: <1e29e1d3-b59b-fcd6-cdff-a680bcdbffa4@t-online.de> References: <1e29e1d3-b59b-fcd6-cdff-a680bcdbffa4@t-online.de> MIME-Version: 1.0 X-ID: bdOpmsZawhWbFhK9XojQt-0+cJTgGNpHSj4-Vdy8o65QU2oaeQz3Suo1r9mdc4wwHq X-TOI-MSGID: ca8aec17-591c-475c-b00f-b6ac2ae58548 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 194.25.134.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU , =?UTF-8?q?Zolt=C3=A1n=20K=C5=91v=C3=A1g=C3=B3?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" With audiodev parameter out.mixing-engine=3Doff hw->mix_buf is NULL. This patch reverts a small part of dc88e38fa7 "audio: unify input and output mixeng buffer management". To reproduce the problem start qemu with -audiodev oss,id=3Daudio0,try-mmap=3Don,out.mixing-engine=3Doff Signed-off-by: Volker R=C3=BCmelin --- audio/ossaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 4965084a5a..6a3b78b381 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@ -592,7 +592,7 @@ static void oss_enable_out(HWVoiceOut *hw, bool enable) return; } =20 - audio_pcm_info_clear_buf(&hw->info, hw->buf_emul, hw->mix_buf->siz= e); + audio_pcm_info_clear_buf(&hw->info, hw->buf_emul, hw->samples); trig =3D PCM_ENABLE_OUTPUT; if (ioctl(oss->fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) { oss_logerr(errno, --=20 2.16.4