From nobody Fri Oct 10 09:45:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1579660703; cv=none; d=zohomail.com; s=zohoarc; b=gyCLhQZJqCBiCTRoYwWKsMhP7xQ2P5Sq01tT4H2bQuDOWTg7lBevVj6R+1K/NCitVcygztZEWnKxDEC52W7qPNGyuzl3LgYHggzudnv72WKG7f4jKAtZvFLhAKglTFYbnRqcspz0l+85BQxoTA8+lmEfxuYu/UdiuyxgAMp4MEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579660703; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8oXffAFFos84hGLyMp+4FwyG83aEe0q98CSCZqlUHVE=; b=apr2H0RcEZo/btj02rtDmEvjV1z5z+wRpdOBLepxrBZWyMX8ZKaHzkDFijB49sp92BPY5bqDmFMs/3LatsR1w9DI3qIzJVaHUcLQMk/xrQQ6Be9MM9x1CRKRzxarvrRNoa7bNXl5fzp/Cr6ClNE3aL/RM8QPg82+LPErPsis8a0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157966070386433.095203010301475; Tue, 21 Jan 2020 18:38:23 -0800 (PST) Received: from localhost ([::1]:35354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu5uQ-0007C7-Hg for importer@patchew.org; Tue, 21 Jan 2020 21:38:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43995) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu5pg-000159-Ci for qemu-devel@nongnu.org; Tue, 21 Jan 2020 21:33:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iu5pe-0001vy-Q8 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 21:33:28 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:35529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iu5pe-0001vY-KU for qemu-devel@nongnu.org; Tue, 21 Jan 2020 21:33:26 -0500 Received: by mail-pl1-x632.google.com with SMTP id g6so2250743plt.2 for ; Tue, 21 Jan 2020 18:33:26 -0800 (PST) Received: from localhost.localdomain (rrcs-173-198-77-92.west.biz.rr.com. [173.198.77.92]) by smtp.gmail.com with ESMTPSA id t1sm42935209pgq.23.2020.01.21.18.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 18:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8oXffAFFos84hGLyMp+4FwyG83aEe0q98CSCZqlUHVE=; b=t3X6V2wckyvBumDIYVvT4erqIwy4Car3NYAr4cZqgTn/qbF4nUfOtFcc4ZFI5uxe3x 4NmNis6kZnLdhUuRHMoak5vI9k9vc2w1TsJLXdZrl5HWcc4mn3Q7PIgvIHwqoxkgOQfe b5wbgPiX+GtE2M+/JLYDcRJoGLMYcWI2YNX1eDLuPeEsMOGKW3WgX53eJcNmi2oJtuG7 2QX3FbHKzqRIzbUf2sDgxlGmhNseE9GG3OV2I1RohhJ9UxJpIN3A+LBzc4Q3jpjeMFqB c2Qa0wWgVKCxNglV5rPEnh/9sCqN9zkStKyDO6GPnnkO7vfL3Duc9v0RTJmTGvysNWqg 4pCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8oXffAFFos84hGLyMp+4FwyG83aEe0q98CSCZqlUHVE=; b=W8WsOQvKgM8k34aXideMzJ1ZEZKSuRvzbpd/Vy0Oi3J9vnmzKcqOhLVwUSOE1TiLf1 GJmVc4jl/oEF7wfqRr6LxN7f7m2PXiCmFVFOeFEdiOg1zhNd4ByvxF2H+yN1zIwIMamt EIY3327qAgdYhWIjv7CUPtoRD8fpW4jsMZHW5tWBBEYctIT8ZxSNm/jKyZSdy4s9UwjJ vIgB4yG7YfhyFkb5lgtPOGE1gpIFs1LkSVsEYq8gG8VWheWiWizUV2eHIilWiK4CZbsA HeFm9io0YWmaOqus1VZFYzGdBWSAgxqsoBuFIr5MbnhukJRGIvVC8NAvCcazq0O0uRii RjLQ== X-Gm-Message-State: APjAAAXfneKzzPew3Hxhgh6vinG7uS5/qb52ZHhSW830EVK1d3T71lQK YX1cZtQOTKw3vtoVXG7k0y7QDLinFxQ= X-Google-Smtp-Source: APXvYqxSAbx45rmkv7h1p5PJ2Zr5RoorrzrN2u9O5kQ2xUnvuLif7Xra/yd37JelTfOHf68OwGgBHw== X-Received: by 2002:a17:902:a40c:: with SMTP id p12mr8514814plq.292.1579660405277; Tue, 21 Jan 2020 18:33:25 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 08/11] hw/hppa/machine: Correctly check the firmware is in PDC range Date: Tue, 21 Jan 2020 16:32:53 -1000 Message-Id: <20200122023256.27556-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200122023256.27556-1-richard.henderson@linaro.org> References: <20200122023256.27556-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::632 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Helge Deller , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 The firmware has to reside in the PDC range. If the Elf file expects to load it below FIRMWARE_START, it is incorrect, regardless the RAM size. Acked-by: Helge Deller Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200109000525.24744-2-f4bug@amsat.org> Signed-off-by: Richard Henderson --- hw/hppa/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index a35527cfc7..e57530950a 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -171,7 +171,7 @@ static void machine_hppa_init(MachineState *machine) qemu_log_mask(CPU_LOG_PAGE, "Firmware loaded at 0x%08" PRIx64 "-0x%08" PRIx64 ", entry at 0x%08" PRIx64 ".\n", firmware_low, firmware_high, firmware_entry); - if (firmware_low < ram_size || firmware_high >=3D FIRMWARE_END) { + if (firmware_low < FIRMWARE_START || firmware_high >=3D FIRMWARE_END) { error_report("Firmware overlaps with memory or IO space"); exit(1); } --=20 2.20.1