From nobody Fri Oct 10 09:48:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1579660506; cv=none; d=zohomail.com; s=zohoarc; b=Caq/YgzJits+nmFn+TYWVZN4LAIovvm7EnYarhgEFLi+ABRda5Arx6FfaNMZls/+C/beBBmP/8oI6BW6+YdXGp+/R7wiIwreZoh22zQsG+9Ti0DIR1CObKr1DCr275XGyLmKmEt+f3zDAMBdlXtO5scYgi7Zeg4dhIRVlQ9kQxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579660506; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ByWTVem8tb3au/b4x5fdyhlm60dqCY2c6IfxCbm59X0=; b=ARSwtkVmTT/Um+zr9WNpSvTPIWlnfI1KGXa3VP0wigETfmHRXAZABFVRkXObNqRjIdpqt7gYy67Vpin4lKuPBPGAnham4IGAHPGN48P3lrFLz0ayJpcpk3x3DiRK04GJXyYNEqm5xIYceAerBRFHFtinv5w4kuOFjZeS3xPzkyg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157966050637061.8223306557793; Tue, 21 Jan 2020 18:35:06 -0800 (PST) Received: from localhost ([::1]:35278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu5rE-0002R7-Ly for importer@patchew.org; Tue, 21 Jan 2020 21:35:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43939) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu5pM-0000j0-J5 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 21:33:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iu5pL-0001ky-Cy for qemu-devel@nongnu.org; Tue, 21 Jan 2020 21:33:08 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:41073) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iu5pL-0001kZ-7E for qemu-devel@nongnu.org; Tue, 21 Jan 2020 21:33:07 -0500 Received: by mail-pl1-x641.google.com with SMTP id t14so2233814plr.8 for ; Tue, 21 Jan 2020 18:33:07 -0800 (PST) Received: from localhost.localdomain (rrcs-173-198-77-92.west.biz.rr.com. [173.198.77.92]) by smtp.gmail.com with ESMTPSA id t1sm42935209pgq.23.2020.01.21.18.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 18:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ByWTVem8tb3au/b4x5fdyhlm60dqCY2c6IfxCbm59X0=; b=Fn6vxCg+bLTN4Sfv3QjrBYBv8NRoqRp+E6p2z5EBU+J1bSy1mLjTDYQ3c7KuX0c3WQ r/ECWtgqpt7O+gzH1lOKQ0IaT/UxiB41utWIdfywY05RMBWHYSLI+oJ+Uj57oRWpKtbD 1itJuKtWqC7J0dW+4JqPlMTRYX6IVdgmEKUXmaKkcEpvRuK+pgqLXXyLpOOCW6RZq9II mGgkS9uKm1ETnqbXXJnHzAT1wM7McvDGfKyvkVnmFmxG3d7npCxM8+hDfx4nRe5d63pM CZcHnv3hhcWxCp0GOKNALs2BR4LalJ1edIglIjSNdWrB6MCJ2hHSiugV6BZUqFeceaO6 23KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ByWTVem8tb3au/b4x5fdyhlm60dqCY2c6IfxCbm59X0=; b=Dlxc3swSun94nyDU/EXT034DI0RBh+KuhcjR1dvoXd8WLB4T//fvqwFuRzAAimtVop MbR/Z9i3PAta5SsKdy55qBTyXKUpvrUpd7Y0A64EFZEONLRZNjDjQtrNP23nw8+EhwUR dpLNnQ+O/EqEumUnEIbAuxDANGX2fEUV5LDZ+EQUQXnm96hcxohkeqmLjgiGZppa88GU kP4P5YWW1IVgDGoNj5gok2/sHWoM4e2KSschYXxyOr67Ujvf2dzvAm0nxXNGLWH4XD0q gHHZ5wnCm2SfuTum1ckA0VzZsa90UJPIpu72Yc9+xBfKUkSW5QRc5jnoDNx9XnZqS3Ey GXmQ== X-Gm-Message-State: APjAAAV3GE+CJAETkLW6s4LCiyX8i9tI/P0KldIMK6L1akcf4QhKdUzB C8cmw/BgYLvE0bRYnl+/xWOJmBu1/Y0= X-Google-Smtp-Source: APXvYqzjfvnv6Lgefi34CIAyZ7Breluaw0itl8FQTIc06EiuDCHlnxq5GHCABhUn8YdRcN/d1jJHfA== X-Received: by 2002:a17:90a:246c:: with SMTP id h99mr365152pje.134.1579660385923; Tue, 21 Jan 2020 18:33:05 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 03/11] ps2: accept 'Set Key Make and Break' commands Date: Tue, 21 Jan 2020 16:32:48 -1000 Message-Id: <20200122023256.27556-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200122023256.27556-1-richard.henderson@linaro.org> References: <20200122023256.27556-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Sven Schnelle HP-UX sends both the 'Set key make and break (0xfc) and 'Set all key typematic make and break' (0xfa). QEMU response with 'Resend' as it doesn't handle these commands. HP-UX than reports an PS/2 max retransmission exceeded error. Add these commands and just reply with ACK. Signed-off-by: Sven Schnelle Message-Id: <20191220211512.3289-4-svens@stackframe.org> Signed-off-by: Richard Henderson --- hw/input/ps2.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 67f92f6112..0b671b6339 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -49,6 +49,8 @@ #define KBD_CMD_RESET_DISABLE 0xF5 /* reset and disable scanning */ #define KBD_CMD_RESET_ENABLE 0xF6 /* reset and enable scanning */ #define KBD_CMD_RESET 0xFF /* Reset */ +#define KBD_CMD_SET_MAKE_BREAK 0xFC /* Set Make and Break mode */ +#define KBD_CMD_SET_TYPEMATIC 0xFA /* Set Typematic Make and Break mo= de */ =20 /* Keyboard Replies */ #define KBD_REPLY_POR 0xAA /* Power on reset */ @@ -573,6 +575,7 @@ void ps2_write_keyboard(void *opaque, int val) case KBD_CMD_SCANCODE: case KBD_CMD_SET_LEDS: case KBD_CMD_SET_RATE: + case KBD_CMD_SET_MAKE_BREAK: s->common.write_cmd =3D val; ps2_queue(&s->common, KBD_REPLY_ACK); break; @@ -592,11 +595,18 @@ void ps2_write_keyboard(void *opaque, int val) KBD_REPLY_ACK, KBD_REPLY_POR); break; + case KBD_CMD_SET_TYPEMATIC: + ps2_queue(&s->common, KBD_REPLY_ACK); + break; default: ps2_queue(&s->common, KBD_REPLY_RESEND); break; } break; + case KBD_CMD_SET_MAKE_BREAK: + ps2_queue(&s->common, KBD_REPLY_ACK); + s->common.write_cmd =3D -1; + break; case KBD_CMD_SCANCODE: if (val =3D=3D 0) { if (s->common.queue.count <=3D PS2_QUEUE_SIZE - 2) { --=20 2.20.1