From nobody Mon Feb 9 15:30:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579612091; cv=none; d=zohomail.com; s=zohoarc; b=N9Iqh0NloS6atxCVaSixSGYCyT/hrDk888VeNCF1vR66WVWUt8zbFam4wbZ22sNOy1Lnvgw3Tl3oN6UvFPtmrGDcZp32fDRUl4YWM8bJ8tmumGsw+EyNSzZa/EawHXQXn4rBduRf+nYzDPRFJFvkBxjdb+0Hqw95MS8SgEPNVmM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579612091; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y7li2MZz/6GD/atRC2r5V09Pr3cVclJRnNhxTF3shws=; b=RpY34q2nRPcFvFpp9icEdy4sMFfVhiExheR5sj2znCqYM7I1Qq75+76ifCfeMJr1Nc6AJt+ACoTXDo+QmAoW7SnCAvDNZ2osN11Z0G/y67RpFfvJHYoogtf4zQemec7pplFXLSAq7Rin32fX9inBZhzWq8yuIVB2KkrUJNKsYmM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579612091185767.7582043516586; Tue, 21 Jan 2020 05:08:11 -0800 (PST) Received: from localhost ([::1]:53558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ittGL-00077W-JY for importer@patchew.org; Tue, 21 Jan 2020 08:08:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51939) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itseY-0000Wq-GT for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:29:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itseT-0003Qq-TR for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:29:06 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:25349 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itseT-0003QR-NS for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:29:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-eSKWYJ77P0aVIzcV4c3HJA-1; Tue, 21 Jan 2020 07:28:59 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A43CD107ACC7; Tue, 21 Jan 2020 12:28:58 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B24660BE0; Tue, 21 Jan 2020 12:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7li2MZz/6GD/atRC2r5V09Pr3cVclJRnNhxTF3shws=; b=etnFFe259Xm0k4kKvnevqak/sotAaGOZaqu1ryE6B4SLpp1w45GLzF7BslOwnM9LghGDP3 AJh6+HNUgIrWy52pM5RofWnNM+cH9sXeGhCJJedxMN/hircjpU6K8pT8DnwRRQj8vYmuqu 5iEbSrP/XVXKn6PoeqNSYiawqIWWFSs= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 055/109] virtiofsd: set maximum RLIMIT_NOFILE limit Date: Tue, 21 Jan 2020 12:23:39 +0000 Message-Id: <20200121122433.50803-56-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: eSKWYJ77P0aVIzcV4c3HJA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Stefan Hajnoczi virtiofsd can exceed the default open file descriptor limit easily on most systems. Take advantage of the fact that it runs as root to raise the limit. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tools/virtiofsd/passthrough_ll.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index 3f7ec85938..7257a4a512 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -52,6 +52,7 @@ #include #include #include +#include #include #include #include @@ -2267,6 +2268,35 @@ static void setup_sandbox(struct lo_data *lo, struct= fuse_session *se) setup_seccomp(); } =20 +/* Raise the maximum number of open file descriptors */ +static void setup_nofile_rlimit(void) +{ + const rlim_t max_fds =3D 1000000; + struct rlimit rlim; + + if (getrlimit(RLIMIT_NOFILE, &rlim) < 0) { + fuse_log(FUSE_LOG_ERR, "getrlimit(RLIMIT_NOFILE): %m\n"); + exit(1); + } + + if (rlim.rlim_cur >=3D max_fds) { + return; /* nothing to do */ + } + + rlim.rlim_cur =3D max_fds; + rlim.rlim_max =3D max_fds; + + if (setrlimit(RLIMIT_NOFILE, &rlim) < 0) { + /* Ignore SELinux denials */ + if (errno =3D=3D EPERM) { + return; + } + + fuse_log(FUSE_LOG_ERR, "setrlimit(RLIMIT_NOFILE): %m\n"); + exit(1); + } +} + int main(int argc, char *argv[]) { struct fuse_args args =3D FUSE_ARGS_INIT(argc, argv); @@ -2388,6 +2418,8 @@ int main(int argc, char *argv[]) =20 fuse_daemonize(opts.foreground); =20 + setup_nofile_rlimit(); + /* Must be before sandbox since it wants /proc */ setup_capng(); =20 --=20 2.24.1