From nobody Mon Feb 9 02:14:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579611656; cv=none; d=zohomail.com; s=zohoarc; b=NEkyR9cKCzHaHrmLW8vFdKlvG/9vYIlt3PC8S2Y0ANWMHmkX4EzGovAZFOmyfvORCpXezvi0YZzx6LKuSLf4K/D+BUdTO3UHs36uNOldf3ivunXuH1W0Vm2Y/lrzstnl2wwg9fnS84kTIE9ma+ovALZKAzs6NjBTjxUCd5cU4K0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579611656; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6KDT+gwhiRoEvGo/lujlCH15TvZTmo1IECP15uJCMWY=; b=TKyMqS0dLYi0EnhYf5J05k3K7dW1fBPpBzGgxQm3vVNol+7+0m36wDUR1PlpVulYu7nj3XLZY5tx+CSvfOz+pH9N0aZNUhOJVC2Xej3AjW3VbvNGoaGPfHVtHeDCPpD0awsO7CyEClgnmG1qxdIHmwacvEDJvmlWGq+Hj+uCeyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579611656181153.51152413764953; Tue, 21 Jan 2020 05:00:56 -0800 (PST) Received: from localhost ([::1]:53466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itt9K-0000H4-Qq for importer@patchew.org; Tue, 21 Jan 2020 08:00:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51780) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itsds-0008WG-C6 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:28:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itsdp-00039O-CE for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:28:24 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:53947 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itsdp-000399-86 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:28:21 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-V19kImO5NmyDLakqNHRX3w-1; Tue, 21 Jan 2020 07:28:19 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 547A8800A02; Tue, 21 Jan 2020 12:28:18 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 996676106A; Tue, 21 Jan 2020 12:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6KDT+gwhiRoEvGo/lujlCH15TvZTmo1IECP15uJCMWY=; b=F4W8rn7B1mtn9O+PtYg58wlZDH6vMzyn2AqLvOPrCPFb/yBMyiuqoK1WfJzBs55BxDITP+ MTgEA/lV4zI/YhXvV7RjCeq2+EEwVXnQyDux1qLMkLhJo8B4HCzHX2d+7GmH4MUORv4Irn OtEvYctttZseM6mt4BF5BWX/o9ZP8Rc= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 045/109] virtiofsd: prevent ".." escape in lo_do_lookup() Date: Tue, 21 Jan 2020 12:23:29 +0000 Message-Id: <20200121122433.50803-46-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: V19kImO5NmyDLakqNHRX3w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez --- tools/virtiofsd/passthrough_ll.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index 3aa26b4255..6975417949 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -623,12 +623,17 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t pa= rent, const char *name, int res; int saverr; struct lo_data *lo =3D lo_data(req); - struct lo_inode *inode; + struct lo_inode *inode, *dir =3D lo_inode(req, parent); =20 memset(e, 0, sizeof(*e)); e->attr_timeout =3D lo->timeout; e->entry_timeout =3D lo->timeout; =20 + /* Do not allow escaping root directory */ + if (dir =3D=3D &lo->root && strcmp(name, "..") =3D=3D 0) { + name =3D "."; + } + newfd =3D openat(lo_fd(req, parent), name, O_PATH | O_NOFOLLOW); if (newfd =3D=3D -1) { goto out_err; --=20 2.24.1