From nobody Mon Apr 29 01:30:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579548680; cv=none; d=zohomail.com; s=zohoarc; b=aszbj3+4+b7n4Het4Pof4BHz2D0bosC1H2XrI+zw+S9/V3yNTT+X9AvJ9x9dmGpzU/OR5idl+zhMctk6oyywFizFPjPy7EjTSeigWQyOFxnhTjgsbmiL2q6DLv0b410HOS2HO/S6L953cBuejzgtOJBuxh7Qrei2iyPJxQAXa08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579548680; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6A4UCJprBcrmaAr7e4JHGpQ9enSor2yTQ8Q4s4y3sNE=; b=TlrLxmnfaU3wIPn1tWhCHNZ+46792idDIv3t05xnfWVif346GAdvjsZdwF3yj6arr0tYTG5iVH03SGJvRntH8dEqa0ulrPE5QqLowLw254zXo34kxP6C+XZISqhFnhUn6FbgGa1aSEroBgczFQxV+j4/GqatnAfdtIZlEshF3EU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579548680925123.5714387076091; Mon, 20 Jan 2020 11:31:20 -0800 (PST) Received: from localhost ([::1]:43378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itclb-0000CD-By for importer@patchew.org; Mon, 20 Jan 2020 14:31:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36424) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itckU-0007cc-Vv for qemu-devel@nongnu.org; Mon, 20 Jan 2020 14:30:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itckR-00019h-4j for qemu-devel@nongnu.org; Mon, 20 Jan 2020 14:30:10 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:59944 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itckR-00019L-0u for qemu-devel@nongnu.org; Mon, 20 Jan 2020 14:30:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-WT209RaiPbGx4sACZCIZ2Q-1; Mon, 20 Jan 2020 14:30:05 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 749C6800D4C; Mon, 20 Jan 2020 19:30:03 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-38.brq.redhat.com [10.40.205.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C74860BF4; Mon, 20 Jan 2020 19:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579548606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6A4UCJprBcrmaAr7e4JHGpQ9enSor2yTQ8Q4s4y3sNE=; b=X8paO45gOK3ChGtk8yl58gmjfwQouIVwSjNH2NwcBYDuHy3SAM93gzWm9/GKPsxRGLKUPG 8X55bZPoKGT1fIFxFSELFsc5XPnGjyG0PG2iXjFlqnZlSEfhQN6sXBT4jjC2sWIPNetjWp uEnEbW6X1i0+fc5C8stIkuoqaoT3wmo= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] ui/console: Display the 'none' backend in '-display help' Date: Mon, 20 Jan 2020 20:29:47 +0100 Message-Id: <20200120192947.31613-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: WT209RaiPbGx4sACZCIZ2Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit c388f408b5 added the possibility to list the display backends using '-display help'. Since the 'none' backend is is not implemented as a DisplayChangeListenerOps, it is not registered to the dpys[] array with qemu_display_register(), and is not listed in the help output. This might be confusing, as we list it in the man page: -display type Select type of display to use. This option is a replacement for the old style -sdl/-curses/... options. Valid values for type are none Do not display video output. The guest will still see an emulated graphics card, but its output will not be displayed to the QEMU user. This option differs from the -nographic option in that it only affects what is done with video output; -nographic also changes the destination of the serial and parallel port data. Fix by manually listing the special 'none' backend in the help. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Blake --- ui/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/console.c b/ui/console.c index 69339b028b..179901c35e 100644 --- a/ui/console.c +++ b/ui/console.c @@ -2338,6 +2338,7 @@ void qemu_display_help(void) int idx; =20 printf("Available display backend types:\n"); + printf("none\n"); for (idx =3D DISPLAY_TYPE_NONE; idx < DISPLAY_TYPE__MAX; idx++) { if (!dpys[idx]) { ui_module_load_one(DisplayType_str(idx)); --=20 2.21.1