From nobody Thu May 2 18:02:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1579483937; cv=none; d=zohomail.com; s=zohoarc; b=SsmYWMqa+6x1qgEdUjZdTuRzKVVclmuUjIRc41GMflsRLTchJLiW4ZSTJP5iU+K7PT+fT+xizcWQDvwZcGs6p03LRID3bLmnLQtLR/ozeeZf0bzSeaTCs5vcObOGytfPTqNaUocuT7vDQd3s26hYARlt9Ot/U0I8u/5ayART8mg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579483937; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=44Mte8gwODc7iQr+9KVjb8tTrwPq79EqKIJdzRQVT0w=; b=GSuTL/MwET4oEzemifv3N2R/APkiNDp5T45gV7Q4MAEUFneDk3koHBA1Ua5VY+HJWz+fMnFFogd5Hrgcs33IQFycIzkac0RACUP+T8ONZt1D/tk95rhxxm4h0p+3pZCbcQFORjxl5Egxo8P+XGbrATZM3cQaULbWdHuGLdQ7His= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579483937928472.22308138370363; Sun, 19 Jan 2020 17:32:17 -0800 (PST) Received: from localhost ([::1]:57006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itLvM-0004yJ-KI for importer@patchew.org; Sun, 19 Jan 2020 20:32:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42474) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itLu3-0003yD-6c for qemu-devel@nongnu.org; Sun, 19 Jan 2020 20:30:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itLu2-00051C-3E for qemu-devel@nongnu.org; Sun, 19 Jan 2020 20:30:55 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:33402 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itLu1-0004zu-PT for qemu-devel@nongnu.org; Sun, 19 Jan 2020 20:30:54 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D6F079EF755BE1FBF7F3; Mon, 20 Jan 2020 09:30:51 +0800 (CST) Received: from linux-TFkxOR.huawei.com (10.175.104.212) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 20 Jan 2020 09:30:44 +0800 From: Keqian Zhu To: Subject: [PATCH v3 1/2] hw/acpi: Remove extra indent in ACPI GED hotplug cb Date: Mon, 20 Jan 2020 09:27:54 +0800 Message-ID: <20200120012755.44581-2-zhukeqian1@huawei.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20200120012755.44581-1-zhukeqian1@huawei.com> References: <20200120012755.44581-1-zhukeqian1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.104.212] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S . Tsirkin" , Shameer Kolothum , Igor Mammedov , wanghaibin.wang@huawei.com, Keqian Zhu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" There is extra indent in ACPI GED hotplug cb that should be deleted. Reviewed-by: Igor Mammedov Signed-off-by: Keqian Zhu --- hw/acpi/generic_event_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c index 9cee90cc70..55eb29d80a 100644 --- a/hw/acpi/generic_event_device.c +++ b/hw/acpi/generic_event_device.c @@ -175,7 +175,7 @@ static void acpi_ged_device_plug_cb(HotplugHandler *hot= plug_dev, AcpiGedState *s =3D ACPI_GED(hotplug_dev); =20 if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { - acpi_memory_plug_cb(hotplug_dev, &s->memhp_state, dev, errp); + acpi_memory_plug_cb(hotplug_dev, &s->memhp_state, dev, errp); } else { error_setg(errp, "virt: device plug request for unsupported device" " type: %s", object_get_typename(OBJECT(dev))); --=20 2.19.1 From nobody Thu May 2 18:02:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1579484018; cv=none; d=zohomail.com; s=zohoarc; b=Dx3+cAkB7VxNVSLbn3WtsBCyR71D+OEcdamkUAGZaXptHdEiO/f09Ppj111Iw25w9WCC7/fGgyJh7NuJAifdmztZMtE4A9Oqda76YZnspMkjQzxlmHf0AJkvExSWuPzdGiYBI8Llz02R7efipIaNsKBK9VPV1IGbOw3ToZuYphE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579484018; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2HRRv+HkmqQafa8i2CMYGxU48+lLJuGg9DRGaUXDULE=; b=F7gqVe6vqCL6MaW9TsuRMkTrf0DGmpjM4XWzQqaavOdQqfH/5O8O/5f3BMMwQ26/GeqKk4nKyAAfDJK6myf1hV9WS09RdwMU/i8pVxIxp89MnUn0YgdzwLAZCGLNAM56j8zMD6zIuJKNet0mX1ehPkZi/PVnoF7n2xwaR/TJCTc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579484018149923.4435798235792; Sun, 19 Jan 2020 17:33:38 -0800 (PST) Received: from localhost ([::1]:57034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itLwf-000695-3l for importer@patchew.org; Sun, 19 Jan 2020 20:33:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42488) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itLu9-000469-5U for qemu-devel@nongnu.org; Sun, 19 Jan 2020 20:31:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itLu8-00055i-7H for qemu-devel@nongnu.org; Sun, 19 Jan 2020 20:31:01 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2743 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itLu7-00053j-Te for qemu-devel@nongnu.org; Sun, 19 Jan 2020 20:31:00 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id EB206395A4C9961A0A3C; Mon, 20 Jan 2020 09:30:56 +0800 (CST) Received: from linux-TFkxOR.huawei.com (10.175.104.212) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 20 Jan 2020 09:30:49 +0800 From: Keqian Zhu To: Subject: [PATCH v3 2/2] hw/arm: Use helper function to trigger hotplug handler plug Date: Mon, 20 Jan 2020 09:27:55 +0800 Message-ID: <20200120012755.44581-3-zhukeqian1@huawei.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20200120012755.44581-1-zhukeqian1@huawei.com> References: <20200120012755.44581-1-zhukeqian1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.104.212] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S . Tsirkin" , Shameer Kolothum , Igor Mammedov , wanghaibin.wang@huawei.com, Keqian Zhu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We can use existing helper function to trigger hotplug handler plug, which makes code clearer. Reviewed-by: Igor Mammedov Signed-off-by: Keqian Zhu --- hw/arm/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 39ab5f47e0..656b0081c2 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1934,7 +1934,6 @@ static void virt_memory_pre_plug(HotplugHandler *hotp= lug_dev, DeviceState *dev, static void virt_memory_plug(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { - HotplugHandlerClass *hhc; VirtMachineState *vms =3D VIRT_MACHINE(hotplug_dev); Error *local_err =3D NULL; =20 @@ -1943,8 +1942,9 @@ static void virt_memory_plug(HotplugHandler *hotplug_= dev, goto out; } =20 - hhc =3D HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); - hhc->plug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &error_abort); + hotplug_handler_plug(HOTPLUG_HANDLER(vms->acpi_dev), + dev, &error_abort); + out: error_propagate(errp, local_err); } --=20 2.19.1