From nobody Sun May 5 07:25:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579364705; cv=none; d=zohomail.com; s=zohoarc; b=KkamZpGp75EWstjrHMVLa1xeuYUVDQRbJsUwFhL81887HGZYCO/5Uf921Kr2dpjKp9DurZOwQNlOOODomOWnkPQt+c4RZ4y1pQ1haa6w9uZaKxDxzn5CI6UP4yKBmXE/+lh96oTFKUpCLhzdpR95ipIDEvOVC9TQWh9UYZrQpwg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579364705; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=LA0ayxYJMroSpQnrDtk2P6kxf1ntvP9Q/rvrsBUNc0s=; b=JQjKtR1b9gYAMcfYgf2u4Y2noJpc7ZF341dJdE4Q/B3XNFDuWhjPgXHSlxYL/60/pzS3WNcbLgc0EScF6XThhhQZZLLc1iiOmYv/RMVuVN/HjyAM68Ae5PSOKn7WN6+Yna+KEqi6PrB2QNSG31j0wjZWTRaMRZrw0qCHME8DvZo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579364705285585.5358641226178; Sat, 18 Jan 2020 08:25:05 -0800 (PST) Received: from localhost ([::1]:42396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isquG-0006QE-9z for importer@patchew.org; Sat, 18 Jan 2020 11:25:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34308) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isqtH-0005W4-8A for qemu-devel@nongnu.org; Sat, 18 Jan 2020 11:24:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isqtE-0007Eu-Sh for qemu-devel@nongnu.org; Sat, 18 Jan 2020 11:24:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30591 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1isqtE-0007E9-92 for qemu-devel@nongnu.org; Sat, 18 Jan 2020 11:24:00 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-IIv0VbIsMEGhkOE694Ba3g-1; Sat, 18 Jan 2020 11:23:58 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B500800D41 for ; Sat, 18 Jan 2020 16:23:57 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-59.brq.redhat.com [10.40.204.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8201160BFB; Sat, 18 Jan 2020 16:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579364639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LA0ayxYJMroSpQnrDtk2P6kxf1ntvP9Q/rvrsBUNc0s=; b=MyVQZTTWQGccEXiRnsYrXNHl/qxqCHKg93DuK9D1HWwHcIfAtwmSSvIB9mFzCRMHeMM0vf dewTuXaUDnZqAnzYA14j20I8CgCASpH4vaiUIgECqROvNUmR7bhwCKHVzQGXwRgtftmzwC zgc9QjjOsuC/tFq4jDhoo+sn6+6Rr6o= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] qom/object: Display more helpful message when an interface is missing Date: Sat, 18 Jan 2020 17:23:48 +0100 Message-Id: <20200118162348.17823-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: IIv0VbIsMEGhkOE694Ba3g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Cornelia Huck , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When adding new devices implementing QOM interfaces, we might forgot to add the Kconfig dependency that pulls the required objects in when building. Since QOM dependencies are resolved at runtime, we don't get any link-time failures, and QEMU aborts while starting: $ qemu ... Segmentation fault (core dumped) (gdb) bt #0 0x00007ff6e96b1e35 in raise () from /lib64/libc.so.6 #1 0x00007ff6e969c895 in abort () from /lib64/libc.so.6 #2 0x00005572bc5051cf in type_initialize (ti=3D0x5572be6f1200) at qom/ob= ject.c:323 #3 0x00005572bc505074 in type_initialize (ti=3D0x5572be6f1800) at qom/ob= ject.c:301 #4 0x00005572bc505074 in type_initialize (ti=3D0x5572be6e48e0) at qom/ob= ject.c:301 #5 0x00005572bc506939 in object_class_by_name (typename=3D0x5572bc56109a= ) at qom/object.c:959 #6 0x00005572bc503dd5 in cpu_class_by_name (typename=3D0x5572bc56109a, c= pu_model=3D0x5572be6d9930) at hw/core/cpu.c:286 Since the caller has access to the qdev parent/interface names, we can simply display them to avoid starting a debugger: $ qemu ... qemu: missing interface 'fancy-if' for object 'fancy-dev' Aborted (core dumped) This commit is similar to e02bdf1cecd2 ("Display more helpful message when an object type is missing"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Cornelia Huck --- Cc: Cornelia Huck Cc: Stefano Garzarella Cc: Daniel P. Berrang=C3=A9 --- qom/object.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qom/object.c b/qom/object.c index 0d971ca897..36123fb330 100644 --- a/qom/object.c +++ b/qom/object.c @@ -317,6 +317,11 @@ static void type_initialize(TypeImpl *ti) =20 for (i =3D 0; i < ti->num_interfaces; i++) { TypeImpl *t =3D type_get_by_name(ti->interfaces[i].typename); + if (!t) { + error_report("missing interface '%s' for object '%s'", + ti->interfaces[i].typename, parent->name); + abort(); + } for (e =3D ti->class->interfaces; e; e =3D e->next) { TypeImpl *target_type =3D OBJECT_CLASS(e->data)->type; =20 --=20 2.21.1