From nobody Wed May 8 01:26:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579259478; cv=none; d=zohomail.com; s=zohoarc; b=REEaJMm8+0dk0CG/Gv5XmIjzk8HsDgmakPvuLCFkxsxCYALWxymAL6yXgeyhhurPBGvyY0ibFVNr5NLNP5U/k5meABD6wl9kMNNkabvITdsJP6TEXzBJkwvFVintu5ozanbVP6BB5SUfnAOs6k1Y43WbfrNvbrbJkOZLOwAh+zA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579259478; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=8+TiDJI/noUOtbv6SI6j0jYg5aYPv0QyWMrO1+E9TRA=; b=ndbEF5odtkfUOfDjzLvibZnvcVDchnoMlfKsGBJYFilO4QbueeF5ap/sqfRufCg6RorsXrJbQhcd3rvYrh4XaQ9Pgn0I6TW7kOsp1nyLIXcK4qRzhkDrgen/yeQ1X//KoHx7Qxok6KwjRxk9jxQ3ppqgFpsjXks9HWG8Pzc9KM4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15792594783571014.0355310991692; Fri, 17 Jan 2020 03:11:18 -0800 (PST) Received: from localhost ([::1]:55518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPX3-0002L1-48 for importer@patchew.org; Fri, 17 Jan 2020 06:11:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60290) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPU7-0006it-PG for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isPU4-0003kI-8i for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:15 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47257 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1isPU4-0003k6-5Q for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:12 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-a_7J1ztGO6m7NqF5nQj-0Q-1; Fri, 17 Jan 2020 06:08:05 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39C2A190B2A0; Fri, 17 Jan 2020 11:08:04 +0000 (UTC) Received: from thuth.com (ovpn-116-212.ams2.redhat.com [10.36.116.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0174460C87; Fri, 17 Jan 2020 11:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579259291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8+TiDJI/noUOtbv6SI6j0jYg5aYPv0QyWMrO1+E9TRA=; b=c+BaenL6lCrHL0rpYACEcBmlV6k3hfNoKPn2M/YajSpawrWe4t/uH/z2FMZmOLU5Z3aBCb aMZjzti44/HcnM1sDMrUXg5Cz1sSrbKrY59gT76utPL92pb0CUP+Azif7Mcodmq1pR0zPS ZuF7sfgYd2jJdn6oILJpkHqFDoyTK94= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 1/4] tests: acpi: update path in rebuild-expected-aml Date: Fri, 17 Jan 2020 12:07:55 +0100 Message-Id: <20200117110758.1995-2-thuth@redhat.com> In-Reply-To: <20200117110758.1995-1-thuth@redhat.com> References: <20200117110758.1995-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: a_7J1ztGO6m7NqF5nQj-0Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Shameer Kolothum Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Shameer Kolothum Since commit 1e8a1fae7464("test: Move qtests to a separate directory") qtests are now placed in a separate folder and this breaks the script used to rebuild the expected ACPI tables for bios-tables-test. Update the script with correct path. Fixes: 1e8a1fae7464("test: Move qtests to a separate directory") Signed-off-by: Shameer Kolothum Reviewed-by: Thomas Huth Message-Id: <20200114165138.15716-1-shameerali.kolothum.thodi@huawei.com> Signed-off-by: Thomas Huth --- tests/data/acpi/rebuild-expected-aml.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebu= ild-expected-aml.sh index f89d4624bc..d44e511533 100755 --- a/tests/data/acpi/rebuild-expected-aml.sh +++ b/tests/data/acpi/rebuild-expected-aml.sh @@ -14,7 +14,7 @@ =20 qemu_bins=3D"x86_64-softmmu/qemu-system-x86_64 aarch64-softmmu/qemu-system= -aarch64" =20 -if [ ! -e "tests/bios-tables-test" ]; then +if [ ! -e "tests/qtest/bios-tables-test" ]; then echo "Test: bios-tables-test is required! Run make check before this s= cript." echo "Run this script from the build directory." exit 1; @@ -26,11 +26,11 @@ for qemu in $qemu_bins; do echo "Also, run this script from the build directory." exit 1; fi - TEST_ACPI_REBUILD_AML=3Dy QTEST_QEMU_BINARY=3D$qemu tests/bios-tables-= test + TEST_ACPI_REBUILD_AML=3Dy QTEST_QEMU_BINARY=3D$qemu tests/qtest/bios-t= ables-test done =20 eval `grep SRC_PATH=3D config-host.mak` =20 -echo '/* List of comma-separated changed AML files to ignore */' > ${SRC_P= ATH}/tests/bios-tables-test-allowed-diff.h +echo '/* List of comma-separated changed AML files to ignore */' > ${SRC_P= ATH}/tests/qtest/bios-tables-test-allowed-diff.h =20 echo "The files were rebuilt and can be added to git." --=20 2.18.1 From nobody Wed May 8 01:26:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579259420; cv=none; d=zohomail.com; s=zohoarc; b=lQgfJLXsl2lR+x1ZfPW/lyaSgoWLmYdi3gPoWRuhgzsF+/UraIjmggCzM+a0QBy4OFUHkGxTXi9Mt7QqAuMuaQo0EPi4uuIxI4F/MF2eJGileYD2U1oMGTbsvELEa/2YmOQlzBYAG5aYrtuVSM8KzJhFtg64+nNEOntqa+hmooU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579259420; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=3bsPuM8/iJZXQ1Q2h7WSCBhEQYyH0PFkTBWRsbJDxG0=; b=LOr5hhhnOIpE1StqVuYRU6RAC1tZc/XuLqaWTiP1uahZVEsnNCCQybfegaXXyDl/Qk7AYpcHwSs6LCkDcQbRRBVeuFkft2Lh9zy8OwKIRQ309BnEfiizJ6lbiEZBTWY6+P+8IXlHwdOqMWDjLdmTzANc3FZzYcrfbA0FbrO6laU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579259420532253.66480170378463; Fri, 17 Jan 2020 03:10:20 -0800 (PST) Received: from localhost ([::1]:55500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPW7-00010t-4p for importer@patchew.org; Fri, 17 Jan 2020 06:10:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60296) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPU8-0006kY-UZ for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isPU5-0003l9-CO for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:16 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:34076 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1isPU5-0003ks-9F for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:13 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-9Vcaa9zdMnaxt1IqZhhJYg-1; Fri, 17 Jan 2020 06:08:09 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75F17107ACC9; Fri, 17 Jan 2020 11:08:08 +0000 (UTC) Received: from thuth.com (ovpn-116-212.ams2.redhat.com [10.36.116.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id B13E460C87; Fri, 17 Jan 2020 11:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579259292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bsPuM8/iJZXQ1Q2h7WSCBhEQYyH0PFkTBWRsbJDxG0=; b=KDcA554ZW//ydJGfAGJLrApYQmp5bcF1I8OCz1bbAEkd/j/c8uAz7OmgcjVAZFDX+fn1Yk xD489tAyTI0MWk8PQmBiyquPe0GjBRpPxVp4MRG81Ao2XQ9X6a9MpGnDPvP/l2fKo8NGn1 7i6+GQicDH4cmw9SbwvkqOGIkMRp8kI= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 2/4] migration-test: ppc64: fix FORTH test program Date: Fri, 17 Jan 2020 12:07:56 +0100 Message-Id: <20200117110758.1995-3-thuth@redhat.com> In-Reply-To: <20200117110758.1995-1-thuth@redhat.com> References: <20200117110758.1995-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 9Vcaa9zdMnaxt1IqZhhJYg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , wei@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier Commit e51e711b1bef has moved the initialization of start_address and end_address after the definition of the command line argument, where the nvramrc is initialized, and thus the loop is between 0 and 0 rather than 1 MiB and 100 MiB. It doesn't affect the result of the test if all the tests are run in sequence because the two first tests don't run the loop, so the values are correctly initialized when we actually need them. But it hangs when we ask to run only one test, for instance: QTEST_QEMU_BINARY=3Dppc64-softmmu/qemu-system-ppc64 \ tests/migration-test -m=3Dquick -p /ppc64/migration/validate_uuid_error Fixes: e51e711b1bef ("tests/migration: Add migration-test header file") Cc: wei@redhat.com Signed-off-by: Laurent Vivier Message-Id: <20200107163437.52139-1-lvivier@redhat.com> Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Acked-by: David Gibson Signed-off-by: Thomas Huth --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 53afec4395..341d190922 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -480,14 +480,14 @@ static int test_migrate_start(QTestState **from, QTes= tState **to, } else if (strcmp(arch, "ppc64") =3D=3D 0) { machine_opts =3D "vsmt=3D8"; memory_size =3D "256M"; + start_address =3D PPC_TEST_MEM_START; + end_address =3D PPC_TEST_MEM_END; arch_source =3D g_strdup_printf("-nodefaults " "-prom-env 'use-nvramrc?=3Dtrue' -pr= om-env " "'nvramrc=3Dhex .\" _\" begin %x %x " "do i c@ 1 + i c! 1000 +loop .\" B\"= 0 " "until'", end_address, start_address= ); arch_target =3D g_strdup(""); - start_address =3D PPC_TEST_MEM_START; - end_address =3D PPC_TEST_MEM_END; } else if (strcmp(arch, "aarch64") =3D=3D 0) { init_bootfile(bootpath, aarch64_kernel, sizeof(aarch64_kernel)); machine_opts =3D "virt,gic-version=3Dmax"; --=20 2.18.1 From nobody Wed May 8 01:26:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579259378; cv=none; d=zohomail.com; s=zohoarc; b=a7QCGuD78RD5Nzypfh7yUNY4amBI8LwFxVA7fnDaVCn0ZDEE/jPCq6HtliFSpEJFRwt38FXmvDO2bX5OCDQWSj9mI65+e96NHrSCxFl1dW2Vc0z9V34AnK2AwaPkw+oIb3qTIFTzgwNH6KM6EWBhZI6Ty63dFnpicD9jNR5RoUI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579259378; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RJ0XGVHAE9NIFI5dmtEf0ZRJjpIbSKgQaFzPzi/qAVE=; b=VbUeTZaDDXg+ZWyiToCZZCNPz8/wzgvGyh8yfBVWeiQS4WPfxrc+LA+m9BRNRiw6qLVlFxzvDRTdwCIbOo54OvUgOgCrnu0t0X5xU7y1ooDv540f1LakGf03duJre98VbDFrkuBo1GJnt5//UnCflHG31zDUXDpXLrgoTRLqF7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579259378930416.1480540601268; Fri, 17 Jan 2020 03:09:38 -0800 (PST) Received: from localhost ([::1]:55482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPVQ-0008KL-P5 for importer@patchew.org; Fri, 17 Jan 2020 06:09:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60319) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPUD-0006sk-Ru for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isPUA-0003nY-9v for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:21 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:27910) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1isPUA-0003nJ-6I for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:18 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-0XuAcesuOJObVNPYJ4c6kA-1; Fri, 17 Jan 2020 06:08:13 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E90B5107ACC4; Fri, 17 Jan 2020 11:08:11 +0000 (UTC) Received: from thuth.com (ovpn-116-212.ams2.redhat.com [10.36.116.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id D337F60F82; Fri, 17 Jan 2020 11:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579259297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RJ0XGVHAE9NIFI5dmtEf0ZRJjpIbSKgQaFzPzi/qAVE=; b=V9nENboF8HgCsUadj7en5LDR8HnZehjQVJwpehICtJm0HUVB3XoPsi1yV9ACXbH1UEx+nd S7HGSYA722tJgBhSKPMdOLE/c9oI4VlLb0g0l1QOBoM4+vvEhJaM7N+XPn7+9oewV/tbsF 5b3n7ul0ljCCqiKvBiGxjaShUgqLDSs= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 3/4] tests/qtest/vhost-user-test: Fix memory leaks Date: Fri, 17 Jan 2020 12:07:57 +0100 Message-Id: <20200117110758.1995-4-thuth@redhat.com> In-Reply-To: <20200117110758.1995-1-thuth@redhat.com> References: <20200117110758.1995-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 0XuAcesuOJObVNPYJ4c6kA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Do not allocate resources in case we return early, and make sure to free dest_cmdline at the end. Reported-by: Euler Robot Reported-by: Pan Nengyuan Message-Id: <20200116140736.9498-1-thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index 2324b964ad..9ee0f1e4fd 100644 --- a/tests/qtest/vhost-user-test.c +++ b/tests/qtest/vhost-user-test.c @@ -707,9 +707,9 @@ static void test_read_guest_mem(void *obj, void *arg, Q= GuestAllocator *alloc) static void test_migrate(void *obj, void *arg, QGuestAllocator *alloc) { TestServer *s =3D arg; - TestServer *dest =3D test_server_new("dest"); - GString *dest_cmdline =3D g_string_new(qos_get_current_command_line()); - char *uri =3D g_strdup_printf("%s%s", "unix:", dest->mig_path); + TestServer *dest; + GString *dest_cmdline; + char *uri; QTestState *to; GSource *source; QDict *rsp; @@ -720,6 +720,10 @@ static void test_migrate(void *obj, void *arg, QGuestA= llocator *alloc) return; } =20 + dest =3D test_server_new("dest"); + dest_cmdline =3D g_string_new(qos_get_current_command_line()); + uri =3D g_strdup_printf("%s%s", "unix:", dest->mig_path); + size =3D get_log_size(s); g_assert_cmpint(size, =3D=3D, (256 * 1024 * 1024) / (VHOST_LOG_PAGE * = 8)); =20 @@ -778,6 +782,7 @@ static void test_migrate(void *obj, void *arg, QGuestAl= locator *alloc) qtest_quit(to); test_server_free(dest); g_free(uri); + g_string_free(dest_cmdline, true); } =20 static void wait_for_rings_started(TestServer *s, size_t count) --=20 2.18.1 From nobody Wed May 8 01:26:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1579259544; cv=none; d=zohomail.com; s=zohoarc; b=SENOcVYLVw/27QewpwFpU32Xv40GMRTSSsA/t7hcvETIiEIlPDSTL42CkZcwdfD5oZeXturMcgEdNH9PqCOT7+Xt68dR9q2PFLCovSvdJYwYPB1BS963L5yqINK8VuENiLwSJHM4wPutnigUto0ELR1TUJi6+91J8CfKiwzPNsU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579259544; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=oMTMGpxtSHxsDoSc2IO75R119iBtH87I1K69gvCCnzw=; b=CYg9FQMPm+g7HdPlcTSnhid7LgK8+ontYLf+bohVRKmx2XhocTq2tBcgujhCr9fjOZgBhYgDSPKnNkXM2APrbcMvfnV6JwXWYvOF78ApWxwXBESSTL6kpHHsdSNlrPjFuypzYG70DkPtNtp+563C71mVcpWVxAFXz7SaGz47qXA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1579259544795483.0882585782009; Fri, 17 Jan 2020 03:12:24 -0800 (PST) Received: from localhost ([::1]:55540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPY7-0003sU-Gu for importer@patchew.org; Fri, 17 Jan 2020 06:12:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60325) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isPUG-0006wr-AE for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isPUC-0003oj-EV for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:24 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:21405 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1isPUC-0003oV-B9 for qemu-devel@nongnu.org; Fri, 17 Jan 2020 06:08:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-BEsFnOJxPm-coQyk_jcmxA-1; Fri, 17 Jan 2020 06:08:14 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42C05190B2A0; Fri, 17 Jan 2020 11:08:13 +0000 (UTC) Received: from thuth.com (ovpn-116-212.ams2.redhat.com [10.36.116.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4523E60C87; Fri, 17 Jan 2020 11:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579259299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMTMGpxtSHxsDoSc2IO75R119iBtH87I1K69gvCCnzw=; b=K3UInWbZY2/wnn3L/XWFwAdCEuMTA1CJnuzzYbKg00Cy+gmCD2ffqYxrCbVlyYKBklx2eK 1ot3mStzGyEj00nH7lK0DnnznbL5bvzQjBDO0I6LUJq5ENypDfrrwqqX2g+pG3+Uyfqu1a 6Sx7R2n1sMG855BO0qc4JEFUFJS8LqE= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 4/4] gitlab-ci.yml: Run tcg test with tci Date: Fri, 17 Jan 2020 12:07:58 +0100 Message-Id: <20200117110758.1995-5-thuth@redhat.com> In-Reply-To: <20200117110758.1995-1-thuth@redhat.com> References: <20200117110758.1995-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: BEsFnOJxPm-coQyk_jcmxA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since commit 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation for INDEX_op_ld16u_i64") has been included now, we can also run the TCG tests with tci, so let's enable them in our Gitlab CI now. Message-Id: <20191127155105.3784-1-thuth@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index dce8f2d3f5..d9a90f795d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -87,6 +87,7 @@ build-tci: - ../configure --enable-tcg-interpreter --target-list=3D"$(for tg in $TARGETS; do echo -n ${tg}'-softmmu '; = done)" - make -j2 + - make run-tcg-tests-x86_64-softmmu - make tests/qtest/boot-serial-test tests/qtest/cdrom-test tests/qtest/px= e-test - for tg in $TARGETS ; do export QTEST_QEMU_BINARY=3D"${tg}-softmmu/qemu-system-${tg}" ; --=20 2.18.1