[PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)

Richard Henderson posted 4 patches 4 years, 2 months ago
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200116230809.19078-1-richard.henderson@linaro.org
Maintainers: Peter Maydell <peter.maydell@linaro.org>
target/arm/pauth_helper.c                 |  4 +--
tests/tcg/aarch64/pauth-1.c               |  2 --
tests/tcg/aarch64/pauth-2.c               |  2 --
tests/tcg/aarch64/pauth-4.c               | 25 ++++++++++++++
tests/tcg/aarch64/system/pauth-3.c        | 40 +++++++++++++++++++++++
tests/tcg/aarch64/Makefile.softmmu-target |  5 ++-
tests/tcg/aarch64/Makefile.target         |  3 +-
7 files changed, 73 insertions(+), 8 deletions(-)
create mode 100644 tests/tcg/aarch64/pauth-4.c
create mode 100644 tests/tcg/aarch64/system/pauth-3.c
[PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)
Posted by Richard Henderson 4 years, 2 months ago
Thanks to Vincent and Adrien for both reporting the bug and
providing the solution.  I've converted their manual testing
into executable tests.


r~


Richard Henderson (3):
  tests/tcg/aarch64: Fix compilation parameters for pauth-%
  tests/tcg/aarch64: Add pauth-3
  tests/tcg/aarch64: Add pauth-4

Vincent Dehors (1):
  target/arm: Fix PAuth sbox functions

 target/arm/pauth_helper.c                 |  4 +--
 tests/tcg/aarch64/pauth-1.c               |  2 --
 tests/tcg/aarch64/pauth-2.c               |  2 --
 tests/tcg/aarch64/pauth-4.c               | 25 ++++++++++++++
 tests/tcg/aarch64/system/pauth-3.c        | 40 +++++++++++++++++++++++
 tests/tcg/aarch64/Makefile.softmmu-target |  5 ++-
 tests/tcg/aarch64/Makefile.target         |  3 +-
 7 files changed, 73 insertions(+), 8 deletions(-)
 create mode 100644 tests/tcg/aarch64/pauth-4.c
 create mode 100644 tests/tcg/aarch64/system/pauth-3.c

-- 
2.20.1


Re: [PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)
Posted by no-reply@patchew.org 4 years, 2 months ago
Patchew URL: https://patchew.org/QEMU/20200116230809.19078-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200116230809.19078-1-richard.henderson@linaro.org
Type: series
Subject: [PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200117111147.5006-1-cohuck@redhat.com -> patchew/20200117111147.5006-1-cohuck@redhat.com
Switched to a new branch 'test'
88edbfe tests/tcg/aarch64: Add pauth-4
f826e15 tests/tcg/aarch64: Add pauth-3
6c82a5a tests/tcg/aarch64: Fix compilation parameters for pauth-%
d01fc4a target/arm: Fix PAuth sbox functions

=== OUTPUT BEGIN ===
1/4 Checking commit d01fc4adb51f (target/arm: Fix PAuth sbox functions)
2/4 Checking commit 6c82a5aa6b0f (tests/tcg/aarch64: Fix compilation parameters for pauth-%)
3/4 Checking commit f826e1549b92 (tests/tcg/aarch64: Add pauth-3)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 48 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 88edbfe8c3a8 (tests/tcg/aarch64: Add pauth-4)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

ERROR: code indent should never use tabs
#40: FILE: tests/tcg/aarch64/pauth-4.c:9:
+      "pacia %0, sp\n\t"^I/* sigill if pauth not supported */$

ERROR: code indent should never use tabs
#41: FILE: tests/tcg/aarch64/pauth-4.c:10:
+      "eor %0, %0, #4\n\t"^I/* corrupt single bit */$

ERROR: code indent should never use tabs
#43: FILE: tests/tcg/aarch64/pauth-4.c:12:
+      "autia %1, sp\n\t"^I/* validate corrupted pointer */$

ERROR: code indent should never use tabs
#44: FILE: tests/tcg/aarch64/pauth-4.c:13:
+      "xpaci %0\n\t"^I^I/* strip pac from corrupted pointer */$

total: 4 errors, 1 warnings, 33 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200116230809.19078-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)
Posted by Peter Maydell 4 years, 2 months ago
On Thu, 16 Jan 2020 at 23:08, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Thanks to Vincent and Adrien for both reporting the bug and
> providing the solution.  I've converted their manual testing
> into executable tests.



Applied to target-arm.next, thanks (with the commit message
for patch 2 tweaked, and the hard-coded tabs in patch 4
changed to spaces).

-- PMM