From nobody Wed May 8 11:42:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578995757; cv=none; d=zohomail.com; s=zohoarc; b=Ew7MlaVopmGQdhk0p32SDD98V8eABmQzH8eKpBqDeZ794nc7gfthCgeAHmq4hqs1qXpG274vhvEwoYFjdu5KcQG/7yK/pzhlkQfyU+N5ETOmeDHldrw+89ircJ3UQgMsIg9I/SUzO3hpZe4C6spzVLfW+psw6NdZkUPQ+Q8rcJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578995757; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rEJoT/BfPbM50fXaMpmaNyYaAPnMVUV+p3KnCz1+I1A=; b=iYGe3rryu/fc9OC7dvvl+WsRrHZqYLN6poHFGEXfPXOlqQ1Va2LSQ0jKeF/y926VA9XLsS1nBuwxGWt9TwbhMjVHg5NQj5+NNzrMg4vYLjGmZ1xr9Ij1YS8/Phk6lDNcysnwUnW9h/AZ4JzL+IgdDcHoYl/3XjjGLbS0qI2q7UQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578995757854322.0323428217621; Tue, 14 Jan 2020 01:55:57 -0800 (PST) Received: from localhost ([::1]:35632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irIvU-0001qb-Kv for importer@patchew.org; Tue, 14 Jan 2020 04:55:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58313) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irIW1-0000Yl-HT for qemu-devel@nongnu.org; Tue, 14 Jan 2020 04:29:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irIW0-0006zb-8Y for qemu-devel@nongnu.org; Tue, 14 Jan 2020 04:29:37 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:52197 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irIW0-0006zM-4l for qemu-devel@nongnu.org; Tue, 14 Jan 2020 04:29:36 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-tF_6ZVXuMLSSIhMk5KsYUQ-1; Tue, 14 Jan 2020 04:29:29 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB100800D4C; Tue, 14 Jan 2020 09:29:28 +0000 (UTC) Received: from localhost (unknown [10.36.118.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 249595C1BB; Tue, 14 Jan 2020 09:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578994175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rEJoT/BfPbM50fXaMpmaNyYaAPnMVUV+p3KnCz1+I1A=; b=Xkw45MxVHJ2sDJqAR2LR6QsO3n3mxbpmVr/kviHYEMfn7SwvrmT0oSFZ0AXXeri8zpkp2h cbIK4mvFhMM95vuUclDAETgdiUUhQluB8O7+BGa2JgYi512MIRj44btimxprTFr2eTtKg1 7RltsG4Wo67OvpW6zH9nkp3F5KfSP/Q= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 1/1] trace: update qemu-trace-stap to Python 3 Date: Tue, 14 Jan 2020 09:29:18 +0000 Message-Id: <20200114092918.117399-2-stefanha@redhat.com> In-Reply-To: <20200114092918.117399-1-stefanha@redhat.com> References: <20200114092918.117399-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: tF_6ZVXuMLSSIhMk5KsYUQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" qemu-trace-stap does not support Python 3 yet: $ scripts/qemu-trace-stap list path/to/qemu-system-x86_64 Traceback (most recent call last): File "scripts/qemu-trace-stap", line 175, in main() File "scripts/qemu-trace-stap", line 171, in main args.func(args) File "scripts/qemu-trace-stap", line 118, in cmd_list print_probes(args.verbose, "*") File "scripts/qemu-trace-stap", line 114, in print_probes if line.startswith(prefix): TypeError: startswith first arg must be bytes or a tuple of bytes, not str Now that QEMU requires Python 3.5 or later we can switch to pure Python 3. Use Popen()'s universal_newlines=3DTrue argument to treat stdout as text instead of binary. Fixes: 62dd1048c0bd ("trace: add ability to do simple printf logging via sy= stemtap") Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1787395 Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 Message-id: 20200107112438.383958-1-stefanha@redhat.com Message-Id: <20200107112438.383958-1-stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi --- scripts/qemu-trace-stap | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qemu-trace-stap b/scripts/qemu-trace-stap index 91d1051cdc..90527eb974 100755 --- a/scripts/qemu-trace-stap +++ b/scripts/qemu-trace-stap @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python3 # -*- python -*- # # Copyright (C) 2019 Red Hat, Inc @@ -18,8 +18,6 @@ # You should have received a copy of the GNU General Public License # along with this program; if not, see . =20 -from __future__ import print_function - import argparse import copy import os.path @@ -104,7 +102,9 @@ def cmd_list(args): if verbose: print("Listing probes with name '%s'" % script) proc =3D subprocess.Popen(["stap", "-l", script], - stdout=3Dsubprocess.PIPE, env=3Dtapset_env= (tapsets)) + stdout=3Dsubprocess.PIPE, + universal_newlines=3DTrue, + env=3Dtapset_env(tapsets)) out, err =3D proc.communicate() if proc.returncode !=3D 0: print("No probes found, are the tapsets installed in %s" % tap= set_dir(args.binary)) --=20 2.24.1