From nobody Wed Apr 24 04:09:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1578971109; cv=none; d=zohomail.com; s=zohoarc; b=cUMr1m7TZBIawIHLsyoMuuZ1TkqMOqOFGMgmTLv4t+vmcYpgsuUVjsDlRoqi5FjqFeS7DqpuyG2d2Sfet95M66IyYGYE3doBP4QNlF0JHMXf7uvjcmewtjDL5thuMhLgN8FeOI96WD1d8FcPtj7IrXKgRXJBCgce3WWkeL92AZE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578971109; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cGEohipzmDy9kQUhQkmw2CcILJXai0UI7mjRYvuc/t8=; b=mB/SPVf3bOBwBRLCzwVtc5qBLQr2qhZqlEBBxyisqmyHutKrlob2E9I1TRGO/lKACcB7Yh8xmSUAvVluAGhyRK6d/piQewM8uGwwxtUDHIYHKTCD15zWfAy1ZIuA/mmLS9fq5BEp8Ht7x2WbMLlCjm97/F1WRJP1IB3y2fD1gxo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578971109357963.5722579295868; Mon, 13 Jan 2020 19:05:09 -0800 (PST) Received: from localhost ([::1]:58642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irCVw-0007k5-2q for importer@patchew.org; Mon, 13 Jan 2020 22:05:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54205) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <3Pi8dXgMKCgkst8pxxpun.lxvznv3-mn4nuwxwpw3.x0p@flex--jkz.bounces.google.com>) id 1irCTL-0004la-1M for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3Pi8dXgMKCgkst8pxxpun.lxvznv3-mn4nuwxwpw3.x0p@flex--jkz.bounces.google.com>) id 1irCTI-0000r8-RL for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:26 -0500 Received: from mail-pg1-x549.google.com ([2607:f8b0:4864:20::549]:51395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <3Pi8dXgMKCgkst8pxxpun.lxvznv3-mn4nuwxwpw3.x0p@flex--jkz.bounces.google.com>) id 1irCTI-0000p4-It for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:24 -0500 Received: by mail-pg1-x549.google.com with SMTP id g20so7622621pgb.18 for ; Mon, 13 Jan 2020 19:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=cGEohipzmDy9kQUhQkmw2CcILJXai0UI7mjRYvuc/t8=; b=e/PcRYD0Lm8zBlayLqkCV7H561EbbZYxHbEhaEIjgy/5F8QjMHHmHv1rTQi7lbeQ9a QATCZ+IGRMS6zIn8FhOkerjia4h9h7gODe9M1djbBebgJxj1FVDAss7Ir2szsVvOFdWC OpIkQSrchp73Smh+X7cBhigKvCQp9c+69zLZwwH1zG/WFesVFpjXGtswcEuLMSyqS/zV OT3KqDgB2D1EiGCkT6SuQjGAew4YvWF/uu/fwdCPiKJr9a+bwfyC3AsezUK3sqSAFZVn M7K9gm2aU4Vwl9g4K2ER673HwzjWS9B//TWeSOtBiM4/WHf12afhgiVo+/N/OEYo2w0k Bxxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=cGEohipzmDy9kQUhQkmw2CcILJXai0UI7mjRYvuc/t8=; b=NObEWqXBQZICPtdZwVVs2+GQDYkR7rzWSaHq7+L4uRu5w09t7UBYfG/vHFceGNcWsL hM05+VkwQuTsypKw5wDhmzalkry8dJM0bH9eQr9fgH2G6VnILnC6uhzTJjuFKdRFy2Sh l0w/oVYSuVcdhsz8BWqeEYC9YhHZ6PaL9DqI6E3ho1oK425Lj5spQnqpyxjxFgKNdDwm 4VtTNk/U+L4GMxLK7p7U21XSuxnNZ8eVF0mjAkDQtlj1xU2+msvh+he7reIIUkT+Yl0+ jgje/APGvfEuCB9xObiyH/MhzFXe/T6H40UM/ZnqgSQ8K3P+9tnlMaAecEtb3eIqCfAU EXBg== X-Gm-Message-State: APjAAAUe0Ai/issQbywFSLtIPo0kkhRadFuvGNfS//l2eQdZaQwJYWdk Ppg6TTynYjL5HbAbP8LbzXM2Mme2EBIqtPx0am2yR+Bx9dSaXle2Q9hlr5Uw3KwmbjPf/eo/uT3 b4MpXfEspZRH3npBJd7fW04dkIPofQakHVcu0pJgVNHcuxyKK4+zW X-Google-Smtp-Source: APXvYqz2N6e+EVm9WFXWfR5nFMYPU/+cQvxRzBuTUauTHC7gr4a6GcsXs6om9j+uRnGC88TrLmsZ/+w= X-Received: by 2002:a63:710:: with SMTP id 16mr24220851pgh.58.1578970942586; Mon, 13 Jan 2020 19:02:22 -0800 (PST) Date: Mon, 13 Jan 2020 19:01:35 -0800 In-Reply-To: <20200114030138.260347-1-jkz@google.com> Message-Id: <20200114030138.260347-2-jkz@google.com> Mime-Version: 1.0 References: <20200114030138.260347-1-jkz@google.com> X-Mailer: git-send-email 2.25.0.rc1.283.g88dfdc4193-goog Subject: [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging From: Josh Kunz To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi, laurent@vivier.eu, alex.bennee@linaro.org, armbru@redhat.com, Josh Kunz X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::549 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This change introduces a new logging mask "LOG_USER", which is used for masking general user-mode logging. This change also switches all non-strace uses of `gemu_log' in linux-user/ to use `qemu_log_mask(LOG_USER, ...)' instead. This allows the user to easily log to a file, and to mask out these log messages if they desire. Signed-off-by: Josh Kunz --- include/qemu/log.h | 2 ++ linux-user/arm/cpu_loop.c | 5 ++-- linux-user/fd-trans.c | 55 +++++++++++++++++++++++++-------------- linux-user/main.c | 24 +++++++++++++++++ linux-user/syscall.c | 30 ++++++++++++--------- linux-user/vm86.c | 3 ++- util/log.c | 3 +++ 7 files changed, 86 insertions(+), 36 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index e0f4e40628..503e4f88d5 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -62,6 +62,8 @@ static inline bool qemu_log_separate(void) #define CPU_LOG_TB_OP_IND (1 << 16) #define CPU_LOG_TB_FPU (1 << 17) #define CPU_LOG_PLUGIN (1 << 18) +/* LOG_USER is used for some informational user-mode logging. */ +#define LOG_USER (1 << 19) =20 /* Lock output for a series of related logs. Since this is not needed * for a single qemu_log / qemu_log_mask / qemu_log_mask_and_addr, we diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_loop.c index 1fae90c6df..830ba8f138 100644 --- a/linux-user/arm/cpu_loop.c +++ b/linux-user/arm/cpu_loop.c @@ -349,8 +349,9 @@ void cpu_loop(CPUARMState *env) env->regs[0] =3D cpu_get_tls(env); break; default: - gemu_log("qemu: Unsupported ARM syscall: 0x%x\= n", - n); + qemu_log_mask(LOG_USER, + "qemu: Unsupported ARM syscall: = 0x%x\n", + n); env->regs[0] =3D -TARGET_ENOSYS; break; } diff --git a/linux-user/fd-trans.c b/linux-user/fd-trans.c index 9b92386abf..a5324b8a06 100644 --- a/linux-user/fd-trans.c +++ b/linux-user/fd-trans.c @@ -514,7 +514,8 @@ static abi_long host_to_target_data_bridge_nlattr(struc= t nlattr *nlattr, u32[1] =3D tswap32(u32[1]); /* optmask */ break; default: - gemu_log("Unknown QEMU_IFLA_BR type %d\n", nlattr->nla_type); + qemu_log_mask(LOG_USER, "Unknown QEMU_IFLA_BR type %d\n", + nlattr->nla_type); break; } return 0; @@ -577,7 +578,8 @@ static abi_long host_to_target_slave_data_bridge_nlattr= (struct nlattr *nlattr, case QEMU_IFLA_BRPORT_BRIDGE_ID: break; default: - gemu_log("Unknown QEMU_IFLA_BRPORT type %d\n", nlattr->nla_type); + qemu_log_mask(LOG_USER, "Unknown QEMU_IFLA_BRPORT type %d\n", + nlattr->nla_type); break; } return 0; @@ -605,7 +607,8 @@ static abi_long host_to_target_data_tun_nlattr(struct n= lattr *nlattr, *u32 =3D tswap32(*u32); break; default: - gemu_log("Unknown QEMU_IFLA_TUN type %d\n", nlattr->nla_type); + qemu_log_mask(LOG_USER, "Unknown QEMU_IFLA_TUN type %d\n", + nlattr->nla_type); break; } return 0; @@ -652,7 +655,8 @@ static abi_long host_to_target_data_linkinfo_nlattr(str= uct nlattr *nlattr, NULL, host_to_target_data_tun_nl= attr); } else { - gemu_log("Unknown QEMU_IFLA_INFO_KIND %s\n", li_context->name); + qemu_log_mask(LOG_USER, "Unknown QEMU_IFLA_INFO_KIND %s\n", + li_context->name); } break; case QEMU_IFLA_INFO_SLAVE_DATA: @@ -663,12 +667,13 @@ static abi_long host_to_target_data_linkinfo_nlattr(s= truct nlattr *nlattr, NULL, host_to_target_slave_data_bridge_nl= attr); } else { - gemu_log("Unknown QEMU_IFLA_INFO_SLAVE_KIND %s\n", + qemu_log_mask(LOG_USER, "Unknown QEMU_IFLA_INFO_SLAVE_KIND %s\= n", li_context->slave_name); } break; default: - gemu_log("Unknown host QEMU_IFLA_INFO type: %d\n", nlattr->nla_typ= e); + qemu_log_mask(LOG_USER, "Unknown host QEMU_IFLA_INFO type: %d\n", + nlattr->nla_type); break; } =20 @@ -690,7 +695,8 @@ static abi_long host_to_target_data_inet_nlattr(struct = nlattr *nlattr, } break; default: - gemu_log("Unknown host AF_INET type: %d\n", nlattr->nla_type); + qemu_log_mask(LOG_USER, "Unknown host AF_INET type: %d\n", + nlattr->nla_type); } return 0; } @@ -741,7 +747,8 @@ static abi_long host_to_target_data_inet6_nlattr(struct= nlattr *nlattr, } break; default: - gemu_log("Unknown host AF_INET6 type: %d\n", nlattr->nla_type); + qemu_log_mask(LOG_USER, "Unknown host AF_INET6 type: %d\n", + nlattr->nla_type); } return 0; } @@ -759,7 +766,8 @@ static abi_long host_to_target_data_spec_nlattr(struct = nlattr *nlattr, NULL, host_to_target_data_inet6_nla= ttr); default: - gemu_log("Unknown host AF_SPEC type: %d\n", nlattr->nla_type); + qemu_log_mask(LOG_USER, "Unknown host AF_SPEC type: %d\n", + nlattr->nla_type); break; } return 0; @@ -780,7 +788,8 @@ static abi_long host_to_target_data_xdp_nlattr(struct n= lattr *nlattr, *u32 =3D tswap32(*u32); break; default: - gemu_log("Unknown host XDP type: %d\n", nlattr->nla_type); + qemu_log_mask( + LOG_USER, "Unknown host XDP type: %d\n", nlattr->nla_type); break; } return 0; @@ -920,7 +929,8 @@ static abi_long host_to_target_data_link_rtattr(struct = rtattr *rtattr) NULL, host_to_target_data_xdp_nl= attr); default: - gemu_log("Unknown host QEMU_IFLA type: %d\n", rtattr->rta_type); + qemu_log_mask(LOG_USER, "Unknown host QEMU_IFLA type: %d\n", + rtattr->rta_type); break; } return 0; @@ -954,7 +964,8 @@ static abi_long host_to_target_data_addr_rtattr(struct = rtattr *rtattr) ci->tstamp =3D tswap32(ci->tstamp); break; default: - gemu_log("Unknown host IFA type: %d\n", rtattr->rta_type); + qemu_log_mask( + LOG_USER, "Unknown host IFA type: %d\n", rtattr->rta_type); break; } return 0; @@ -996,7 +1007,8 @@ static abi_long host_to_target_data_route_rtattr(struc= t rtattr *rtattr) #endif break; default: - gemu_log("Unknown host RTA type: %d\n", rtattr->rta_type); + qemu_log_mask( + LOG_USER, "Unknown host RTA type: %d\n", rtattr->rta_type); break; } return 0; @@ -1111,7 +1123,8 @@ static abi_long target_to_host_data_link_rtattr(struc= t rtattr *rtattr) { switch (rtattr->rta_type) { default: - gemu_log("Unknown target QEMU_IFLA type: %d\n", rtattr->rta_type); + qemu_log_mask(LOG_USER, "Unknown target QEMU_IFLA type: %d\n", + rtattr->rta_type); break; } return 0; @@ -1125,7 +1138,8 @@ static abi_long target_to_host_data_addr_rtattr(struc= t rtattr *rtattr) case IFA_ADDRESS: break; default: - gemu_log("Unknown target IFA type: %d\n", rtattr->rta_type); + qemu_log_mask(LOG_USER, "Unknown target IFA type: %d\n", + rtattr->rta_type); break; } return 0; @@ -1147,7 +1161,8 @@ static abi_long target_to_host_data_route_rtattr(stru= ct rtattr *rtattr) *u32 =3D tswap32(*u32); break; default: - gemu_log("Unknown target RTA type: %d\n", rtattr->rta_type); + qemu_log_mask(LOG_USER, "Unknown target RTA type: %d\n", + rtattr->rta_type); break; } return 0; @@ -1232,8 +1247,8 @@ static abi_long host_to_target_data_audit(struct nlms= ghdr *nlh) { switch (nlh->nlmsg_type) { default: - gemu_log("Unknown host audit message type %d\n", - nlh->nlmsg_type); + qemu_log_mask(LOG_USER, "Unknown host audit message type %d\n", + nlh->nlmsg_type); return -TARGET_EINVAL; } return 0; @@ -1253,8 +1268,8 @@ static abi_long target_to_host_data_audit(struct nlms= ghdr *nlh) case AUDIT_FIRST_USER_MSG2 ... AUDIT_LAST_USER_MSG2: break; default: - gemu_log("Unknown target audit message type %d\n", - nlh->nlmsg_type); + qemu_log_mask(LOG_USER, "Unknown target audit message type %d\n", + nlh->nlmsg_type); return -TARGET_EINVAL; } =20 diff --git a/linux-user/main.c b/linux-user/main.c index 8718d03ee2..c4f3de77db 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -60,6 +60,9 @@ unsigned long mmap_min_addr; unsigned long guest_base; int have_guest_base; =20 +/* Used to implement backwards-compatibility for user-mode logging. */ +static bool force_user_mode_logging =3D true; + /* * When running 32-on-64 we should make sure we can fit all of the possible * guest address space into a contiguous chunk of virtual host memory. @@ -399,6 +402,11 @@ static void handle_arg_abi_call0(const char *arg) } #endif =20 +static void handle_arg_no_force_user_mode_logging(const char *arg) +{ + force_user_mode_logging =3D false; +} + static QemuPluginList plugins =3D QTAILQ_HEAD_INITIALIZER(plugins); =20 #ifdef CONFIG_PLUGIN @@ -469,6 +477,10 @@ static const struct qemu_argument arg_table[] =3D { {"xtensa-abi-call0", "QEMU_XTENSA_ABI_CALL0", false, handle_arg_abi_ca= ll0, "", "assume CALL0 Xtensa ABI"}, #endif + {"no-force-user-mode-logging", "", false, + handle_arg_no_force_user_mode_logging, + "", "disable forced user-mode logging, other logging option= s " + "will be used exactly as provided" }, {NULL, NULL, false, NULL, NULL, NULL} }; =20 @@ -661,6 +673,18 @@ int main(int argc, char **argv, char **envp) =20 optind =3D parse_args(argc, argv); =20 + if (force_user_mode_logging) { + /* + * Backwards Compatibility: gemu_log for non-strace messages was n= ot + * configurable, and was always on. Unless the user explicitly dis= ables + * forced LOG_USER, force LOG_USER into the mask. + */ + qemu_add_log(LOG_USER); + } + + qemu_log_mask(LOG_USER, "--> from user\n"); + qemu_log_mask(LOG_STRACE, "--> from strace\n"); + if (!trace_init_backends()) { exit(1); } diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 171c0caef3..7e23dd6327 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1555,7 +1555,7 @@ static inline abi_long target_to_host_cmsg(struct msg= hdr *msgh, * something more intelligent than "twice the size of the * target buffer we're reading from". */ - gemu_log("Host cmsg overflow\n"); + qemu_log_mask(LOG_USER, "Host cmsg overflow\n"); break; } =20 @@ -1585,8 +1585,8 @@ static inline abi_long target_to_host_cmsg(struct msg= hdr *msgh, __get_user(cred->uid, &target_cred->uid); __get_user(cred->gid, &target_cred->gid); } else { - gemu_log("Unsupported ancillary data: %d/%d\n", - cmsg->cmsg_level, cmsg->cmsg_type); + qemu_log_mask(LOG_USER, "Unsupported ancillary data: %d/%d\n", + cmsg->cmsg_level, cmsg->cmsg_type); memcpy(data, target_data, len); } =20 @@ -1807,8 +1807,8 @@ static inline abi_long host_to_target_cmsg(struct tar= get_msghdr *target_msgh, =20 default: unimplemented: - gemu_log("Unsupported ancillary data: %d/%d\n", - cmsg->cmsg_level, cmsg->cmsg_type); + qemu_log_mask(LOG_USER, "Unsupported ancillary data: %d/%d\n", + cmsg->cmsg_level, cmsg->cmsg_type); memcpy(target_data, data, MIN(len, tgt_len)); if (tgt_len > len) { memset(target_data + len, 0, tgt_len - len); @@ -2283,7 +2283,8 @@ set_timeout: #endif /* SOL_NETLINK */ default: unimplemented: - gemu_log("Unsupported setsockopt level=3D%d optname=3D%d\n", level= , optname); + qemu_log_mask(LOG_USER, "Unsupported setsockopt level=3D%d optname= =3D%d\n", + level, optname); ret =3D -TARGET_ENOPROTOOPT; } return ret; @@ -2636,8 +2637,9 @@ static abi_long do_getsockopt(int sockfd, int level, = int optname, #endif /* SOL_NETLINK */ default: unimplemented: - gemu_log("getsockopt level=3D%d optname=3D%d not yet supported\n", - level, optname); + qemu_log_mask(LOG_USER, + "getsockopt level=3D%d optname=3D%d not yet supporte= d\n", + level, optname); ret =3D -TARGET_EOPNOTSUPP; break; } @@ -3392,7 +3394,7 @@ static abi_long do_socketcall(int num, abi_ulong vptr) case TARGET_SYS_SENDMMSG: /* sockfd, msgvec, vlen, flags */ return do_sendrecvmmsg(a[0], a[1], a[2], a[3], 1); default: - gemu_log("Unsupported socketcall: %d\n", num); + qemu_log_mask(LOG_USER, "Unsupported socketcall: %d\n", num); return -TARGET_EINVAL; } } @@ -4303,7 +4305,8 @@ static abi_long do_ipc(CPUArchState *cpu_env, ret =3D do_shmctl(first, second, ptr); break; default: - gemu_log("Unsupported ipc call: %d (version %d)\n", call, version); + qemu_log_mask(LOG_USER, "Unsupported ipc call: %d (version %d)\n", + call, version); ret =3D -TARGET_ENOSYS; break; } @@ -5151,7 +5154,8 @@ static abi_long do_ioctl(int fd, int cmd, abi_long ar= g) ie =3D ioctl_entries; for(;;) { if (ie->target_cmd =3D=3D 0) { - gemu_log("Unsupported ioctl: cmd=3D0x%04lx\n", (long)cmd); + qemu_log_mask( + LOG_USER, "Unsupported ioctl: cmd=3D0x%04lx\n", (long)cmd); return -TARGET_ENOSYS; } if (ie->target_cmd =3D=3D cmd) @@ -5217,8 +5221,8 @@ static abi_long do_ioctl(int fd, int cmd, abi_long ar= g) } break; default: - gemu_log("Unsupported ioctl type: cmd=3D0x%04lx type=3D%d\n", - (long)cmd, arg_type[0]); + qemu_log_mask(LOG_USER, "Unsupported ioctl type: cmd=3D0x%04lx typ= e=3D%d\n", + (long)cmd, arg_type[0]); ret =3D -TARGET_ENOSYS; break; } diff --git a/linux-user/vm86.c b/linux-user/vm86.c index 2fa7a89edc..0013fd8368 100644 --- a/linux-user/vm86.c +++ b/linux-user/vm86.c @@ -402,7 +402,8 @@ int do_vm86(CPUX86State *env, long subfunction, abi_ulo= ng vm86_addr) case TARGET_VM86_FREE_IRQ: case TARGET_VM86_GET_IRQ_BITS: case TARGET_VM86_GET_AND_RESET_IRQ: - gemu_log("qemu: unsupported vm86 subfunction (%ld)\n", subfunction= ); + qemu_log_mask(LOG_USER, "qemu: unsupported vm86 subfunction (%ld)\= n", + subfunction); ret =3D -TARGET_EINVAL; goto out; case TARGET_VM86_PLUS_INSTALL_CHECK: diff --git a/util/log.c b/util/log.c index 867264da8d..b14d17fafb 100644 --- a/util/log.c +++ b/util/log.c @@ -328,6 +328,9 @@ const QEMULogItem qemu_log_items[] =3D { #ifdef CONFIG_PLUGIN { CPU_LOG_PLUGIN, "plugin", "output from TCG plugins\n"}, #endif + { LOG_USER, "user_mode", + "log when QEMU encounters errors in the user-mode emulation layer.\n" + "For example, when a socket option or syscall is not implemented" }, { 0, NULL, NULL }, }; =20 --=20 2.25.0.rc1.283.g88dfdc4193-goog From nobody Wed Apr 24 04:09:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1578971133; cv=none; d=zohomail.com; s=zohoarc; b=HmPmY0dPiCxmnebdxXBtY5Bs5I1gaL9t8BpJ3/x4314LF08O2fYGaBK/vagx4WR19BbXxTr2+4LZaAhojVf/vNMAOXOf3pzYiqagDY51JO7/EIa9QizoP0n3A5W5evOSlYKg6QUQ1+VNaxIr0T9P9qUpi5cmDu+GnREr989BMkU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578971133; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LDZEtfRr/8SdtE3nhm7o/PaqJNKStP02H+qgdEhj5uQ=; b=Y2Un1/dwBOrMnwSs3Y7gu2QyER29hlUohtQDZdSf1GckWggblE0DZxHIUmUK7eTi5+sYvYSYdKuHAg35gEMVS8iBkRsJTKZkEf4rnqLJj+hJwv11n6FXBfLxlfIi6kGNBcs22/wpPzeHyETEr7wviICr12vBg6UAoWD5xOYhIu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578971133366598.0925533907365; Mon, 13 Jan 2020 19:05:33 -0800 (PST) Received: from localhost ([::1]:58645 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irCWK-0008AG-1b for importer@patchew.org; Mon, 13 Jan 2020 22:05:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54233) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <3QC8dXgMKCgsuvArzzrwp.nzx1px5-op6pwyzyry5.z2r@flex--jkz.bounces.google.com>) id 1irCTP-0004q9-AO for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3QC8dXgMKCgsuvArzzrwp.nzx1px5-op6pwyzyry5.z2r@flex--jkz.bounces.google.com>) id 1irCTL-0000uA-2E for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:31 -0500 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]:33182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <3QC8dXgMKCgsuvArzzrwp.nzx1px5-op6pwyzyry5.z2r@flex--jkz.bounces.google.com>) id 1irCTK-0000ru-Md for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:27 -0500 Received: by mail-pl1-x649.google.com with SMTP id bd7so4438499plb.0 for ; Mon, 13 Jan 2020 19:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=LDZEtfRr/8SdtE3nhm7o/PaqJNKStP02H+qgdEhj5uQ=; b=vwsK5CXtTbMJa9oQg1ohMgLff/GVe3DQJpTyJusaj/CTk+mX5J7AxFmm38Ab00rMwQ rNq55rfQuTTK9Yqv2Tk2f5FYgUvAI+7RR7RIGYFLqoMl0dHtyVVo0VWGMV8c79Dk3ild DYr9urwoic1PydRf1VCjYLak9kNp6sI0iRAWz+XLqSF2/V541bVEgvO+E0zvcyYcGfpr ugg13kEG4QJ9R6P+N9RVuv0A55qtnnJtRx5azHchYk9TSecwgvYvd+lHF752/EAODMfv 6qVpKvxLqSgIBGgl8H7r1p9F/phEJoIpWlqrqOlJ6FJ9ZQWgdofXjdyeCjb9XOH/hmtx OBSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=LDZEtfRr/8SdtE3nhm7o/PaqJNKStP02H+qgdEhj5uQ=; b=Xn9CKsX7PwcIneAvWbspXbGxXu51DbsgLlvTKxhuAORQlBTV8wxxzf3+ChCX6Y7I/F zkm5qSDQvdtC88al87put/Xc1+1Qy9joVX0gfVLHF7sH1IapEr31png0UpTrSK3TFjf8 mMP9+qTBpdSfbnhf7YBuulf3TXpIMajkjIuzNFxnpRULab7OhcWES+g7EMcXxiVm7AT8 +XQ0jBOxpHeATVkuIYTCig5DFF2Tx+Vr2pST4ANg0V+gRybfNxtGUl3L4wX27Emi5Yrz 6z/LVEkNImAxdqICn8udWU+h9nBx4tkZARD2OaxgrV2kBOOsWih0fBYfYF30q8n29WgZ +jiA== X-Gm-Message-State: APjAAAU4v8piCoEyhA6Q6SbiiMaUCsUGAOj7KtH4ew9FXxG9qFzQByi4 VyWykC1uBR+fmEnXZScrUAr7UIOpHE5MID+ig1rupJOCMO399KeNbFa4bPsci+WXeWp9M5F0YnG hsrOZVZ2UIpHQiBTrhfqL2hZt40IfAFdPxEBfP3VFJY57XG6tWZnL X-Google-Smtp-Source: APXvYqyMh62HylZ5h5GVPmCwwbj8KLOGoA758R6fNV3kYFxXhJIzlR6rRkElyke77MRj0jBAeMoh1hc= X-Received: by 2002:a63:646:: with SMTP id 67mr24414064pgg.150.1578970944784; Mon, 13 Jan 2020 19:02:24 -0800 (PST) Date: Mon, 13 Jan 2020 19:01:36 -0800 In-Reply-To: <20200114030138.260347-1-jkz@google.com> Message-Id: <20200114030138.260347-3-jkz@google.com> Mime-Version: 1.0 References: <20200114030138.260347-1-jkz@google.com> X-Mailer: git-send-email 2.25.0.rc1.283.g88dfdc4193-goog Subject: [PATCH 2/4] linux-user: Use `qemu_log' for strace From: Josh Kunz To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi, laurent@vivier.eu, alex.bennee@linaro.org, armbru@redhat.com, Josh Kunz X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::649 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This change switches linux-user strace logging to use the newer `qemu_log` logging subsystem rather than the older `gemu_log` (notice the "g") logger. `qemu_log` has several advantages, namely that it allows logging to a file, and provides a more unified interface for configuration of logging (via the QEMU_LOG environment variable or options). Signed-off-by: Josh Kunz --- include/qemu/log.h | 13 ++ linux-user/main.c | 17 +- linux-user/qemu.h | 1 - linux-user/signal.c | 3 +- linux-user/strace.c | 479 ++++++++++++++++++++++--------------------- linux-user/syscall.c | 13 +- util/log.c | 2 + 7 files changed, 282 insertions(+), 246 deletions(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 503e4f88d5..8f044c1716 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -64,6 +64,7 @@ static inline bool qemu_log_separate(void) #define CPU_LOG_PLUGIN (1 << 18) /* LOG_USER is used for some informational user-mode logging. */ #define LOG_USER (1 << 19) +#define LOG_STRACE (1 << 20) =20 /* Lock output for a series of related logs. Since this is not needed * for a single qemu_log / qemu_log_mask / qemu_log_mask_and_addr, we @@ -154,6 +155,18 @@ void qemu_set_dfilter_ranges(const char *ranges, Error= **errp); bool qemu_log_in_addr_range(uint64_t addr); int qemu_str_to_log_mask(const char *str); =20 +/* Add (union) the given "log_flags" to the current log mask. */ +static inline void qemu_add_log(int log_flags) +{ + qemu_set_log(qemu_loglevel | log_flags); +} + +/* Remove (subtract) the given log flags from the current log mask. */ +static inline void qemu_del_log(int log_flags) +{ + qemu_set_log(qemu_loglevel & ~(log_flags)); +} + /* Print a usage message listing all the valid logging categories * to the specified FILE*. */ diff --git a/linux-user/main.c b/linux-user/main.c index c4f3de77db..0bf40c4d27 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -63,6 +63,12 @@ int have_guest_base; /* Used to implement backwards-compatibility for user-mode logging. */ static bool force_user_mode_logging =3D true; =20 +/* + * Used to implement backwards-compatibility for the `-strace`, and + * QEMU_STRACE options. + */ +static bool enable_strace; + /* * When running 32-on-64 we should make sure we can fit all of the possible * guest address space into a contiguous chunk of virtual host memory. @@ -378,7 +384,7 @@ static void handle_arg_singlestep(const char *arg) =20 static void handle_arg_strace(const char *arg) { - do_strace =3D 1; + enable_strace =3D true; } =20 static void handle_arg_version(const char *arg) @@ -672,6 +678,15 @@ int main(int argc, char **argv, char **envp) qemu_plugin_add_opts(); =20 optind =3D parse_args(argc, argv); + /* + * Backwards Compatability: If handle_arg_strace just enabled strace + * logging directly, then it could be accidentally turned off by a + * QEMU_LOG/-d option. To make sure that strace logging is always enab= led + * when QEMU_STRACE/-strace is set, re-enable LOG_STRACE here. + */ + if (enable_strace) { + qemu_add_log(LOG_STRACE); + } =20 if (force_user_mode_logging) { /* diff --git a/linux-user/qemu.h b/linux-user/qemu.h index f6f5fe5fbb..02c6890c8a 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -385,7 +385,6 @@ void print_syscall_ret(int num, abi_long arg1); * --- SIGSEGV {si_signo=3DSIGSEGV, si_code=3DSI_KERNEL, si_addr=3D0} --- */ void print_taken_signal(int target_signum, const target_siginfo_t *tinfo); -extern int do_strace; =20 /* signal.c */ void process_pending_signals(CPUArchState *cpu_env); diff --git a/linux-user/signal.c b/linux-user/signal.c index 5ca6d62b15..2ff0065804 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -864,9 +864,8 @@ static void handle_pending_signal(CPUArchState *cpu_env= , int sig, handler =3D sa->_sa_handler; } =20 - if (do_strace) { + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) print_taken_signal(sig, &k->info); - } =20 if (handler =3D=3D TARGET_SIG_DFL) { /* default handler : ignore some signal. The other are job control= or fatal */ diff --git a/linux-user/strace.c b/linux-user/strace.c index 3d4d684450..4f7130b2ff 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -12,8 +12,6 @@ #include #include "qemu.h" =20 -int do_strace=3D0; - struct syscallname { int nr; const char *name; @@ -80,7 +78,7 @@ print_ipc_cmd(int cmd) { #define output_cmd(val) \ if( cmd =3D=3D val ) { \ - gemu_log(#val); \ + qemu_log(#val); \ return; \ } =20 @@ -120,7 +118,7 @@ if( cmd =3D=3D val ) { \ output_cmd( IPC_RMID ); =20 /* Some value we don't recognize */ - gemu_log("%d",cmd); + qemu_log("%d", cmd); } =20 static void @@ -151,7 +149,7 @@ print_signal(abi_ulong arg, int last) print_raw_param("%ld", arg, last); return; } - gemu_log("%s%s", signal_name, get_comma(last)); + qemu_log("%s%s", signal_name, get_comma(last)); } =20 static void print_si_code(int arg) @@ -184,10 +182,10 @@ static void print_si_code(int arg) codename =3D "SI_TKILL"; break; default: - gemu_log("%d", arg); + qemu_log("%d", arg); return; } - gemu_log("%s", codename); + qemu_log("%s", codename); } =20 static void get_target_siginfo(target_siginfo_t *tinfo, @@ -288,33 +286,33 @@ static void print_siginfo(const target_siginfo_t *tin= fo) int si_type =3D extract32(tinfo->si_code, 16, 16); int si_code =3D sextract32(tinfo->si_code, 0, 16); =20 - gemu_log("{si_signo=3D"); + qemu_log("{si_signo=3D"); print_signal(tinfo->si_signo, 1); - gemu_log(", si_code=3D"); + qemu_log(", si_code=3D"); print_si_code(si_code); =20 switch (si_type) { case QEMU_SI_KILL: - gemu_log(", si_pid=3D%u, si_uid=3D%u", + qemu_log(", si_pid=3D%u, si_uid=3D%u", (unsigned int)tinfo->_sifields._kill._pid, (unsigned int)tinfo->_sifields._kill._uid); break; case QEMU_SI_TIMER: - gemu_log(", si_timer1=3D%u, si_timer2=3D%u", + qemu_log(", si_timer1=3D%u, si_timer2=3D%u", tinfo->_sifields._timer._timer1, tinfo->_sifields._timer._timer2); break; case QEMU_SI_POLL: - gemu_log(", si_band=3D%d, si_fd=3D%d", + qemu_log(", si_band=3D%d, si_fd=3D%d", tinfo->_sifields._sigpoll._band, tinfo->_sifields._sigpoll._fd); break; case QEMU_SI_FAULT: - gemu_log(", si_addr=3D"); + qemu_log(", si_addr=3D"); print_pointer(tinfo->_sifields._sigfault._addr, 1); break; case QEMU_SI_CHLD: - gemu_log(", si_pid=3D%u, si_uid=3D%u, si_status=3D%d" + qemu_log(", si_pid=3D%u, si_uid=3D%u, si_status=3D%d" ", si_utime=3D" TARGET_ABI_FMT_ld ", si_stime=3D" TARGET_ABI_FMT_ld, (unsigned int)(tinfo->_sifields._sigchld._pid), @@ -324,7 +322,7 @@ static void print_siginfo(const target_siginfo_t *tinfo) tinfo->_sifields._sigchld._stime); break; case QEMU_SI_RT: - gemu_log(", si_pid=3D%u, si_uid=3D%u, si_sigval=3D" TARGET_ABI_FMT= _ld, + qemu_log(", si_pid=3D%u, si_uid=3D%u, si_sigval=3D" TARGET_ABI_FMT= _ld, (unsigned int)tinfo->_sifields._rt._pid, (unsigned int)tinfo->_sifields._rt._uid, tinfo->_sifields._rt._sigval.sival_ptr); @@ -332,7 +330,7 @@ static void print_siginfo(const target_siginfo_t *tinfo) default: g_assert_not_reached(); } - gemu_log("}"); + qemu_log("}"); } =20 static void @@ -349,76 +347,76 @@ print_sockaddr(abi_ulong addr, abi_long addrlen, int = last) case AF_UNIX: { struct target_sockaddr_un *un =3D (struct target_sockaddr_un *= )sa; int i; - gemu_log("{sun_family=3DAF_UNIX,sun_path=3D\""); + qemu_log("{sun_family=3DAF_UNIX,sun_path=3D\""); for (i =3D 0; i < addrlen - offsetof(struct target_sockaddr_un, sun_path) = && un->sun_path[i]; i++) { - gemu_log("%c", un->sun_path[i]); + qemu_log("%c", un->sun_path[i]); } - gemu_log("\"}"); + qemu_log("\"}"); break; } case AF_INET: { struct target_sockaddr_in *in =3D (struct target_sockaddr_in *= )sa; uint8_t *c =3D (uint8_t *)&in->sin_addr.s_addr; - gemu_log("{sin_family=3DAF_INET,sin_port=3Dhtons(%d),", + qemu_log("{sin_family=3DAF_INET,sin_port=3Dhtons(%d),", ntohs(in->sin_port)); - gemu_log("sin_addr=3Dinet_addr(\"%d.%d.%d.%d\")", + qemu_log("sin_addr=3Dinet_addr(\"%d.%d.%d.%d\")", c[0], c[1], c[2], c[3]); - gemu_log("}"); + qemu_log("}"); break; } case AF_PACKET: { struct target_sockaddr_ll *ll =3D (struct target_sockaddr_ll *= )sa; uint8_t *c =3D (uint8_t *)&ll->sll_addr; - gemu_log("{sll_family=3DAF_PACKET," + qemu_log("{sll_family=3DAF_PACKET," "sll_protocol=3Dhtons(0x%04x),if%d,pkttype=3D", ntohs(ll->sll_protocol), ll->sll_ifindex); switch (ll->sll_pkttype) { case PACKET_HOST: - gemu_log("PACKET_HOST"); + qemu_log("PACKET_HOST"); break; case PACKET_BROADCAST: - gemu_log("PACKET_BROADCAST"); + qemu_log("PACKET_BROADCAST"); break; case PACKET_MULTICAST: - gemu_log("PACKET_MULTICAST"); + qemu_log("PACKET_MULTICAST"); break; case PACKET_OTHERHOST: - gemu_log("PACKET_OTHERHOST"); + qemu_log("PACKET_OTHERHOST"); break; case PACKET_OUTGOING: - gemu_log("PACKET_OUTGOING"); + qemu_log("PACKET_OUTGOING"); break; default: - gemu_log("%d", ll->sll_pkttype); + qemu_log("%d", ll->sll_pkttype); break; } - gemu_log(",sll_addr=3D%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", + qemu_log(",sll_addr=3D%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", c[0], c[1], c[2], c[3], c[4], c[5], c[6], c[7]); - gemu_log("}"); + qemu_log("}"); break; } case AF_NETLINK: { struct target_sockaddr_nl *nl =3D (struct target_sockaddr_nl *= )sa; - gemu_log("{nl_family=3DAF_NETLINK,nl_pid=3D%u,nl_groups=3D%u}", + qemu_log("{nl_family=3DAF_NETLINK,nl_pid=3D%u,nl_groups=3D%u}", tswap32(nl->nl_pid), tswap32(nl->nl_groups)); break; } default: - gemu_log("{sa_family=3D%d, sa_data=3D{", sa->sa_family); + qemu_log("{sa_family=3D%d, sa_data=3D{", sa->sa_family); for (i =3D 0; i < 13; i++) { - gemu_log("%02x, ", sa->sa_data[i]); + qemu_log("%02x, ", sa->sa_data[i]); } - gemu_log("%02x}", sa->sa_data[i]); - gemu_log("}"); + qemu_log("%02x}", sa->sa_data[i]); + qemu_log("}"); break; } unlock_user(sa, addr, 0); } else { print_raw_param("0x"TARGET_ABI_FMT_lx, addr, 0); } - gemu_log(", "TARGET_ABI_FMT_ld"%s", addrlen, get_comma(last)); + qemu_log(", "TARGET_ABI_FMT_ld"%s", addrlen, get_comma(last)); } =20 static void @@ -426,19 +424,19 @@ print_socket_domain(int domain) { switch (domain) { case PF_UNIX: - gemu_log("PF_UNIX"); + qemu_log("PF_UNIX"); break; case PF_INET: - gemu_log("PF_INET"); + qemu_log("PF_INET"); break; case PF_NETLINK: - gemu_log("PF_NETLINK"); + qemu_log("PF_NETLINK"); break; case PF_PACKET: - gemu_log("PF_PACKET"); + qemu_log("PF_PACKET"); break; default: - gemu_log("%d", domain); + qemu_log("%d", domain); break; } } @@ -448,22 +446,22 @@ print_socket_type(int type) { switch (type) { case TARGET_SOCK_DGRAM: - gemu_log("SOCK_DGRAM"); + qemu_log("SOCK_DGRAM"); break; case TARGET_SOCK_STREAM: - gemu_log("SOCK_STREAM"); + qemu_log("SOCK_STREAM"); break; case TARGET_SOCK_RAW: - gemu_log("SOCK_RAW"); + qemu_log("SOCK_RAW"); break; case TARGET_SOCK_RDM: - gemu_log("SOCK_RDM"); + qemu_log("SOCK_RDM"); break; case TARGET_SOCK_SEQPACKET: - gemu_log("SOCK_SEQPACKET"); + qemu_log("SOCK_SEQPACKET"); break; case TARGET_SOCK_PACKET: - gemu_log("SOCK_PACKET"); + qemu_log("SOCK_PACKET"); break; } } @@ -475,10 +473,10 @@ print_socket_protocol(int domain, int type, int proto= col) (domain =3D=3D AF_INET && type =3D=3D TARGET_SOCK_PACKET)) { switch (protocol) { case 0x0003: - gemu_log("ETH_P_ALL"); + qemu_log("ETH_P_ALL"); break; default: - gemu_log("%d", protocol); + qemu_log("%d", protocol); } return; } @@ -486,25 +484,25 @@ print_socket_protocol(int domain, int type, int proto= col) if (domain =3D=3D PF_NETLINK) { switch (protocol) { case NETLINK_ROUTE: - gemu_log("NETLINK_ROUTE"); + qemu_log("NETLINK_ROUTE"); break; case NETLINK_AUDIT: - gemu_log("NETLINK_AUDIT"); + qemu_log("NETLINK_AUDIT"); break; case NETLINK_NETFILTER: - gemu_log("NETLINK_NETFILTER"); + qemu_log("NETLINK_NETFILTER"); break; case NETLINK_KOBJECT_UEVENT: - gemu_log("NETLINK_KOBJECT_UEVENT"); + qemu_log("NETLINK_KOBJECT_UEVENT"); break; case NETLINK_RDMA: - gemu_log("NETLINK_RDMA"); + qemu_log("NETLINK_RDMA"); break; case NETLINK_CRYPTO: - gemu_log("NETLINK_CRYPTO"); + qemu_log("NETLINK_CRYPTO"); break; default: - gemu_log("%d", protocol); + qemu_log("%d", protocol); break; } return; @@ -512,19 +510,19 @@ print_socket_protocol(int domain, int type, int proto= col) =20 switch (protocol) { case IPPROTO_IP: - gemu_log("IPPROTO_IP"); + qemu_log("IPPROTO_IP"); break; case IPPROTO_TCP: - gemu_log("IPPROTO_TCP"); + qemu_log("IPPROTO_TCP"); break; case IPPROTO_UDP: - gemu_log("IPPROTO_UDP"); + qemu_log("IPPROTO_UDP"); break; case IPPROTO_RAW: - gemu_log("IPPROTO_RAW"); + qemu_log("IPPROTO_RAW"); break; default: - gemu_log("%d", protocol); + qemu_log("%d", protocol); break; } } @@ -536,7 +534,7 @@ print_fdset(int n, abi_ulong target_fds_addr) { int i; =20 - gemu_log("["); + qemu_log("["); if( target_fds_addr ) { abi_long *target_fds; =20 @@ -550,11 +548,11 @@ print_fdset(int n, abi_ulong target_fds_addr) =20 for (i=3Dn; i>=3D0; i--) { if ((tswapal(target_fds[i / TARGET_ABI_BITS]) >> (i & (TARGET_= ABI_BITS - 1))) & 1) - gemu_log("%d,", i ); + qemu_log("%d,", i); } unlock_user(target_fds, target_fds_addr, 0); } - gemu_log("]"); + qemu_log("]"); } #endif =20 @@ -578,46 +576,46 @@ print_clockid(int clockid, int last) { switch (clockid) { case TARGET_CLOCK_REALTIME: - gemu_log("CLOCK_REALTIME"); + qemu_log("CLOCK_REALTIME"); break; case TARGET_CLOCK_MONOTONIC: - gemu_log("CLOCK_MONOTONIC"); + qemu_log("CLOCK_MONOTONIC"); break; case TARGET_CLOCK_PROCESS_CPUTIME_ID: - gemu_log("CLOCK_PROCESS_CPUTIME_ID"); + qemu_log("CLOCK_PROCESS_CPUTIME_ID"); break; case TARGET_CLOCK_THREAD_CPUTIME_ID: - gemu_log("CLOCK_THREAD_CPUTIME_ID"); + qemu_log("CLOCK_THREAD_CPUTIME_ID"); break; case TARGET_CLOCK_MONOTONIC_RAW: - gemu_log("CLOCK_MONOTONIC_RAW"); + qemu_log("CLOCK_MONOTONIC_RAW"); break; case TARGET_CLOCK_REALTIME_COARSE: - gemu_log("CLOCK_REALTIME_COARSE"); + qemu_log("CLOCK_REALTIME_COARSE"); break; case TARGET_CLOCK_MONOTONIC_COARSE: - gemu_log("CLOCK_MONOTONIC_COARSE"); + qemu_log("CLOCK_MONOTONIC_COARSE"); break; case TARGET_CLOCK_BOOTTIME: - gemu_log("CLOCK_BOOTTIME"); + qemu_log("CLOCK_BOOTTIME"); break; case TARGET_CLOCK_REALTIME_ALARM: - gemu_log("CLOCK_REALTIME_ALARM"); + qemu_log("CLOCK_REALTIME_ALARM"); break; case TARGET_CLOCK_BOOTTIME_ALARM: - gemu_log("CLOCK_BOOTTIME_ALARM"); + qemu_log("CLOCK_BOOTTIME_ALARM"); break; case TARGET_CLOCK_SGI_CYCLE: - gemu_log("CLOCK_SGI_CYCLE"); + qemu_log("CLOCK_SGI_CYCLE"); break; case TARGET_CLOCK_TAI: - gemu_log("CLOCK_TAI"); + qemu_log("CLOCK_TAI"); break; default: - gemu_log("%d", clockid); + qemu_log("%d", clockid); break; } - gemu_log("%s", get_comma(last)); + qemu_log("%s", get_comma(last)); } #endif =20 @@ -638,15 +636,15 @@ print_newselect(const struct syscallname *name, abi_long arg1, abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6) { - gemu_log("%s(" TARGET_ABI_FMT_ld ",", name->name, arg1); + qemu_log("%s(" TARGET_ABI_FMT_ld ",", name->name, arg1); print_fdset(arg1, arg2); - gemu_log(","); + qemu_log(","); print_fdset(arg1, arg3); - gemu_log(","); + qemu_log(","); print_fdset(arg1, arg4); - gemu_log(","); + qemu_log(","); print_timeval(arg5, 1); - gemu_log(")"); + qemu_log(")"); =20 /* save for use in the return output function below */ newselect_arg1=3Darg1; @@ -663,9 +661,10 @@ print_semctl(const struct syscallname *name, abi_long arg1, abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6) { - gemu_log("%s(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ",", name->name= , arg1, arg2); + qemu_log("%s(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ",", + name->name, arg1, arg2); print_ipc_cmd(arg3); - gemu_log(",0x" TARGET_ABI_FMT_lx ")", arg4); + qemu_log(",0x" TARGET_ABI_FMT_lx ")", arg4); } #endif =20 @@ -679,7 +678,7 @@ print_execve(const struct syscallname *name, =20 if (!(s =3D lock_user_string(arg1))) return; - gemu_log("%s(\"%s\",{", name->name, s); + qemu_log("%s(\"%s\",{", name->name, s); unlock_user(s, arg1, 0); =20 for (arg_ptr_addr =3D arg2; ; arg_ptr_addr +=3D sizeof(abi_ulong)) { @@ -693,12 +692,12 @@ print_execve(const struct syscallname *name, if (!arg_addr) break; if ((s =3D lock_user_string(arg_addr))) { - gemu_log("\"%s\",", s); + qemu_log("\"%s\",", s); unlock_user(s, arg_addr, 0); } } =20 - gemu_log("NULL})"); + qemu_log("NULL})"); } =20 #ifdef TARGET_NR_ipc @@ -709,12 +708,18 @@ print_ipc(const struct syscallname *name, { switch(arg1) { case IPCOP_semctl: - gemu_log("semctl(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ",", ar= g1, arg2); + qemu_log("semctl(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ",", + arg1, arg2); print_ipc_cmd(arg3); - gemu_log(",0x" TARGET_ABI_FMT_lx ")", arg4); + qemu_log(",0x" TARGET_ABI_FMT_lx ")", arg4); break; default: - gemu_log("%s(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "," TARGET_= ABI_FMT_ld "," TARGET_ABI_FMT_ld ")", + qemu_log(("%s(" + TARGET_ABI_FMT_ld "," + TARGET_ABI_FMT_ld "," + TARGET_ABI_FMT_ld "," + TARGET_ABI_FMT_ld + ")"), name->name, arg1, arg2, arg3, arg4); } } @@ -733,9 +738,9 @@ print_syscall_ret_addr(const struct syscallname *name, = abi_long ret) errstr =3D target_strerror(-ret); } if (errstr) { - gemu_log(" =3D -1 errno=3D%d (%s)\n", (int)-ret, errstr); + qemu_log(" =3D -1 errno=3D%d (%s)\n", (int)-ret, errstr); } else { - gemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); + qemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); } } =20 @@ -743,7 +748,7 @@ print_syscall_ret_addr(const struct syscallname *name, = abi_long ret) static void print_syscall_ret_raw(struct syscallname *name, abi_long ret) { - gemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); + qemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); } #endif =20 @@ -751,15 +756,15 @@ print_syscall_ret_raw(struct syscallname *name, abi_l= ong ret) static void print_syscall_ret_newselect(const struct syscallname *name, abi_long ret) { - gemu_log(" =3D 0x" TARGET_ABI_FMT_lx " (", ret); + qemu_log(" =3D 0x" TARGET_ABI_FMT_lx " (", ret); print_fdset(newselect_arg1,newselect_arg2); - gemu_log(","); + qemu_log(","); print_fdset(newselect_arg1,newselect_arg3); - gemu_log(","); + qemu_log(","); print_fdset(newselect_arg1,newselect_arg4); - gemu_log(","); + qemu_log(","); print_timeval(newselect_arg5, 1); - gemu_log(")\n"); + qemu_log(")\n"); } #endif =20 @@ -775,38 +780,38 @@ print_syscall_ret_adjtimex(const struct syscallname *= name, abi_long ret) { const char *errstr =3D NULL; =20 - gemu_log(" =3D "); + qemu_log(" =3D "); if (ret < 0) { - gemu_log("-1 errno=3D%d", errno); + qemu_log("-1 errno=3D%d", errno); errstr =3D target_strerror(-ret); if (errstr) { - gemu_log(" (%s)", errstr); + qemu_log(" (%s)", errstr); } } else { - gemu_log(TARGET_ABI_FMT_ld, ret); + qemu_log(TARGET_ABI_FMT_ld, ret); switch (ret) { case TARGET_TIME_OK: - gemu_log(" TIME_OK (clock synchronized, no leap second)"); + qemu_log(" TIME_OK (clock synchronized, no leap second)"); break; case TARGET_TIME_INS: - gemu_log(" TIME_INS (insert leap second)"); + qemu_log(" TIME_INS (insert leap second)"); break; case TARGET_TIME_DEL: - gemu_log(" TIME_DEL (delete leap second)"); + qemu_log(" TIME_DEL (delete leap second)"); break; case TARGET_TIME_OOP: - gemu_log(" TIME_OOP (leap second in progress)"); + qemu_log(" TIME_OOP (leap second in progress)"); break; case TARGET_TIME_WAIT: - gemu_log(" TIME_WAIT (leap second has occurred)"); + qemu_log(" TIME_WAIT (leap second has occurred)"); break; case TARGET_TIME_ERROR: - gemu_log(" TIME_ERROR (clock not synchronized)"); + qemu_log(" TIME_ERROR (clock not synchronized)"); break; } } =20 - gemu_log("\n"); + qemu_log("\n"); } =20 UNUSED static struct flags access_flags[] =3D { @@ -1104,12 +1109,12 @@ print_flags(const struct flags *f, abi_long flags, = int last) int n; =20 if ((flags =3D=3D 0) && (f->f_value =3D=3D 0)) { - gemu_log("%s%s", f->f_string, get_comma(last)); + qemu_log("%s%s", f->f_string, get_comma(last)); return; } for (n =3D 0; f->f_string !=3D NULL; f++) { if ((f->f_value !=3D 0) && ((flags & f->f_value) =3D=3D f->f_value= )) { - gemu_log("%s%s", sep, f->f_string); + qemu_log("%s%s", sep, f->f_string); flags &=3D ~f->f_value; sep =3D "|"; n++; @@ -1119,13 +1124,13 @@ print_flags(const struct flags *f, abi_long flags, = int last) if (n > 0) { /* print rest of the flags as numeric */ if (flags !=3D 0) { - gemu_log("%s%#x%s", sep, (unsigned int)flags, get_comma(last)); + qemu_log("%s%#x%s", sep, (unsigned int)flags, get_comma(last)); } else { - gemu_log("%s", get_comma(last)); + qemu_log("%s", get_comma(last)); } } else { /* no string version of flags found, print them in hex then */ - gemu_log("%#x%s", (unsigned int)flags, get_comma(last)); + qemu_log("%#x%s", (unsigned int)flags, get_comma(last)); } } =20 @@ -1134,11 +1139,11 @@ print_at_dirfd(abi_long dirfd, int last) { #ifdef AT_FDCWD if (dirfd =3D=3D AT_FDCWD) { - gemu_log("AT_FDCWD%s", get_comma(last)); + qemu_log("AT_FDCWD%s", get_comma(last)); return; } #endif - gemu_log("%d%s", (int)dirfd, get_comma(last)); + qemu_log("%d%s", (int)dirfd, get_comma(last)); } =20 static void @@ -1149,7 +1154,7 @@ print_file_mode(abi_long mode, int last) =20 for (m =3D &mode_flags[0]; m->f_string !=3D NULL; m++) { if ((m->f_value & mode) =3D=3D m->f_value) { - gemu_log("%s%s", m->f_string, sep); + qemu_log("%s%s", m->f_string, sep); sep =3D "|"; mode &=3D ~m->f_value; break; @@ -1159,9 +1164,9 @@ print_file_mode(abi_long mode, int last) mode &=3D ~S_IFMT; /* print rest of the mode as octal */ if (mode !=3D 0) - gemu_log("%s%#o", sep, (unsigned int)mode); + qemu_log("%s%#o", sep, (unsigned int)mode); =20 - gemu_log("%s", get_comma(last)); + qemu_log("%s", get_comma(last)); } =20 static void @@ -1170,17 +1175,17 @@ print_open_flags(abi_long flags, int last) print_flags(open_access_flags, flags & TARGET_O_ACCMODE, 1); flags &=3D ~TARGET_O_ACCMODE; if (flags =3D=3D 0) { - gemu_log("%s", get_comma(last)); + qemu_log("%s", get_comma(last)); return; } - gemu_log("|"); + qemu_log("|"); print_flags(open_flags, flags, last); } =20 static void print_syscall_prologue(const struct syscallname *sc) { - gemu_log("%s(", sc->name); + qemu_log("%s(", sc->name); } =20 /*ARGSUSED*/ @@ -1188,7 +1193,7 @@ static void print_syscall_epilogue(const struct syscallname *sc) { (void)sc; - gemu_log(")"); + qemu_log(")"); } =20 static void @@ -1197,7 +1202,7 @@ print_string(abi_long addr, int last) char *s; =20 if ((s =3D lock_user_string(addr)) !=3D NULL) { - gemu_log("\"%s\"%s", s, get_comma(last)); + qemu_log("\"%s\"%s", s, get_comma(last)); unlock_user(s, addr, 0); } else { /* can't get string out of it, so print it as pointer */ @@ -1214,20 +1219,20 @@ print_buf(abi_long addr, abi_long len, int last) =20 s =3D lock_user(VERIFY_READ, addr, len, 1); if (s) { - gemu_log("\""); + qemu_log("\""); for (i =3D 0; i < MAX_PRINT_BUF && i < len; i++) { if (isprint(s[i])) { - gemu_log("%c", s[i]); + qemu_log("%c", s[i]); } else { - gemu_log("\\%o", s[i]); + qemu_log("\\%o", s[i]); } } - gemu_log("\""); + qemu_log("\""); if (i !=3D len) { - gemu_log("..."); + qemu_log("..."); } if (!last) { - gemu_log(","); + qemu_log(","); } unlock_user(s, addr, 0); } else { @@ -1245,16 +1250,16 @@ print_raw_param(const char *fmt, abi_long param, in= t last) char format[64]; =20 (void) snprintf(format, sizeof (format), "%s%s", fmt, get_comma(last)); - gemu_log(format, param); + qemu_log(format, param); } =20 static void print_pointer(abi_long p, int last) { if (p =3D=3D 0) - gemu_log("NULL%s", get_comma(last)); + qemu_log("NULL%s", get_comma(last)); else - gemu_log("0x" TARGET_ABI_FMT_lx "%s", p, get_comma(last)); + qemu_log("0x" TARGET_ABI_FMT_lx "%s", p, get_comma(last)); } =20 /* @@ -1265,12 +1270,12 @@ static void print_number(abi_long addr, int last) { if (addr =3D=3D 0) { - gemu_log("NULL%s", get_comma(last)); + qemu_log("NULL%s", get_comma(last)); } else { int num; =20 get_user_s32(num, addr); - gemu_log("[%d]%s", num, get_comma(last)); + qemu_log("[%d]%s", num, get_comma(last)); } } =20 @@ -1285,11 +1290,11 @@ print_timeval(abi_ulong tv_addr, int last) print_pointer(tv_addr, last); return; } - gemu_log("{" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "}%s", + qemu_log("{" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "}%s", tswapal(tv->tv_sec), tswapal(tv->tv_usec), get_comma(last)); unlock_user(tv, tv_addr, 0); } else - gemu_log("NULL%s", get_comma(last)); + qemu_log("NULL%s", get_comma(last)); } =20 static void @@ -1303,11 +1308,11 @@ print_timezone(abi_ulong tz_addr, int last) print_pointer(tz_addr, last); return; } - gemu_log("{%d,%d}%s", tswap32(tz->tz_minuteswest), + qemu_log("{%d,%d}%s", tswap32(tz->tz_minuteswest), tswap32(tz->tz_dsttime), get_comma(last)); unlock_user(tz, tz_addr, 0); } else { - gemu_log("NULL%s", get_comma(last)); + qemu_log("NULL%s", get_comma(last)); } } =20 @@ -1515,83 +1520,83 @@ print_fcntl(const struct syscallname *name, print_raw_param("%d", arg0, 0); switch(arg1) { case TARGET_F_DUPFD: - gemu_log("F_DUPFD,"); + qemu_log("F_DUPFD,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 1); break; case TARGET_F_GETFD: - gemu_log("F_GETFD"); + qemu_log("F_GETFD"); break; case TARGET_F_SETFD: - gemu_log("F_SETFD,"); + qemu_log("F_SETFD,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 1); break; case TARGET_F_GETFL: - gemu_log("F_GETFL"); + qemu_log("F_GETFL"); break; case TARGET_F_SETFL: - gemu_log("F_SETFL,"); + qemu_log("F_SETFL,"); print_open_flags(arg2, 1); break; case TARGET_F_GETLK: - gemu_log("F_GETLK,"); + qemu_log("F_GETLK,"); print_pointer(arg2, 1); break; case TARGET_F_SETLK: - gemu_log("F_SETLK,"); + qemu_log("F_SETLK,"); print_pointer(arg2, 1); break; case TARGET_F_SETLKW: - gemu_log("F_SETLKW,"); + qemu_log("F_SETLKW,"); print_pointer(arg2, 1); break; case TARGET_F_GETOWN: - gemu_log("F_GETOWN"); + qemu_log("F_GETOWN"); break; case TARGET_F_SETOWN: - gemu_log("F_SETOWN,"); + qemu_log("F_SETOWN,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 0); break; case TARGET_F_GETSIG: - gemu_log("F_GETSIG"); + qemu_log("F_GETSIG"); break; case TARGET_F_SETSIG: - gemu_log("F_SETSIG,"); + qemu_log("F_SETSIG,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 0); break; #if TARGET_ABI_BITS =3D=3D 32 case TARGET_F_GETLK64: - gemu_log("F_GETLK64,"); + qemu_log("F_GETLK64,"); print_pointer(arg2, 1); break; case TARGET_F_SETLK64: - gemu_log("F_SETLK64,"); + qemu_log("F_SETLK64,"); print_pointer(arg2, 1); break; case TARGET_F_SETLKW64: - gemu_log("F_SETLKW64,"); + qemu_log("F_SETLKW64,"); print_pointer(arg2, 1); break; #endif case TARGET_F_SETLEASE: - gemu_log("F_SETLEASE,"); + qemu_log("F_SETLEASE,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 0); break; case TARGET_F_GETLEASE: - gemu_log("F_GETLEASE"); + qemu_log("F_GETLEASE"); break; case TARGET_F_SETPIPE_SZ: - gemu_log("F_SETPIPE_SZ,"); + qemu_log("F_SETPIPE_SZ,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 1); break; case TARGET_F_GETPIPE_SZ: - gemu_log("F_GETPIPE_SZ"); + qemu_log("F_GETPIPE_SZ"); break; case TARGET_F_DUPFD_CLOEXEC: - gemu_log("F_DUPFD_CLOEXEC,"); + qemu_log("F_DUPFD_CLOEXEC,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 1); break; case TARGET_F_NOTIFY: - gemu_log("F_NOTIFY,"); + qemu_log("F_NOTIFY,"); print_raw_param(TARGET_ABI_FMT_ld, arg2, 0); break; default: @@ -1679,7 +1684,7 @@ print__llseek(const struct syscallname *name, case SEEK_CUR: whence =3D "SEEK_CUR"; break; case SEEK_END: whence =3D "SEEK_END"; break; } - gemu_log("%s",whence); + qemu_log("%s", whence); print_syscall_epilogue(name); } #endif @@ -1694,9 +1699,9 @@ print_socket(const struct syscallname *name, =20 print_syscall_prologue(name); print_socket_domain(domain); - gemu_log(","); + qemu_log(","); print_socket_type(type); - gemu_log(","); + qemu_log(","); if (domain =3D=3D AF_PACKET || (domain =3D=3D AF_INET && type =3D=3D TARGET_SOCK_PACKET)) { protocol =3D tswap16(protocol); @@ -1728,17 +1733,17 @@ static void do_print_socket(const char *name, abi_l= ong arg1) get_user_ualx(domain, arg1, 0); get_user_ualx(type, arg1, 1); get_user_ualx(protocol, arg1, 2); - gemu_log("%s(", name); + qemu_log("%s(", name); print_socket_domain(domain); - gemu_log(","); + qemu_log(","); print_socket_type(type); - gemu_log(","); + qemu_log(","); if (domain =3D=3D AF_PACKET || (domain =3D=3D AF_INET && type =3D=3D TARGET_SOCK_PACKET)) { protocol =3D tswap16(protocol); } print_socket_protocol(domain, type, protocol); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_sockaddr(const char *name, abi_long arg1) @@ -1749,10 +1754,10 @@ static void do_print_sockaddr(const char *name, abi= _long arg1) get_user_ualx(addr, arg1, 1); get_user_ualx(addrlen, arg1, 2); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_sockfd(sockfd, 0); print_sockaddr(addr, addrlen, 0); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_listen(const char *name, abi_long arg1) @@ -1762,10 +1767,10 @@ static void do_print_listen(const char *name, abi_l= ong arg1) get_user_ualx(sockfd, arg1, 0); get_user_ualx(backlog, arg1, 1); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_sockfd(sockfd, 0); print_raw_param(TARGET_ABI_FMT_ld, backlog, 1); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_socketpair(const char *name, abi_long arg1) @@ -1777,15 +1782,15 @@ static void do_print_socketpair(const char *name, a= bi_long arg1) get_user_ualx(protocol, arg1, 2); get_user_ualx(tab, arg1, 3); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_socket_domain(domain); - gemu_log(","); + qemu_log(","); print_socket_type(type); - gemu_log(","); + qemu_log(","); print_socket_protocol(domain, type, protocol); - gemu_log(","); + qemu_log(","); print_raw_param(TARGET_ABI_FMT_lx, tab, 1); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_sendrecv(const char *name, abi_long arg1) @@ -1797,12 +1802,12 @@ static void do_print_sendrecv(const char *name, abi= _long arg1) get_user_ualx(len, arg1, 2); get_user_ualx(flags, arg1, 3); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_sockfd(sockfd, 0); print_buf(msg, len, 0); print_raw_param(TARGET_ABI_FMT_ld, len, 0); print_flags(msg_flags, flags, 1); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_msgaddr(const char *name, abi_long arg1) @@ -1816,13 +1821,13 @@ static void do_print_msgaddr(const char *name, abi_= long arg1) get_user_ualx(addr, arg1, 4); get_user_ualx(addrlen, arg1, 5); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_sockfd(sockfd, 0); print_buf(msg, len, 0); print_raw_param(TARGET_ABI_FMT_ld, len, 0); print_flags(msg_flags, flags, 0); print_sockaddr(addr, addrlen, 0); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_shutdown(const char *name, abi_long arg1) @@ -1832,23 +1837,23 @@ static void do_print_shutdown(const char *name, abi= _long arg1) get_user_ualx(sockfd, arg1, 0); get_user_ualx(how, arg1, 1); =20 - gemu_log("shutdown("); + qemu_log("shutdown("); print_sockfd(sockfd, 0); switch (how) { case SHUT_RD: - gemu_log("SHUT_RD"); + qemu_log("SHUT_RD"); break; case SHUT_WR: - gemu_log("SHUT_WR"); + qemu_log("SHUT_WR"); break; case SHUT_RDWR: - gemu_log("SHUT_RDWR"); + qemu_log("SHUT_RDWR"); break; default: print_raw_param(TARGET_ABI_FMT_ld, how, 1); break; } - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_msg(const char *name, abi_long arg1) @@ -1859,11 +1864,11 @@ static void do_print_msg(const char *name, abi_long= arg1) get_user_ualx(msg, arg1, 1); get_user_ualx(flags, arg1, 2); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_sockfd(sockfd, 0); print_pointer(msg, 0); print_flags(msg_flags, flags, 1); - gemu_log(")"); + qemu_log(")"); } =20 static void do_print_sockopt(const char *name, abi_long arg1) @@ -1876,113 +1881,113 @@ static void do_print_sockopt(const char *name, ab= i_long arg1) get_user_ualx(optval, arg1, 3); get_user_ualx(optlen, arg1, 4); =20 - gemu_log("%s(", name); + qemu_log("%s(", name); print_sockfd(sockfd, 0); switch (level) { case SOL_TCP: - gemu_log("SOL_TCP,"); + qemu_log("SOL_TCP,"); print_raw_param(TARGET_ABI_FMT_ld, optname, 0); print_pointer(optval, 0); break; case SOL_IP: - gemu_log("SOL_IP,"); + qemu_log("SOL_IP,"); print_raw_param(TARGET_ABI_FMT_ld, optname, 0); print_pointer(optval, 0); break; case SOL_RAW: - gemu_log("SOL_RAW,"); + qemu_log("SOL_RAW,"); print_raw_param(TARGET_ABI_FMT_ld, optname, 0); print_pointer(optval, 0); break; case TARGET_SOL_SOCKET: - gemu_log("SOL_SOCKET,"); + qemu_log("SOL_SOCKET,"); switch (optname) { case TARGET_SO_DEBUG: - gemu_log("SO_DEBUG,"); + qemu_log("SO_DEBUG,"); print_optint: print_number(optval, 0); break; case TARGET_SO_REUSEADDR: - gemu_log("SO_REUSEADDR,"); + qemu_log("SO_REUSEADDR,"); goto print_optint; case TARGET_SO_REUSEPORT: - gemu_log("SO_REUSEPORT,"); + qemu_log("SO_REUSEPORT,"); goto print_optint; case TARGET_SO_TYPE: - gemu_log("SO_TYPE,"); + qemu_log("SO_TYPE,"); goto print_optint; case TARGET_SO_ERROR: - gemu_log("SO_ERROR,"); + qemu_log("SO_ERROR,"); goto print_optint; case TARGET_SO_DONTROUTE: - gemu_log("SO_DONTROUTE,"); + qemu_log("SO_DONTROUTE,"); goto print_optint; case TARGET_SO_BROADCAST: - gemu_log("SO_BROADCAST,"); + qemu_log("SO_BROADCAST,"); goto print_optint; case TARGET_SO_SNDBUF: - gemu_log("SO_SNDBUF,"); + qemu_log("SO_SNDBUF,"); goto print_optint; case TARGET_SO_RCVBUF: - gemu_log("SO_RCVBUF,"); + qemu_log("SO_RCVBUF,"); goto print_optint; case TARGET_SO_KEEPALIVE: - gemu_log("SO_KEEPALIVE,"); + qemu_log("SO_KEEPALIVE,"); goto print_optint; case TARGET_SO_OOBINLINE: - gemu_log("SO_OOBINLINE,"); + qemu_log("SO_OOBINLINE,"); goto print_optint; case TARGET_SO_NO_CHECK: - gemu_log("SO_NO_CHECK,"); + qemu_log("SO_NO_CHECK,"); goto print_optint; case TARGET_SO_PRIORITY: - gemu_log("SO_PRIORITY,"); + qemu_log("SO_PRIORITY,"); goto print_optint; case TARGET_SO_BSDCOMPAT: - gemu_log("SO_BSDCOMPAT,"); + qemu_log("SO_BSDCOMPAT,"); goto print_optint; case TARGET_SO_PASSCRED: - gemu_log("SO_PASSCRED,"); + qemu_log("SO_PASSCRED,"); goto print_optint; case TARGET_SO_TIMESTAMP: - gemu_log("SO_TIMESTAMP,"); + qemu_log("SO_TIMESTAMP,"); goto print_optint; case TARGET_SO_RCVLOWAT: - gemu_log("SO_RCVLOWAT,"); + qemu_log("SO_RCVLOWAT,"); goto print_optint; case TARGET_SO_RCVTIMEO: - gemu_log("SO_RCVTIMEO,"); + qemu_log("SO_RCVTIMEO,"); print_timeval(optval, 0); break; case TARGET_SO_SNDTIMEO: - gemu_log("SO_SNDTIMEO,"); + qemu_log("SO_SNDTIMEO,"); print_timeval(optval, 0); break; case TARGET_SO_ATTACH_FILTER: { struct target_sock_fprog *fprog; =20 - gemu_log("SO_ATTACH_FILTER,"); + qemu_log("SO_ATTACH_FILTER,"); =20 if (lock_user_struct(VERIFY_READ, fprog, optval, 0)) { struct target_sock_filter *filter; - gemu_log("{"); + qemu_log("{"); if (lock_user_struct(VERIFY_READ, filter, tswapal(fprog->filter), 0)) { int i; for (i =3D 0; i < tswap16(fprog->len) - 1; i++) { - gemu_log("[%d]{0x%x,%d,%d,0x%x},", + qemu_log("[%d]{0x%x,%d,%d,0x%x},", i, tswap16(filter[i].code), filter[i].jt, filter[i].jf, tswap32(filter[i].k)); } - gemu_log("[%d]{0x%x,%d,%d,0x%x}", + qemu_log("[%d]{0x%x,%d,%d,0x%x}", i, tswap16(filter[i].code), filter[i].jt, filter[i].jf, tswap32(filter[i].k)); } else { - gemu_log(TARGET_ABI_FMT_lx, tswapal(fprog->filter)); + qemu_log(TARGET_ABI_FMT_lx, tswapal(fprog->filter)); } - gemu_log(",%d},", tswap16(fprog->len)); + qemu_log(",%d},", tswap16(fprog->len)); unlock_user(fprog, optval, 0); } else { print_pointer(optval, 0); @@ -2002,7 +2007,7 @@ print_optint: break; } print_raw_param(TARGET_ABI_FMT_ld, optlen, 1); - gemu_log(")"); + qemu_log(")"); } =20 #define PRINT_SOCKOP(name, func) \ @@ -2164,7 +2169,7 @@ print_rt_sigprocmask(const struct syscallname *name, case TARGET_SIG_UNBLOCK: how =3D "SIG_UNBLOCK"; break; case TARGET_SIG_SETMASK: how =3D "SIG_SETMASK"; break; } - gemu_log("%s,",how); + qemu_log("%s,", how); print_pointer(arg1, 0); print_pointer(arg2, 1); print_syscall_epilogue(name); @@ -2278,7 +2283,7 @@ print_syslog_action(abi_ulong arg, int last) return; } } - gemu_log("%s%s", type, get_comma(last)); + qemu_log("%s%s", type, get_comma(last)); } =20 static void @@ -2683,20 +2688,20 @@ static void print_futex_op(abi_long tflag, int last) { #define print_op(val) \ if( cmd =3D=3D val ) { \ - gemu_log(#val); \ + qemu_log(#val); \ return; \ } =20 int cmd =3D (int)tflag; #ifdef FUTEX_PRIVATE_FLAG if (cmd & FUTEX_PRIVATE_FLAG) { - gemu_log("FUTEX_PRIVATE_FLAG|"); + qemu_log("FUTEX_PRIVATE_FLAG|"); cmd &=3D ~FUTEX_PRIVATE_FLAG; } #endif #ifdef FUTEX_CLOCK_REALTIME if (cmd & FUTEX_CLOCK_REALTIME) { - gemu_log("FUTEX_CLOCK_REALTIME|"); + qemu_log("FUTEX_CLOCK_REALTIME|"); cmd &=3D ~FUTEX_CLOCK_REALTIME; } #endif @@ -2716,7 +2721,7 @@ if( cmd =3D=3D val ) { \ print_op(FUTEX_WAKE_BITSET) #endif /* unknown values */ - gemu_log("%d",cmd); + qemu_log("%d", cmd); } =20 static void @@ -2812,22 +2817,24 @@ print_syscall(int num, int i; const char *format=3D"%s(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ","= TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "," TARGET_A= BI_FMT_ld ")"; =20 - gemu_log("%d ", getpid() ); + qemu_log("%d ", getpid()); =20 for(i=3D0;i (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578971017830363.0587809033; Mon, 13 Jan 2020 19:03:37 -0800 (PST) Received: from localhost ([::1]:58632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irCUS-0005wN-Ik for importer@patchew.org; Mon, 13 Jan 2020 22:03:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54220) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <3Qy8dXgMKCg4xyDu22uzs.q204s08-rs9sz121u18.25u@flex--jkz.bounces.google.com>) id 1irCTO-0004ov-8Z for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3Qy8dXgMKCg4xyDu22uzs.q204s08-rs9sz121u18.25u@flex--jkz.bounces.google.com>) id 1irCTM-0000wW-W6 for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:30 -0500 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]:42946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <3Qy8dXgMKCg4xyDu22uzs.q204s08-rs9sz121u18.25u@flex--jkz.bounces.google.com>) id 1irCTM-0000vA-Qc for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:28 -0500 Received: by mail-pl1-x649.google.com with SMTP id b4so4427492plr.9 for ; Mon, 13 Jan 2020 19:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=3/g1o8RhSPCGsbPDNuvg/1lJsdGuvn96YgC53DZHyWw=; b=tDCPG2VSPNat9zq2qB50z6NSON2Z3KdStdEwMQypP/ijBHlHHC0e88njq8MimO9/fL 3Gjll88y34y7IwtymYRWlqz87O5JOxKbjMztmYhbjNSjWq7vcxub5P6bQCaX+fGiO62H 9FxgVh2aUl31RYVc+UWVc14fpaeRTHcE5369Jbx/9bEjzWodiGr/p6ekGrjMku/K8EvB oUHfVrd2awptmcwp+TYQH4O8v+W4Q1duf8Nn3CwoIRI2IxAqWJiMWF4X4k4ezEkfCXJF ZPdkD2sfODVCDe4zMGihhukb4coTkn0EnSSH6alXvBOO7qpDMrzKbVt1w3s8K/S4W+3j 6I9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=3/g1o8RhSPCGsbPDNuvg/1lJsdGuvn96YgC53DZHyWw=; b=aX2gHUg20BBhc53HN6h1HGmEURByLkAkIqP9Dvm6EyfA70VWkiOqAdDYg1Dba8gi4i nfUc8Li5Q7tEnwQjXuWRmVmVp3n/l/upXe1xacVCGlvi3o1vplym1PBdQ5AUd6/a3BLQ GpULWyDz08HYDSkj5Kf3zdsdRplSgBxmqsLuQQTAhojVwYGYcMNqgMAFfr/TH/6s9tMZ GZ8UrzkIBrVfT3mAwF5pnxf5PB93aHgHigNPnxbxIyxCA3+FbeqLt0qWzFEj3/NdC4qE 73Bu5LjYKF4nxerUBSFOEuzWB58oa5WveNAl31WHJF0GSbnzGIGea9qdDP0nHlrrF50x 6+HA== X-Gm-Message-State: APjAAAVV3Hbcrk7Y+/5R1x6ys0TmvlgX2OW6UXieSXB4DBLEVUER9DfE cdts0FN+YvkRfkLVf/8kKoTVrueel+PIxWujGMGtVL7y7Laq2UkjzMAhwcAhZYjzuijtA7D4QRs gp8F3OtWxBcbVFPVNaXX//xGJD2ksYXiOMFMuvxN/iEpo7MH3FY3K X-Google-Smtp-Source: APXvYqzXn3r9wSIe8/WzpbWxsCwxyjePh7iDQ2u4MHY8Uaj0PqA2azRJW5dzl9u+Y5B80aDUKSsoLKw= X-Received: by 2002:a63:1110:: with SMTP id g16mr23843048pgl.84.1578970947241; Mon, 13 Jan 2020 19:02:27 -0800 (PST) Date: Mon, 13 Jan 2020 19:01:37 -0800 In-Reply-To: <20200114030138.260347-1-jkz@google.com> Message-Id: <20200114030138.260347-4-jkz@google.com> Mime-Version: 1.0 References: <20200114030138.260347-1-jkz@google.com> X-Mailer: git-send-email 2.25.0.rc1.283.g88dfdc4193-goog Subject: [PATCH 3/4] linux-user: remove gemu_log from the linux-user tree From: Josh Kunz To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi, laurent@vivier.eu, alex.bennee@linaro.org, armbru@redhat.com, Josh Kunz X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::649 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that all uses have been migrated to `qemu_log' it is no longer needed. Signed-off-by: Josh Kunz Reviewed-by: Alex Benn=C3=A9e --- linux-user/main.c | 9 --------- linux-user/qemu.h | 1 - 2 files changed, 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 0bf40c4d27..945b6adf3a 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -108,15 +108,6 @@ const char *qemu_uname_release; by remapping the process stack directly at the right place */ unsigned long guest_stack_size =3D 8 * 1024 * 1024UL; =20 -void gemu_log(const char *fmt, ...) -{ - va_list ap; - - va_start(ap, fmt); - vfprintf(stderr, fmt, ap); - va_end(ap); -} - #if defined(TARGET_I386) int cpu_get_pic_interrupt(CPUX86State *env) { diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 02c6890c8a..329b409e65 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -210,7 +210,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long ar= g1, abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6, abi_long arg7, abi_long arg8); -void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2); extern __thread CPUState *thread_cpu; void cpu_loop(CPUArchState *env); const char *target_strerror(int err); --=20 2.25.0.rc1.283.g88dfdc4193-goog From nobody Wed Apr 24 04:09:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1578971189; cv=none; d=zohomail.com; s=zohoarc; b=m1ovgFwk2lndri5GyjA9wAB8ijdqkaJD0cXzZflhfggESBOuxhQff2beBY3VV9ql5iGo8uVmLN3ezhWL6vkp4JPBj9cIRzbdlUon6KMMMPPfEfk/dHteyidQvQ0feMGiqyCZ+yFF2J/hy8wvLBz497/SxoDNZkc0CBmPa6D16V0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578971189; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=q7n2mu/O/iU2pd48BW5jqVfwlCDPfPKtfKm+vp2zkyw=; b=C78hcH2SBFGR5HX0R1DxjZok/TfEcrfdepQeRtVcp6fle8bNN6vKEBs328cctf17kgryulvSUpm7UaCoc8IWaPTEjcRQz6svPI0Lf4XDRhlx8w23wcmAeJmTVDok9yZSNMBt3U84ndbI6V/QxoyMC0m1HIzIY5ihVYaeZRAOa7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157897118930610.632741150533661; Mon, 13 Jan 2020 19:06:29 -0800 (PST) Received: from localhost ([::1]:58664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irCXE-000139-3J for importer@patchew.org; Mon, 13 Jan 2020 22:06:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54245) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <3RS8dXgMKChAz0Fw44w1u.s426u2A-tuBu1343w3A.47w@flex--jkz.bounces.google.com>) id 1irCTQ-0004sC-TN for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3RS8dXgMKChAz0Fw44w1u.s426u2A-tuBu1343w3A.47w@flex--jkz.bounces.google.com>) id 1irCTP-0000zf-4X for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:32 -0500 Received: from mail-ua1-x94a.google.com ([2607:f8b0:4864:20::94a]:55931) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <3RS8dXgMKChAz0Fw44w1u.s426u2A-tuBu1343w3A.47w@flex--jkz.bounces.google.com>) id 1irCTO-0000yW-Vy for qemu-devel@nongnu.org; Mon, 13 Jan 2020 22:02:31 -0500 Received: by mail-ua1-x94a.google.com with SMTP id 71so1808977uae.22 for ; Mon, 13 Jan 2020 19:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=q7n2mu/O/iU2pd48BW5jqVfwlCDPfPKtfKm+vp2zkyw=; b=sPcaOMFyh+jeV3vpTZonODNTc6X6hyzMdxpou/TVg0UMXsyvGWn7T8rAthNQCtwv8Y 6qO+I1+Cd8n1vJCCYqfQb7jnVsrhbajWk/hR2VvmCTD2dhQhiVJgzdKv7H7D9hSN1ThW rkrhDxBRU4Z51yCqM6z93KUui2dLrKlbSLbbTxFPzYW7Xq5+kjoUBW5vqr58BCtDe51n S7TmdtczZA9GL4HdrqDAUi/xyPY8MC/t4wrmO6mQInQ3LO6Q8WaLFhzYTJ6NjeAe0pUG K4XYgqpEbgbbcZFZ2Eu6vWNrpQGB6R3fsqLjiZLGP5SP+fPFqgdbOXTmGcwLugOMbO97 l0Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=q7n2mu/O/iU2pd48BW5jqVfwlCDPfPKtfKm+vp2zkyw=; b=AqGNzvGm78eRULj2mEKvIgvSkoDVL0w28paEekLdztNR0aKYajYGZ0NY0pXLbBHfr6 p2RPlXPJ1+LbPYNRzK0ZzAXe8FVJhRb6mHtvPxEhitD5k0ObHp6gZTxDkGUZTzqBgo8b 6FudZDAkAM4yDmOwhRABOwNNorNOyYSXxpij3eHP3YPzh8jq0KSpT5qmBuAaZQ1rEJ1L TJSPSC7XkSqVocM+l3NnUUjYbJKToFHMK7uDMiJol42Qavz5fEKuwpbKujF3P+BUOV9r mAbaIrvmorVuyHbtWKBsdyP+AQM1VvJk3qEwc80Uu2cisDetmMxpWhYgffcOKISN9wXF DcaQ== X-Gm-Message-State: APjAAAXZBSpUY/YWPZ/6iWcKi2aYqwlB+67UCRkJx8BZco07Fbnyn3Sv Nens+yHqQRqcqyE9rxdfKPMOU/vL9xSAqqebtsu8ClUwvh14QyvpQaz+X3ulfP2kqNX93XUxnxq ZWbcousjPXscW5y7pbvNsIxX12Q6OuDqQa5frURzLoGskLqCfbIe0 X-Google-Smtp-Source: APXvYqwrrZL2eaqJ2smYESOxaovHkO0F4c+tuBzSCjA3QlSBDLXgyuXFnyyDGCz8aFcFXfb0uOzLv2w= X-Received: by 2002:a1f:d583:: with SMTP id m125mr9286012vkg.17.1578970949827; Mon, 13 Jan 2020 19:02:29 -0800 (PST) Date: Mon, 13 Jan 2020 19:01:38 -0800 In-Reply-To: <20200114030138.260347-1-jkz@google.com> Message-Id: <20200114030138.260347-5-jkz@google.com> Mime-Version: 1.0 References: <20200114030138.260347-1-jkz@google.com> X-Mailer: git-send-email 2.25.0.rc1.283.g88dfdc4193-goog Subject: [PATCH 4/4] bsd-user: Replace gemu_log with qemu_log From: Josh Kunz To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi, laurent@vivier.eu, alex.bennee@linaro.org, armbru@redhat.com, Josh Kunz X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::94a X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gemu_log is an old logging mechanism used to implement strace logging in the bsd-user tree. It logs directly to stderr and cannot easily be redirected. This change instead causes strace to log via the qemu_log subsystem which has fine-grained logging control, and a centralized mechanism for log redirection. bsd-user does not currently implement any logging redirection options, or log masking options, but this change brings it more in line with the linux-user tree. Signed-off-by: Josh Kunz --- bsd-user/main.c | 13 ++----------- bsd-user/qemu.h | 2 -- bsd-user/strace.c | 32 +++++++++++++++----------------- bsd-user/syscall.c | 31 +++++++++++++++++++------------ 4 files changed, 36 insertions(+), 42 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 7f4e3cd627..e726b0a7fb 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -55,15 +55,6 @@ enum BSDType bsd_type; by remapping the process stack directly at the right place */ unsigned long x86_stack_size =3D 512 * 1024; =20 -void gemu_log(const char *fmt, ...) -{ - va_list ap; - - va_start(ap, fmt); - vfprintf(stderr, fmt, ap); - va_end(ap); -} - #if defined(TARGET_I386) int cpu_get_pic_interrupt(CPUX86State *env) { @@ -845,7 +836,7 @@ int main(int argc, char **argv) } else if (!strcmp(r, "singlestep")) { singlestep =3D 1; } else if (!strcmp(r, "strace")) { - do_strace =3D 1; + qemu_add_log(LOG_STRACE); } else if (!strcmp(r, "trace")) { g_free(trace_file); trace_file =3D trace_opt_parse(optarg); @@ -917,7 +908,7 @@ int main(int argc, char **argv) thread_cpu =3D cpu; =20 if (getenv("QEMU_STRACE")) { - do_strace =3D 1; + qemu_add_log(LOG_STRACE); } =20 target_environ =3D envlist_to_environ(envlist, NULL); diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 09e8aed9c7..5762e3a6e5 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -152,7 +152,6 @@ abi_long do_netbsd_syscall(void *cpu_env, int num, abi_= long arg1, abi_long do_openbsd_syscall(void *cpu_env, int num, abi_long arg1, abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6); -void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2); extern THREAD CPUState *thread_cpu; void cpu_loop(CPUArchState *env); char *target_strerror(int err); @@ -188,7 +187,6 @@ print_openbsd_syscall(int num, abi_long arg1, abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6); void print_openbsd_syscall_ret(int num, abi_long ret); -extern int do_strace; =20 /* signal.c */ void process_pending_signals(CPUArchState *cpu_env); diff --git a/bsd-user/strace.c b/bsd-user/strace.c index fa66fe1ee2..6ee1510555 100644 --- a/bsd-user/strace.c +++ b/bsd-user/strace.c @@ -23,8 +23,6 @@ =20 #include "qemu.h" =20 -int do_strace; - /* * Utility functions */ @@ -36,17 +34,17 @@ static void print_sysctl(const struct syscallname *name= , abi_long arg1, uint32_t i; int32_t *namep; =20 - gemu_log("%s({ ", name->name); + qemu_log("%s({ ", name->name); namep =3D lock_user(VERIFY_READ, arg1, sizeof(int32_t) * arg2, 1); if (namep) { int32_t *p =3D namep; =20 for (i =3D 0; i < (uint32_t)arg2; i++) { - gemu_log("%d ", tswap32(*p++)); + qemu_log("%d ", tswap32(*p++)); } unlock_user(namep, arg1, 0); } - gemu_log("}, %u, 0x" TARGET_ABI_FMT_lx ", 0x" TARGET_ABI_FMT_lx ", 0x" + qemu_log("}, %u, 0x" TARGET_ABI_FMT_lx ", 0x" TARGET_ABI_FMT_lx ", 0x" TARGET_ABI_FMT_lx ", 0x" TARGET_ABI_FMT_lx ")", (uint32_t)arg2, arg3, arg4, arg5, arg6); } @@ -62,7 +60,7 @@ static void print_execve(const struct syscallname *name, = abi_long arg1, if (s =3D=3D NULL) { return; } - gemu_log("%s(\"%s\",{", name->name, s); + qemu_log("%s(\"%s\",{", name->name, s); unlock_user(s, arg1, 0); =20 for (arg_ptr_addr =3D arg2; ; arg_ptr_addr +=3D sizeof(abi_ulong)) { @@ -78,11 +76,11 @@ static void print_execve(const struct syscallname *name= , abi_long arg1, break; } if ((s =3D lock_user_string(arg_addr))) { - gemu_log("\"%s\",", s); + qemu_log("\"%s\",", s); unlock_user(s, arg_addr, 0); } } - gemu_log("NULL})"); + qemu_log("NULL})"); } =20 static void print_ioctl(const struct syscallname *name, @@ -90,7 +88,7 @@ static void print_ioctl(const struct syscallname *name, abi_long arg5, abi_long arg6) { /* Decode the ioctl request */ - gemu_log("%s(%d, 0x%0lx { IO%s%s GRP:0x%x('%c') CMD:%d LEN:%d }, 0x" + qemu_log("%s(%d, 0x%0lx { IO%s%s GRP:0x%x('%c') CMD:%d LEN:%d }, 0x" TARGET_ABI_FMT_lx ", ...)", name->name, (int)arg1, @@ -111,9 +109,9 @@ static void print_ioctl(const struct syscallname *name, static void print_syscall_ret_addr(const struct syscallname *name, abi_lon= g ret) { if (ret =3D=3D -1) { - gemu_log(" =3D -1 errno=3D%d (%s)\n", errno, strerror(errno)); + qemu_log(" =3D -1 errno=3D%d (%s)\n", errno, strerror(errno)); } else { - gemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); + qemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); } } =20 @@ -121,7 +119,7 @@ static void print_syscall_ret_addr(const struct syscall= name *name, abi_long ret) static void print_syscall_ret_raw(struct syscallname *name, abi_long ret) { - gemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); + qemu_log(" =3D 0x" TARGET_ABI_FMT_lx "\n", ret); } #endif =20 @@ -148,7 +146,7 @@ static void print_syscall(int num, const struct syscall= name *scnames, TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ")"; =20 - gemu_log("%d ", getpid() ); + qemu_log("%d ", getpid()); =20 for (i =3D 0; i < nscnames; i++) { if (scnames[i].nr =3D=3D num) { @@ -161,13 +159,13 @@ static void print_syscall(int num, const struct sysca= llname *scnames, if (scnames[i].format !=3D NULL) { format =3D scnames[i].format; } - gemu_log(format, scnames[i].name, arg1, arg2, arg3, arg4, = arg5, + qemu_log(format, scnames[i].name, arg1, arg2, arg3, arg4, = arg5, arg6); } return; } } - gemu_log("Unknown syscall %d\n", num); + qemu_log("Unknown syscall %d\n", num); } =20 static void print_syscall_ret(int num, abi_long ret, @@ -181,10 +179,10 @@ static void print_syscall_ret(int num, abi_long ret, scnames[i].result(&scnames[i], ret); } else { if (ret < 0) { - gemu_log(" =3D -1 errno=3D" TARGET_ABI_FMT_ld " (%s)\n= ", -ret, + qemu_log(" =3D -1 errno=3D" TARGET_ABI_FMT_ld " (%s)\n= ", -ret, strerror(-ret)); } else { - gemu_log(" =3D " TARGET_ABI_FMT_ld "\n", ret); + qemu_log(" =3D " TARGET_ABI_FMT_ld "\n", ret); } } break; diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 0d45b654bb..53635d183e 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -321,12 +321,13 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, a= bi_long arg1, void *p; =20 #ifdef DEBUG - gemu_log("freebsd syscall %d\n", num); + qemu_log("freebsd syscall %d\n", num); #endif record_syscall_start(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, 0, = 0); =20 - if(do_strace) + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) { print_freebsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); + } =20 switch(num) { case TARGET_FREEBSD_NR_exit: @@ -401,10 +402,12 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, a= bi_long arg1, } fail: #ifdef DEBUG - gemu_log(" =3D %ld\n", ret); + qemu_log(" =3D %ld\n", ret); #endif - if (do_strace) + + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) { print_freebsd_syscall_ret(num, ret); + } =20 record_syscall_return(cpu, num, ret); return ret; @@ -422,13 +425,14 @@ abi_long do_netbsd_syscall(void *cpu_env, int num, ab= i_long arg1, void *p; =20 #ifdef DEBUG - gemu_log("netbsd syscall %d\n", num); + qemu_log("netbsd syscall %d\n", num); #endif =20 record_syscall_start(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, 0, = 0); =20 - if(do_strace) + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) { print_netbsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); + } =20 switch(num) { case TARGET_NETBSD_NR_exit: @@ -480,10 +484,11 @@ abi_long do_netbsd_syscall(void *cpu_env, int num, ab= i_long arg1, } fail: #ifdef DEBUG - gemu_log(" =3D %ld\n", ret); + qemu_log(" =3D %ld\n", ret); #endif - if (do_strace) + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) { print_netbsd_syscall_ret(num, ret); + } =20 record_syscall_return(cpu, num, ret); return ret; @@ -501,13 +506,14 @@ abi_long do_openbsd_syscall(void *cpu_env, int num, a= bi_long arg1, void *p; =20 #ifdef DEBUG - gemu_log("openbsd syscall %d\n", num); + qemu_log("openbsd syscall %d\n", num); #endif =20 record_syscall_start(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, 0, = 0); =20 - if(do_strace) + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) { print_openbsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); + } =20 switch(num) { case TARGET_OPENBSD_NR_exit: @@ -559,10 +565,11 @@ abi_long do_openbsd_syscall(void *cpu_env, int num, a= bi_long arg1, } fail: #ifdef DEBUG - gemu_log(" =3D %ld\n", ret); + qemu_log(" =3D %ld\n", ret); #endif - if (do_strace) + if (unlikely(qemu_loglevel_mask(LOG_STRACE))) { print_openbsd_syscall_ret(num, ret); + } =20 record_syscall_return(cpu, num, ret); return ret; --=20 2.25.0.rc1.283.g88dfdc4193-goog