From nobody Fri Apr 19 12:08:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578937108; cv=none; d=zohomail.com; s=zohoarc; b=Njm06vhgqRNJgXXJ8Y/jUZd8t+k0TusadFNWBXt51Klfgh3TCr9CLyk8uatDDA41z4u1ZVmo38TMUJGwwHS+p5eAVBHTG7XxZnQ6AgMCJcPezB+odUuVQ/bVi/w9OulAQHs553CQfaj4Kmm/vShH5TVh4KJUOv9ZIJOTaf2MgdQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578937108; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WNez6IxU3/7Q9hEtGYz6qTWwUPHKrvmn+EW+Tm1OE9s=; b=I8do8xmbVKLKMGELPDlvUP7uqkY+c9OCksaVYvFuZ0c8JCzEcq3VUxncYYCJFkMAzhzzvgXCw3rgFP2h113mdIXapp0lj5eXn5tpMde6L0xm3GWFu6aZlv4xloAltvCbqctJFCwI7WLvLmiCxjy09NiwH0bQP2thb5jVSqMdON4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578937108687731.3904384127076; Mon, 13 Jan 2020 09:38:28 -0800 (PST) Received: from localhost ([::1]:53686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3fX-0008Cc-2S for importer@patchew.org; Mon, 13 Jan 2020 12:38:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42218) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3e5-0006Wf-Vx for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir3e5-00020C-1u for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:36:57 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:57581 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ir3e4-0001zC-Ug for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:36:57 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-wuh5-3Z2MXyhowKFmj048w-1; Mon, 13 Jan 2020 12:36:55 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BA2C801E72 for ; Mon, 13 Jan 2020 17:36:54 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3345D5C1B0; Mon, 13 Jan 2020 17:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578937016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WNez6IxU3/7Q9hEtGYz6qTWwUPHKrvmn+EW+Tm1OE9s=; b=SEwDcn008NnNG4m5iKEABWtZ3SITHL+DUYTlOO8ZUBXBxw2j3b7Lw8PkluY82kMZk0wc4z oXnPSUvXlUC3cKpeEehSvEqvAQ8esqwIYiwT+un+j4hj6bA0jMvxFTwj6kVd1yrY3BwesC tlkqH0IZ5iq2mNxIuP+Y6ZLDk8JrJ4c= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, vkuznets@redhat.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com Subject: [PATCH v2 1/3] vhost: Add names to section rounded warning Date: Mon, 13 Jan 2020 17:36:45 +0000 Message-Id: <20200113173647.84842-2-dgilbert@redhat.com> In-Reply-To: <20200113173647.84842-1-dgilbert@redhat.com> References: <20200113173647.84842-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: wuh5-3Z2MXyhowKFmj048w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Add the memory region names to section rounding/alignment warnings. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 4da0d5a6c5..774d87d98e 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -590,9 +590,10 @@ static void vhost_region_add_section(struct vhost_dev = *dev, * match up in the same RAMBlock if they do. */ if (mrs_gpa < prev_gpa_start) { - error_report("%s:Section rounded to %"PRIx64 - " prior to previous %"PRIx64, - __func__, mrs_gpa, prev_gpa_start); + error_report("%s:Section '%s' rounded to %"PRIx64 + " prior to previous '%s' %"PRIx64, + __func__, section->mr->name, mrs_gpa, + prev_sec->mr->name, prev_gpa_start); /* A way to cleanly fail here would be better */ return; } --=20 2.24.1 From nobody Fri Apr 19 12:08:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578937219; cv=none; d=zohomail.com; s=zohoarc; b=WYzk28z90Lf2WrCvHCOFBhZmVIoLqN7YEIXbm3DfcwB+sZyaA30yO9cUV0i4ZtgfWfbKAFvxFqq8lnv2lnhNQq2zwzvJlbO/4mW2Kg01jnYZPxcNpxVTHMCOM0Dl0L/qFzlCJ5/j0ox2j3inERPzc8Aj0urqyy07jd264/n/n8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578937219; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n87xPZmTfhj/+IICBXdLr162eK27C7KrFSNvGBgnX6s=; b=ZjNI8Boiv61P4gCJgYgzR5ALzcgA/14nzfsZIoPwSugVclFsOp2xJNgveEOh2APXO/A/fZZrci4XHc7c6FoJm0FRAg7WAkUNEudd10e0V2hz6GlQElMZtrx1HSCMo1D59ez7jYmVx/JWMer6SCbIzTiL+Olw87cWjBB+mJtMpqs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578937219949156.91292206761682; Mon, 13 Jan 2020 09:40:19 -0800 (PST) Received: from localhost ([::1]:53714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3hK-0003ot-SA for importer@patchew.org; Mon, 13 Jan 2020 12:40:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3e7-0006Ws-T7 for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:37:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir3e6-000228-On for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:36:59 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:23324 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ir3e6-00021e-LI for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:36:58 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-178-JcY69k9SNxy8mydbfhAt0A-1; Mon, 13 Jan 2020 12:36:56 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF932107ACC5 for ; Mon, 13 Jan 2020 17:36:55 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id A85745C1B0; Mon, 13 Jan 2020 17:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578937018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n87xPZmTfhj/+IICBXdLr162eK27C7KrFSNvGBgnX6s=; b=dTYxVP3z85Sof99waEQhjZzfDdohwVX1KQs4N+MnUvPkllLP44gB5FPGJewpi2qLYX/ewt 6G5otvCj8t2KypLYBb4qG+W3NzEeaO8W+8MT9Eu7Ic71hytk0EVCPeLl2NvDhAsSlNdiQy PMJjzTfb24bFpeuMkwdLqIRmQpYfYJY= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, vkuznets@redhat.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com Subject: [PATCH v2 2/3] memory: Allow a MemoryRegion to be marked no_vhost Date: Mon, 13 Jan 2020 17:36:46 +0000 Message-Id: <20200113173647.84842-3-dgilbert@redhat.com> In-Reply-To: <20200113173647.84842-1-dgilbert@redhat.com> References: <20200113173647.84842-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: JcY69k9SNxy8mydbfhAt0A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Allow a memory region to be marked as 'no_vhost' and exclude that region from vhost's list build. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 3 ++- include/exec/memory.h | 21 +++++++++++++++++++++ memory.c | 15 +++++++++++++++ 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 774d87d98e..462498bfe6 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -402,7 +402,8 @@ static bool vhost_section(struct vhost_dev *dev, Memory= RegionSection *section) bool log_dirty =3D memory_region_get_dirty_log_mask(section->mr) & ~(1 << DIRTY_MEMORY_MIGRATION); result =3D memory_region_is_ram(section->mr) && - !memory_region_is_rom(section->mr); + !memory_region_is_rom(section->mr) && + !memory_region_get_no_vhost(section->mr); =20 /* Vhost doesn't handle any block which is doing dirty-tracking other * than migration; this typically fires on VGA areas. diff --git a/include/exec/memory.h b/include/exec/memory.h index aef8123d48..f475c06d63 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -394,6 +394,7 @@ struct MemoryRegion { bool ram_device; bool enabled; bool warning_printed; /* For reservations */ + bool no_vhost; uint8_t vga_logging_count; MemoryRegion *alias; hwaddr alias_offset; @@ -1625,6 +1626,26 @@ void memory_region_set_readonly(MemoryRegion *mr, bo= ol readonly); */ void memory_region_set_nonvolatile(MemoryRegion *mr, bool nonvolatile); =20 +/** + * memory_region_set_no_vhost: Make vhost ignore a memory region + * + * Makes vhost ignore a memory region, useful if it isn't real + * DMAble memory and is at inconvenient addresses + * + * @mr: the region being updated. + * @no_vhost: true to ignore + */ +void memory_region_set_no_vhost(MemoryRegion *mr, bool no_vhost); + +/** + * memory_region_set_no_vhost: Test if memory region is marked no vhost + * + * Test if the no_vhost flag is set on the memory region + * + * @mr: the region being tested. + */ +bool memory_region_get_no_vhost(const MemoryRegion *mr); + /** * memory_region_rom_device_set_romd: enable/disable ROMD mode * diff --git a/memory.c b/memory.c index d7b9bb6951..9371998e30 100644 --- a/memory.c +++ b/memory.c @@ -2136,6 +2136,21 @@ void memory_region_set_nonvolatile(MemoryRegion *mr,= bool nonvolatile) } } =20 +void memory_region_set_no_vhost(MemoryRegion *mr, bool no_vhost) +{ + if (mr->no_vhost !=3D no_vhost) { + memory_region_transaction_begin(); + mr->no_vhost =3D no_vhost; + memory_region_update_pending |=3D mr->enabled; + memory_region_transaction_commit(); + } +} + +bool memory_region_get_no_vhost(const MemoryRegion *mr) +{ + return mr->no_vhost; +} + void memory_region_rom_device_set_romd(MemoryRegion *mr, bool romd_mode) { if (mr->romd_mode !=3D romd_mode) { --=20 2.24.1 From nobody Fri Apr 19 12:08:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578937119; cv=none; d=zohomail.com; s=zohoarc; b=A6qgElyQAI+eQRNSVvV5KDxpxXmFQmFs5QJW1v6PAt0ip2exWKRf9UR84P3qNSKz1bVZ6g0d1Mq7ySMOMTtg6opW03wJSJi0WoUa+lD5BTvL0n+jvp3NV/x3u1/X0EM29CWWPd17PUMKCMjicl+rVX7uyDLiTdi9Kmm4YXanINo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578937119; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=97O01buc7glABGMtRrqiEagdNJtM8sbG5AB6H/GxU3s=; b=AKXKKX0+EbBgJZ8k/sfbI9zNdc37wInOmRZ3Of18digBkqxPg1UzTuaKwAFzTtrw9goUek6SteY7BWC6wzsVpEh46ImlqF7PaZ5u0dUYG20EtFqLe43Z0mtMdB5DH3p4ibM/3w3+UzAB8RabK1BxeXQnoX/iTcdYgxhYPXjFePY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578937119123464.23315329241893; Mon, 13 Jan 2020 09:38:39 -0800 (PST) Received: from localhost ([::1]:53694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3fh-0008Ub-AW for importer@patchew.org; Mon, 13 Jan 2020 12:38:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42267) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir3eA-0006ah-S1 for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:37:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir3e9-00026M-TS for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:37:02 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:24704 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ir3e9-00025p-QA for qemu-devel@nongnu.org; Mon, 13 Jan 2020 12:37:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-SpHKGEKVOluJW7gPNqhoUQ-1; Mon, 13 Jan 2020 12:36:58 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5067210054E3 for ; Mon, 13 Jan 2020 17:36:57 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 282515C1B0; Mon, 13 Jan 2020 17:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578937021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=97O01buc7glABGMtRrqiEagdNJtM8sbG5AB6H/GxU3s=; b=AM+K9xFUcz9dDpbarJ2rurAqnA6UglP1H2hUiJ4cRMVRMV8g0wXXavHcWPOlsnECTIxqyh x/zzOctWhY7/c0guqxShY7V75O0U3hHszqJcGG4E/OxBA6OMRA/NEG4jte6Pos0vgLGqUl HlrcxiwMS9qIMquXtimdc7uL+5UZSJ0= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, vkuznets@redhat.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com Subject: [PATCH v2 3/3] hyperv/synic: Mark regions as no vhost Date: Mon, 13 Jan 2020 17:36:47 +0000 Message-Id: <20200113173647.84842-4-dgilbert@redhat.com> In-Reply-To: <20200113173647.84842-1-dgilbert@redhat.com> References: <20200113173647.84842-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: SpHKGEKVOluJW7gPNqhoUQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Mark synic regions as novhost; they are splitting huge page memory and breaking vhost region joining. Signed-off-by: Dr. David Alan Gilbert --- hw/hyperv/hyperv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index da8ce82725..5dbbb14fdd 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -99,6 +99,14 @@ static void synic_realize(DeviceState *dev, Error **errp) sizeof(*synic->msg_page), &error_abort); memory_region_init_ram(&synic->event_page_mr, obj, eventp_name, sizeof(*synic->event_page), &error_abort); + /* + * The guest can put the synic pages anywhere, including + * fragmenting something the host might want to keep as a huge + * page. + */ + memory_region_set_no_vhost(&synic->msg_page_mr, true); + memory_region_set_no_vhost(&synic->event_page_mr, true); + synic->msg_page =3D memory_region_get_ram_ptr(&synic->msg_page_mr); synic->event_page =3D memory_region_get_ram_ptr(&synic->event_page_mr); =20 --=20 2.24.1