From nobody Fri Apr 19 21:43:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578926649; cv=none; d=zohomail.com; s=zohoarc; b=XpsBHIf8NgFzEyUtvG9i0H4DSc+4vGLhFcNRUEsZ9BuM38rgnHj+CAOv3qBoBqDXqWBDCmAUrlIs1nRSs8DWk2orIG+/rai/odtVdPKYCFkuM6yzWJg0NT0p7po5IXIi6D9Ih5QJctVbEF326aYVRjs+BUCrbVVURFX7mnUHTXQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578926649; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=NgG8/oXKPfzZ5PXrBgXiek8H6KwYdNE5o1J3M+0kzq0=; b=Dp8QWLL+B4SGAl0S331XFGHdTG2GSuKKp4MAdPW+7rOcQ8q/bI3awtSKMwxlSKiESgibK6hMWLfVEOaoyTQPVNDD8yyBFmxerpOXPdBeVn46P94A6Z+pHJporjw5Vz2UmSD//6Onmz74iqzv9f8SQEMUVOGqK+E/oQhkHDTOsNU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578926649630553.4077886430553; Mon, 13 Jan 2020 06:44:09 -0800 (PST) Received: from localhost ([::1]:51320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir0wq-0006Zp-5U for importer@patchew.org; Mon, 13 Jan 2020 09:44:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42572) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ir0vk-0005qP-Q8 for qemu-devel@nongnu.org; Mon, 13 Jan 2020 09:43:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ir0vi-0004PJ-NV for qemu-devel@nongnu.org; Mon, 13 Jan 2020 09:43:00 -0500 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:40323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ir0vi-0004OK-IZ for qemu-devel@nongnu.org; Mon, 13 Jan 2020 09:42:58 -0500 Received: by mail-ot1-x341.google.com with SMTP id w21so9111880otj.7 for ; Mon, 13 Jan 2020 06:42:57 -0800 (PST) Received: from serve.minyard.net ([47.184.136.59]) by smtp.gmail.com with ESMTPSA id j10sm4183075otr.64.2020.01.13.06.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 06:42:56 -0800 (PST) Received: from t560.minyard.net (unknown [IPv6:2001:470:b8f6:1b:d74:b0ed:d755:2da5]) by serve.minyard.net (Postfix) with ESMTPA id B5B15180050; Mon, 13 Jan 2020 14:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=NgG8/oXKPfzZ5PXrBgXiek8H6KwYdNE5o1J3M+0kzq0=; b=Hdi3fy85Ly7Lhzq9j5HeO/JwhxCvodSJy89N7xYog1oiGIrFQUh860PqrE2NIt/UdX qhZk6u4TDiAuYfsgCjv4YH5kwc5VXAzg0xRE9DF3f5KxTNKpu2XSJs5kJufAm8UZqHko rpXZouVXak4EhIVF+F1NAQ4ToKYZaJaL+KA135VARli9haBybTsR+vpAgJdFKoW3E7ew /sDrmZmVbrK5Ud9EBk9+vTx/NAgy7hQFLBpztL+kcFIt6+g+ehxMNjBuQqDk9rh9r+4Y mzIP2LkyQY7ghK7ahOcToP06Gyi2RoZ9TcMsYwPsIxuMsIP+F/p2ijWK/fupa/UYchcr Cq1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=NgG8/oXKPfzZ5PXrBgXiek8H6KwYdNE5o1J3M+0kzq0=; b=tnFMJRMW5LoLTqpnF5DurwlaHS+wX+iFFUv3eqN8si4rwAN5qYP9SQHsfjG2dHCIOh JHxbJ8fz7BPYzAKfipiby9+BSKCoREDdbAiW8FAaAVtCvulEOSdTPbkDHIuy2/0RvGFf TBscoXW5ooB+PDCOCRj42CnaZ8NrcEpM03seuh+NaVd32w6hxfQOoH5qwbwkVhZ9WlpP /F6Y50dXitVjXisjC14QDck0hk+dFV8Z3pHNkE5QEC6jHzZDtRCwFVG9qR+2Kw347AW0 8SEqs61zK1C1j8xVSbUG6xEVgPw7243YjqvxGBJ5Z8lSvX+FRyub9wHlLfLShLsoI6St eUag== X-Gm-Message-State: APjAAAX852U8MwIi4wBjZN55IidbnA2PqLBhfjk7goAEiQShYHQYaRNA NDqpelDB6Sn0svQgZl1JiA== X-Google-Smtp-Source: APXvYqxc4UHFxt6FEXP+gId/gIkg4P+7lWnjkfQ1QA4bPixa0E0iQbTiNEc5mO/B9j4/IYJAuogF+w== X-Received: by 2002:a9d:7ac9:: with SMTP id m9mr12491963otn.80.1578926577057; Mon, 13 Jan 2020 06:42:57 -0800 (PST) From: minyard@acm.org To: "Michael S . Tsirkin" Subject: [PATCH] i386:acpi: Remove _HID from the SMBus ACPI entry Date: Mon, 13 Jan 2020 08:42:28 -0600 Message-Id: <20200113144228.16660-1-minyard@acm.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200113090515-mutt-send-email-mst@kernel.org> References: <20200113090515-mutt-send-email-mst@kernel.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Corey Minyard , qemu-devel@nongnu.org, Shannon Zhao , wanghaibin.wang@huawei.com, Igor Mammedov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required on enumerated buses (like PCI in this case), _ADR is required (and is already there). And the _HID value is wrong. Linux appears to ignore the _HID entry, but Windows 10 detects it as 'Unknown Device' and there is no driver available. See https://bugs.launchpad.net/qemu/+bug/1856724 Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Igor Mammedov Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.c | 1 - tests/data/acpi/q35/DSDT | Bin 7879 -> 7869 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7896 -> 7886 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8342 -> 8332 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9532 -> 9522 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7954 -> 7944 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9238 -> 9228 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 9009 -> 8999 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7885 -> 7875 bytes 9 files changed, 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 7b8da62d41..ab73a8f4c8 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1815,7 +1815,6 @@ static void build_smb0(Aml *table, I2CBus *smbus, int= devnr, int func) Aml *scope =3D aml_scope("_SB.PCI0"); Aml *dev =3D aml_device("SMB0"); =20 - aml_append(dev, aml_name_decl("_HID", aml_eisaid("APP0005"))); aml_append(dev, aml_name_decl("_ADR", aml_int(devnr << 16 | func))); build_acpi_ipmi_devices(dev, BUS(smbus), "\\_SB.PCI0.SMB0"); aml_append(scope, dev); diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT index 77ea60ffed421c566138fe6341421f579129a582..1f91888d7a485850cf27f152e24= 7a90b208003dc 100644 GIT binary patch delta 42 xcmX?ZyVsV>CDe&h`+ diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.di= mmpxm index 23fdf5e60a5069f60d6c680ac9c68c4a8a81318e..02ccdd5f38d5b2356dcca89398c= 41dcf2595dfff 100644 GIT binary patch delta 42 xcmdnvwaJUiCDv8151UVN}qe1Nm3L39&;u&FFx2QKET=3D2Ai9Y^*w@Km^J2+-Rsi7S3kU!J delta 52 zcmeCMn`Fo366_KpB+tOWxOgL1ouss?UVN}qe1Nm3L3ER3u&>&QD-BUv81%BUVN}qe1Nm3L3ER3u&