From nobody Sun May 5 15:21:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578676690; cv=none; d=zohomail.com; s=zohoarc; b=RCFRY3pGhibixRaqHgLFdo3yhYktopNq6q5lLruvUSinpbLlOKw0m4d9fEi4JugL8aoG9bzh9BiXgI5zooQ2vun4bOYEtnVJFhONJsj8S1s8ujs4/Vjhb66RTYX9gItP06Aw9I3k44zU4tr8zDNiFvmZ/+wHoe/SiROLJ/bnTd8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578676690; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=qgkNJkwqRe3hT9BZYSupicKMfv+PAwrqHOkYefNmWUk=; b=iDkoCOJNYS4BNhPp44TzuAwbfTXqsGWfNrXCbNxWc2iE9FcbOhk/Uo+beXPD/Adi9VMty3XNAt9BV79ZVenbjar8Bx5ebLrOZt65LCnuz6BnhfQy84uKymsTnQ2Z7AT+vmzTs8iXdaKtKs326sDX6fYYEGUC4XE6+v8fGKC1ObY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578676690613630.9399985144767; Fri, 10 Jan 2020 09:18:10 -0800 (PST) Received: from localhost ([::1]:49458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipxvF-0004Cz-BG for importer@patchew.org; Fri, 10 Jan 2020 12:18:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47963) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipxtU-0003Eo-IZ for qemu-devel@nongnu.org; Fri, 10 Jan 2020 12:16:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipxtT-0007yN-FX for qemu-devel@nongnu.org; Fri, 10 Jan 2020 12:16:20 -0500 Received: from fanzine.igalia.com ([178.60.130.6]:47495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipxtS-0007g8-PL; Fri, 10 Jan 2020 12:16:19 -0500 Received: from [213.99.255.143] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1ipxtN-0005cB-O6; Fri, 10 Jan 2020 18:16:13 +0100 Received: from berto by perseus.local with local (Exim 4.92) (envelope-from ) id 1ipxsY-0005mI-Ny; Fri, 10 Jan 2020 18:15:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=qgkNJkwqRe3hT9BZYSupicKMfv+PAwrqHOkYefNmWUk=; b=mj7FM5jzLKYJdMsdnfROeIuoNb+HChq5gB1XN8TrDHG35EzWcT9qjVkLIdak03Sid4izWGnXOlXRZ8G9LfVlWyHw3EW5PmCCkKwPJ74uqHNX1So6G2rUYxkzUuDbSwkBR1RDX/IQG7JtDe3K42HIdvwCFA/HfKNqV7ICU7PRswKsfESbFUqb/jMTeidn24xk4JDdNr/nrJJG3Mg35B9X/2EZ0RcyN00PYjJjyd2n5fO1rlwcdNS9cB1QseIA5TPOOLjdneXmQ4W9bRP5xJhVShU1Nl9wmqHkviA/1y39VVbu0hEM1Lf4yKMkn/161Z2WfZB+K86DR0+AJ2/fQ2iimQ==; From: Alberto Garcia To: qemu-devel@nongnu.org Subject: [PATCH] block: Use a GString in bdrv_perm_names() Date: Fri, 10 Jan 2020 18:15:18 +0100 Message-Id: <20200110171518.22168-1-berto@igalia.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 178.60.130.6 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This is a bit more efficient than having to allocate and free memory for each new permission. The default size (30) is enough for "consistent read, write, resize". Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake --- block.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 1b6f7c86e8..2bc9e58392 100644 --- a/block.c +++ b/block.c @@ -1976,18 +1976,19 @@ char *bdrv_perm_names(uint64_t perm) { 0, NULL } }; =20 - char *result =3D g_strdup(""); + GString *result =3D g_string_sized_new(30); struct perm_name *p; =20 for (p =3D permissions; p->name; p++) { if (perm & p->perm) { - char *old =3D result; - result =3D g_strdup_printf("%s%s%s", old, *old ? ", " : "", p-= >name); - g_free(old); + if (result->len > 0) { + g_string_append(result, ", "); + } + g_string_append(result, p->name); } } =20 - return result; + return g_string_free(result, FALSE); } =20 /* --=20 2.20.1