From nobody Tue May 21 10:08:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578491738; cv=none; d=zohomail.com; s=zohoarc; b=HX1UCT9qGkTE7q8jcP80hPJrI+6ow7vMaNzYnDNOfXaX3spPu1jk3+6S5Nt4VLnjPDEdeiLXI3vO7MRT1ffGPp/ZPx9Tk7zn8CIMdk0tnuAXwEz6j02qVtGiSvErCZsEFEPSZMXODqv5aY+Lwzi0WO1gWnbxv2DZHmU9PclMHsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578491738; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cb/1BH6QI6Eg7u9kkyFNFjCbikU/0CtzUVtJMKybI0M=; b=Z9duQYvyC7hZZXC4XFeErfYqOOevjKC7LWJRw54fEHYh5etxGWml8+KY8IhG8h6mnb0SKjG1xQpfy95SuubGcIP6CgZXBUDkZghmxwaANVwiZS1jRytz9U/Or8Mwe9ZQxZLSj9Tj2LVpAGT7QRjTojiHlUaeWBOubI0TFrYaQ4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578491738516422.7041935450318; Wed, 8 Jan 2020 05:55:38 -0800 (PST) Received: from localhost ([::1]:44296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipBo7-00032I-Ca for importer@patchew.org; Wed, 08 Jan 2020 08:55:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54011) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipBme-00017L-7d for qemu-devel@nongnu.org; Wed, 08 Jan 2020 08:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipBmd-0002f1-9x for qemu-devel@nongnu.org; Wed, 08 Jan 2020 08:54:04 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57081 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipBmd-0002e8-6P for qemu-devel@nongnu.org; Wed, 08 Jan 2020 08:54:03 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-fNISo1DzOy2VNhSyhXBfOw-1; Wed, 08 Jan 2020 08:54:01 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8BEA1DC20 for ; Wed, 8 Jan 2020 13:54:00 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 865B810013A7; Wed, 8 Jan 2020 13:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578491642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cb/1BH6QI6Eg7u9kkyFNFjCbikU/0CtzUVtJMKybI0M=; b=f8e/ijKFigti28ewy/rXKE4jHkrsZ3cLNW2Q++G7SFGn2WLcQp6kH05tYsfbICTe0oA3zW zAxwLkkfA7eGV61dejt/OLdWpq/MTkmaIz/z8HAllhI29a3Jvcj7auva+WfMqLrDBi5wVu qxa7zUPfC5vuW52BoCiS9BxU81FG/e4= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, vkuznets@redhat.com, mst@redhat.com, jasowang@redhat.com Subject: [PATCH 1/2] vhost: Don't pass ram device sections Date: Wed, 8 Jan 2020 13:53:52 +0000 Message-Id: <20200108135353.75471-2-dgilbert@redhat.com> In-Reply-To: <20200108135353.75471-1-dgilbert@redhat.com> References: <20200108135353.75471-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: fNISo1DzOy2VNhSyhXBfOw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Don't pass RAM blocks that are marked as ram devices to vhost. There's normally something special about them and they're not normally just shared memory. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 4da0d5a6c5..c81f0be71b 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -402,6 +402,7 @@ static bool vhost_section(struct vhost_dev *dev, Memory= RegionSection *section) bool log_dirty =3D memory_region_get_dirty_log_mask(section->mr) & ~(1 << DIRTY_MEMORY_MIGRATION); result =3D memory_region_is_ram(section->mr) && + !memory_region_is_ram_device(section->mr) && !memory_region_is_rom(section->mr); =20 /* Vhost doesn't handle any block which is doing dirty-tracking other --=20 2.24.1 From nobody Tue May 21 10:08:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578491822; cv=none; d=zohomail.com; s=zohoarc; b=LtdCGbFJEO7e8xEbOFmNnzlx0OkHL2tROjA3H43Zxv9z+y7ekygFv4KfLxcVobhZaaLKjD4AZo1n/3wQjNST1C03AggmAGqehg9vuaH54TaGEBU+9ntmVAYfuLX6gfsCfAGmzDjMkMylj8aciqjj3pp2q8dybx0KApq8LmxoHN8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578491822; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H1BpjYKxdyjmi9UNsT7FFDo7zf3ijgwzXYue6hEE/z8=; b=I0VfYLPU5SOa1ALswx6yGL2mHleFh9PiEf6J2W1T3g17nyCpl3JxQmFJt5TLcn8/NiSEJlbnSLeSdBsZKXlQilaASXFNmolgx1aSs5dIOmzPdnQdEx3CnpgUqQ1lbRHup29/3NKOxPUjDm92p/IJtUpjz0lIEuYepT+/MYq9l2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15784918221231005.2232011103098; Wed, 8 Jan 2020 05:57:02 -0800 (PST) Received: from localhost ([::1]:44330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipBpV-0004oC-17 for importer@patchew.org; Wed, 08 Jan 2020 08:57:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54043) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipBmf-0001Bp-Rz for qemu-devel@nongnu.org; Wed, 08 Jan 2020 08:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipBme-0002gF-QC for qemu-devel@nongnu.org; Wed, 08 Jan 2020 08:54:05 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:29033 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipBme-0002fh-ME for qemu-devel@nongnu.org; Wed, 08 Jan 2020 08:54:04 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-j2RF7CDpMVC9ECsWhQdggg-1; Wed, 08 Jan 2020 08:54:02 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5CA3800D50 for ; Wed, 8 Jan 2020 13:54:01 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id D72A310013A7; Wed, 8 Jan 2020 13:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578491643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H1BpjYKxdyjmi9UNsT7FFDo7zf3ijgwzXYue6hEE/z8=; b=SPjmIh1tWH7dddLntkehKoV7mgxo2rDOscwOYskOcxpj/Dph/EN4IHvN7hbEaxcc9PhsQM ya8UdOI8KDVP1ddE39ahOUgk2kAkYQyyrVIWqovMtYuJCImo9X7akuvaP1mRMFho5wn38g I0MEMF1pQeL3vLZ2x/iUlUEYxXgClpU= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, vkuznets@redhat.com, mst@redhat.com, jasowang@redhat.com Subject: [PATCH 2/2] hyperv/synic: Allocate as ram_device Date: Wed, 8 Jan 2020 13:53:53 +0000 Message-Id: <20200108135353.75471-3-dgilbert@redhat.com> In-Reply-To: <20200108135353.75471-1-dgilbert@redhat.com> References: <20200108135353.75471-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: j2RF7CDpMVC9ECsWhQdggg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Mark the synic pages as ram_device so that they won't be visible to vhost. Signed-off-by: Dr. David Alan Gilbert --- hw/hyperv/hyperv.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/hyperv/hyperv.c b/hw/hyperv/hyperv.c index da8ce82725..4de3ec411d 100644 --- a/hw/hyperv/hyperv.c +++ b/hw/hyperv/hyperv.c @@ -95,12 +95,14 @@ static void synic_realize(DeviceState *dev, Error **err= p) msgp_name =3D g_strdup_printf("synic-%u-msg-page", vp_index); eventp_name =3D g_strdup_printf("synic-%u-event-page", vp_index); =20 - memory_region_init_ram(&synic->msg_page_mr, obj, msgp_name, - sizeof(*synic->msg_page), &error_abort); - memory_region_init_ram(&synic->event_page_mr, obj, eventp_name, - sizeof(*synic->event_page), &error_abort); - synic->msg_page =3D memory_region_get_ram_ptr(&synic->msg_page_mr); - synic->event_page =3D memory_region_get_ram_ptr(&synic->event_page_mr); + synic->msg_page =3D qemu_memalign(qemu_real_host_page_size, + sizeof(*synic->msg_page)); + synic->event_page =3D qemu_memalign(qemu_real_host_page_size, + sizeof(*synic->event_page)); + memory_region_init_ram_device_ptr(&synic->msg_page_mr, obj, msgp_name, + sizeof(*synic->msg_page), synic->msg_page); + memory_region_init_ram_device_ptr(&synic->event_page_mr, obj, eventp_n= ame, + sizeof(*synic->event_page), synic->event_page); =20 g_free(msgp_name); g_free(eventp_name); --=20 2.24.1