From nobody Mon Apr 29 16:02:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578474617; cv=none; d=zohomail.com; s=zohoarc; b=W/CjoliRpX/5K1+9UesA1ETyqTdMCjBcuLSu4QHX/n1iQQoXJJOlDZvhC6ZtgxKtIA7pCiDq7fOLAGDFdy9ij1bMASWGNKTBiufbj2rim6oZko8M0409VKr1g5ZOPFGT/OMO5cVc/5g1f8D1lizQEskJVbjFduDd2dK8jP0ZJ4A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578474617; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Uj6mr30TCDg6c4DdtNr7iNCyOOnt8pfajn7sCM14rGU=; b=cl4MmgeZ5iOe16vTyYizdyzdOgF1oh6FyBXQMlE8FrsZWZglbQ6KTJodrMnSgfkt8Vw+tQptZBOOToZ0xTIYwDCOlN3Gqgq3MqJ9iinq5WbsgSVUSdh49TSuSeteNBaJPFVWLF10YGHPEhMmJaeTxg8myWyPnD5/1B1gDbB8M1U= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578474617019888.6679896014398; Wed, 8 Jan 2020 01:10:17 -0800 (PST) Received: from localhost ([::1]:40814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip7Ly-0001N3-T8 for importer@patchew.org; Wed, 08 Jan 2020 04:10:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51417) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip7Fz-0004zR-M7 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 04:04:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ip7Fy-0007C9-Kj for qemu-devel@nongnu.org; Wed, 08 Jan 2020 04:04:03 -0500 Received: from 3.mo69.mail-out.ovh.net ([188.165.52.203]:44109) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ip7Fy-0007Ag-E9 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 04:04:02 -0500 Received: from player795.ha.ovh.net (unknown [10.108.1.181]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id 69EAB7B42B for ; Wed, 8 Jan 2020 10:04:00 +0100 (CET) Received: from kaod.org (lfbn-tou-1-1227-223.w90-76.abo.wanadoo.fr [90.76.50.223]) (Authenticated sender: clg@kaod.org) by player795.ha.ovh.net (Postfix) with ESMTPSA id A4475DD8D013; Wed, 8 Jan 2020 09:03:54 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: David Gibson Subject: [PATCH 1/2] ppc/pnv: use QEMU unit definition MiB Date: Wed, 8 Jan 2020 10:03:47 +0100 Message-Id: <20200108090348.21224-2-clg@kaod.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200108090348.21224-1-clg@kaod.org> References: <20200108090348.21224-1-clg@kaod.org> MIME-Version: 1.0 X-Ovh-Tracer-Id: 11168927079668157414 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdehjedguddvjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeevrogurhhitgcunfgvucfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdeltddrjeeirdehtddrvddvfeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeelhedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 188.165.52.203 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_pnor.c index b061106d1c0c..08ea3e381f2b 100644 --- a/hw/ppc/pnv_pnor.c +++ b/hw/ppc/pnv_pnor.c @@ -11,6 +11,7 @@ #include "qapi/error.h" #include "qemu/error-report.h" #include "qemu/log.h" +#include "qemu/units.h" #include "sysemu/block-backend.h" #include "sysemu/blockdev.h" #include "hw/loader.h" @@ -111,7 +112,7 @@ static void pnv_pnor_realize(DeviceState *dev, Error **= errp) } =20 static Property pnv_pnor_properties[] =3D { - DEFINE_PROP_INT64("size", PnvPnor, size, 128 << 20), + DEFINE_PROP_INT64("size", PnvPnor, size, 128 * MiB), DEFINE_PROP_DRIVE("drive", PnvPnor, blk), DEFINE_PROP_END_OF_LIST(), }; --=20 2.21.1 From nobody Mon Apr 29 16:02:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578474429; cv=none; d=zohomail.com; s=zohoarc; b=mT9uFeiFrVDv3zXGhq4niEaP8rgJ6H+Q1h+JrqaHlozU0CvBJNXseTcNBoKcq5D+e1aueoKWl5dYv53aoOEXs9luE6G6YO6oYjuZEnNE3JnSmbr/fVNnhZNqtAAEnzMrIq0J2TJM6zwyjLqV0orKFqZZr5TW12MTRX8yPXUpc9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578474429; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DPcYATTsBVrNBFFFYcXhf4kSvvNLiVjAk3TT3Vi9xNY=; b=LKa7oUiUsfcJD6Ex+WnLdPn05K6Nx0cxG/LbMF+EWboRF8aQyoTX9LWwoFODZR0cqoK3ScfAoMIUQCmT4tS19mqw5d/5xw+hJCFmXdz1whZPeFzmH2o8r9n+akHDSC6tpBBNyrV18IbJ5e9tlwxQcMRMV4Ep69QyDr1ydUZQ1qg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157847442914625.246203312761395; Wed, 8 Jan 2020 01:07:09 -0800 (PST) Received: from localhost ([::1]:40802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip7Iy-0008Ba-4q for importer@patchew.org; Wed, 08 Jan 2020 04:07:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51519) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip7G6-00058G-R3 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 04:04:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ip7G5-0007KO-Tb for qemu-devel@nongnu.org; Wed, 08 Jan 2020 04:04:10 -0500 Received: from 9.mo177.mail-out.ovh.net ([46.105.72.238]:32773) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ip7G5-0007Hc-O0 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 04:04:09 -0500 Received: from player795.ha.ovh.net (unknown [10.109.143.79]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id 1BA5E11B412 for ; Wed, 8 Jan 2020 10:04:06 +0100 (CET) Received: from kaod.org (lfbn-tou-1-1227-223.w90-76.abo.wanadoo.fr [90.76.50.223]) (Authenticated sender: clg@kaod.org) by player795.ha.ovh.net (Postfix) with ESMTPSA id 37853DD8D090; Wed, 8 Jan 2020 09:04:00 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: David Gibson Subject: [PATCH 2/2] ppc/pnv: improve error logging when a PNOR update fails Date: Wed, 8 Jan 2020 10:03:48 +0100 Message-Id: <20200108090348.21224-3-clg@kaod.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200108090348.21224-1-clg@kaod.org> References: <20200108090348.21224-1-clg@kaod.org> MIME-Version: 1.0 X-Ovh-Tracer-Id: 11170615929170988006 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdehjedguddvjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeevrogurhhitgcunfgvucfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdeltddrjeeirdehtddrvddvfeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeelhedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgepud Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.72.238 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Print out the offset at which the error occured. Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/pnv_pnor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_pnor.c index 08ea3e381f2b..2ab35b797b58 100644 --- a/hw/ppc/pnv_pnor.c +++ b/hw/ppc/pnv_pnor.c @@ -47,7 +47,8 @@ static void pnv_pnor_update(PnvPnor *s, int offset, int s= ize) ret =3D blk_pwrite(s->blk, offset, s->storage + offset, offset_end - offset, 0); if (ret < 0) { - error_report("Could not update PNOR: %s", strerror(-ret)); + error_report("Could not update PNOR offset=3D0x%" PRIx32" : %s", o= ffset, + strerror(-ret)); } } =20 --=20 2.21.1