From nobody Thu Nov 13 07:36:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578461270; cv=none; d=zohomail.com; s=zohoarc; b=dbXR994y0XsZ1ZW+oMng5eKZCZFAsyrFLENv67W1BP6SVmlBBtnEJebu/1vZvsbPraVms2MRlxeiO8vnvmyYkZA7hHvr4Hh8GoNeAQC4yD5HvXFSmxw/mJ9uPx5inTedkWN/IiAx6R5dLvT0VaIruAT6+63VL3C4kYyCQpdJ38c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578461270; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wGeaksJf8sJg+MBrB4A3KCuFNyX+lMx68py1+D8UQyE=; b=c1GIW8KLpnqry++o+YYqA6HR71e5FcTKszCCX5d82fyjHYY7wxmlstPZANqJK5qfhLVHyyvL1YaYFvfaZPBsVi3fZUEru1EogTcFJpONjHCz3o4R8tzAXFZunWM/FNi7m+3Y2rH/jgG+5kuoyyQpFKjBEwYS61qLFrxS5k6J1Bg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578461270677800.7069914622749; Tue, 7 Jan 2020 21:27:50 -0800 (PST) Received: from localhost ([::1]:37020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip3sj-0001Wb-7n for importer@patchew.org; Wed, 08 Jan 2020 00:27:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47330) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip3oX-0003qK-8X for qemu-devel@nongnu.org; Wed, 08 Jan 2020 00:23:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ip3oW-0002d6-8b for qemu-devel@nongnu.org; Wed, 08 Jan 2020 00:23:29 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:43747 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ip3oV-0002Uc-Bd; Wed, 08 Jan 2020 00:23:28 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 47syM93DzXz9sNx; Wed, 8 Jan 2020 16:23:17 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1578460997; bh=RIG8AVq/A1LrdRejHrsb2i5wZf5SloXuDpwkP/Qb1zQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=adAP7IjrZFjRDOqW4vvufUM7oifi56f52xwirILWr9Wmnaew6Yo0Vh8QgsL20DVhv nQrEkb/byFP9G53Fhs9pBjikaBXQZYPWJm/B2P0nWVyKnFC26DGXZsreYeIuorLWAf hZu0pdAzy+Y9ci8Xu0v4OslV+CXnBQSoEdnYULpY= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 02/26] target/ppc: Handle AIL=0 in ppc_excp_vector_offset Date: Wed, 8 Jan 2020 16:22:48 +1100 Message-Id: <20200108052312.238710-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108052312.238710-1-david@gibson.dropbear.id.au> References: <20200108052312.238710-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Fabiano Rosas , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Fabiano Rosas The exception vector offset calculation was moved into a function but the case when AIL=3D0 was not checked. The reason we got away with this is that the sole caller of ppc_excp_vector_offset checks the AIL before calling the function: /* Handle AIL */ if (ail) { ... vector |=3D ppc_excp_vector_offset(cs, ail); } Fixes: 2586a4d7a0 ("target/ppc: Move exception vector offset computation in= to a function") Signed-off-by: Fabiano Rosas Message-Id: <20191217142512.574075-1-farosas@linux.ibm.com> Signed-off-by: David Gibson --- target/ppc/excp_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index 50b004d00d..5752ed4a4d 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -112,6 +112,8 @@ static uint64_t ppc_excp_vector_offset(CPUState *cs, in= t ail) uint64_t offset =3D 0; =20 switch (ail) { + case AIL_NONE: + break; case AIL_0001_8000: offset =3D 0x18000; break; --=20 2.24.1