From nobody Thu Nov 13 07:36:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578462392; cv=none; d=zohomail.com; s=zohoarc; b=M4JpnfWFUFlECZpx0WOBaas3gBZDE0xCORw9ogwuFjW6BwJpFRNsuObPOuh4N1YvuQaZfSbGCyuh8D6Yl/buFCVHPR1CNR0BC0TifdnSJL5hCs3rASYlI3pmXCs3wsB2FoJ3NTMDhqE0pj26lAV9Upit/EtV7vuoA9RgYr8dcZU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578462392; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xYfSzGrT6NU6WRrKa5wycuc5CLTucxyA90yN3HHi1PA=; b=BS/ZwVFaZf2m3s2JkcBbA/gPS9ibLZCh/eFGhlP93OxUubrj/Ua/Tfxhw06wcBpk8hv6suki0Je9BINgSX9gRDDICfxe1icriH7wmiWMsOvfAlo25Mj6b2sgn09dLRn2jf+8DLxDAstzr4wOeKPIT04aJsMT+SwEaG+ZFdVFsQA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578462392398802.0104769473916; Tue, 7 Jan 2020 21:46:32 -0800 (PST) Received: from localhost ([::1]:37324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip4Ap-0001TQ-CO for importer@patchew.org; Wed, 08 Jan 2020 00:46:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48080) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip3oy-0004TF-Tg for qemu-devel@nongnu.org; Wed, 08 Jan 2020 00:23:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ip3ox-0003LQ-OO for qemu-devel@nongnu.org; Wed, 08 Jan 2020 00:23:56 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:38011 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ip3ox-0002nH-EA; Wed, 08 Jan 2020 00:23:55 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 47syMF6VPJz9sSr; Wed, 8 Jan 2020 16:23:19 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1578461001; bh=A1TA5QQb7lUI6lX7WsQKAnkEdsZ5l4cjVOZdeTBLm6s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hleCdbFo2OizXoXOPK9ZHnc1XEWSrXaAXDnCJDHkwkGPCU78q3Ps/7SYq83Z/gP2H RZ0p9R8f046MxNM+XxDqGtlfml5UkF9Vzd8OqCMzvv+Miay1/W9x/JqoalUs8I3HHu iHmjPvLIbSy3qCmuiEo+SRhx2kS8PPk3/zJKBs+I= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 26/26] ppc/pnv: fix check on return value of blk_getlength() Date: Wed, 8 Jan 2020 16:23:12 +1100 Message-Id: <20200108052312.238710-27-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200108052312.238710-1-david@gibson.dropbear.id.au> References: <20200108052312.238710-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: C=C3=A9dric Le Goater blk_getlength() returns an int64_t but the result is stored in a uint32_t. Errors (negative values) won't be caught by the check in pnv_pnor_realize() and blk_blockalign() will allocate a very large buffer in such cases. Fixes Coverity issue CID 1412226. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20200107171809.15556-3-clg@kaod.org> Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: David Gibson --- hw/ppc/pnv_pnor.c | 2 +- include/hw/ppc/pnv_pnor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv_pnor.c b/hw/ppc/pnv_pnor.c index 0e86ae2fea..b061106d1c 100644 --- a/hw/ppc/pnv_pnor.c +++ b/hw/ppc/pnv_pnor.c @@ -111,7 +111,7 @@ static void pnv_pnor_realize(DeviceState *dev, Error **= errp) } =20 static Property pnv_pnor_properties[] =3D { - DEFINE_PROP_UINT32("size", PnvPnor, size, 128 << 20), + DEFINE_PROP_INT64("size", PnvPnor, size, 128 << 20), DEFINE_PROP_DRIVE("drive", PnvPnor, blk), DEFINE_PROP_END_OF_LIST(), }; diff --git a/include/hw/ppc/pnv_pnor.h b/include/hw/ppc/pnv_pnor.h index c3dd28643c..4f96abdfb4 100644 --- a/include/hw/ppc/pnv_pnor.h +++ b/include/hw/ppc/pnv_pnor.h @@ -23,7 +23,7 @@ typedef struct PnvPnor { BlockBackend *blk; =20 uint8_t *storage; - uint32_t size; + int64_t size; MemoryRegion mmio; } PnvPnor; =20 --=20 2.24.1