From nobody Tue Feb 10 12:58:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1578457675; cv=none; d=zohomail.com; s=zohoarc; b=E/C7UpCv9W/K3Xyq4s1zHP9n9wWzHLoxM/pCcyHjuyAmEpz34gnIp4ybjOpBiZ2OkplfwF3L+0eS1EphScBftY4ZBhk7fkaEThvYLfS/cCVRQyo2rZ/0uSQG12DrHhfyhqbzcubcVJrI1Egrp0apgG2p2SiCRZ0FRRNMHrWQisA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578457675; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gn2qUm60pHFb0jINIBzLmU8PxWdzwQ1RyRD8IbxWKSM=; b=lrYyMbceqa/qsi8ZwGSDg41mceqzGlZFPuGC0HUTXykvdRd7KMbZy3l7ID0AIiejUSwptWsat5x3VcHkoPexJ4kOUCL6rdt1uD/lopl0BHHcFzqZ+CTt+LxP6PiKnUVmZautzb0+A4OWaZkV/Klv7r7DTMdmHHYmriV2yOCfkQE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578457675069739.3872737148148; Tue, 7 Jan 2020 20:27:55 -0800 (PST) Received: from localhost ([::1]:36212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip2wj-00032A-TA for importer@patchew.org; Tue, 07 Jan 2020 23:27:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46651) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip2ss-0007nI-M7 for qemu-devel@nongnu.org; Tue, 07 Jan 2020 23:23:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ip2sr-0003bZ-Jn for qemu-devel@nongnu.org; Tue, 07 Jan 2020 23:23:54 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:34959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ip2sr-0003aW-Dd for qemu-devel@nongnu.org; Tue, 07 Jan 2020 23:23:53 -0500 Received: by mail-pl1-x632.google.com with SMTP id g6so585029plt.2 for ; Tue, 07 Jan 2020 20:23:53 -0800 (PST) Received: from localhost.localdomain (alanje.lnk.telstra.net. [120.151.179.201]) by smtp.gmail.com with ESMTPSA id f9sm1192702pfd.141.2020.01.07.20.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 20:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gn2qUm60pHFb0jINIBzLmU8PxWdzwQ1RyRD8IbxWKSM=; b=go5yC9nSc2YPTfUtpb7zjpFW6r+UHpsC+DzJ5B3bw1XW7yC2b0Y38mB4K2z82yizMK 7cytF57P9sRW8CUABi5v08Vnfm8nJZIPz+Q5/QZpxpZiyPR8P+On2SqSVcwtaFrLZ5mU okz71GrXpUKfnjVSAZxi0kmTE1E4UuJRcu/axF/EvF3z7ak6Vm/yeMtY/92g5dRlHD2r 0YiqAbZpnUhl5QFWj8P6jNqfExzTZxsKrs8OszO5r2ky9urmd5qX1N8YvidnJgRT7DPQ ZjgTp3TWhEzBM1u7u3ff14mrDU18ZK/QN04ffENWgSLhjeSUaZB64rZOm3f63IWEp+ZZ SZyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gn2qUm60pHFb0jINIBzLmU8PxWdzwQ1RyRD8IbxWKSM=; b=Xyqtdv0C2wmpv9JeELIdmAmdZghje0H5uwG1snS5iaV9YP1iKhVOSwTyPQwvHuhF1m 9Oc7QTQQSRTi3K+qrB42TD1pNMtdfRvHDw87mQxyD48tAdq2nl+64lnsNIaiawi3F+1G a+TlxaVDTn/+4Sexeo1i3BeIwOhjlmHsr9ZY/YMbT0Xjy9/orIIYfezv6koVZUDd85+k jMakkOApGtsWp0S5iK6nM1ZiqvTLd6+QedZtJp/X2MbX4NSj+zy/P68kSkMMjucYhg+f 4eqGdpapE6gt6RyQ6yDUz1YBNxb1CEtyB7iknSGwo+YuL9OVmWF0R/8rB2aCmz8DfDIx 3/SQ== X-Gm-Message-State: APjAAAUbFCLHHtbjuGsopO7dciR6ttXL6ZQ5UxWTsT8bIW1yYd/+6Rbq dKj/379PoqjPridVc/20TFDqfs9G9KKf0g== X-Google-Smtp-Source: APXvYqwH8FYieKNbIS8BmVeRbiHpN5JCf8+KjP/fsfGgRzYBCkeUbSGggwj6yPVLHGuWGllvjuX2Hg== X-Received: by 2002:a17:902:265:: with SMTP id 92mr3144519plc.188.1578457432063; Tue, 07 Jan 2020 20:23:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 3/3] capstone: Add skipdata hook for s390x Date: Wed, 8 Jan 2020 15:23:38 +1100 Message-Id: <20200108042338.9082-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200108042338.9082-1-richard.henderson@linaro.org> References: <20200108042338.9082-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::632 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Capstone assumes any s390x unknown instruction is 2 bytes. Instead, use the ilen field in the first two bits of the instruction to stay in sync with the insn stream. Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson --- disas.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/disas.c b/disas.c index 845c40fca8..1095bad049 100644 --- a/disas.c +++ b/disas.c @@ -178,6 +178,39 @@ static int print_insn_od_target(bfd_vma pc, disassembl= e_info *info) to share this across calls and across host vs target disassembly. */ static __thread cs_insn *cap_insn; =20 +/* + * The capstone library always skips 2 bytes for S390X. + * This is less than ideal, since we can tell from the first two bits + * the size of the insn and thus stay in sync with the insn stream. + */ +static size_t CAPSTONE_API +cap_skipdata_s390x_cb(const uint8_t *code, size_t code_size, + size_t offset, void *user_data) +{ + size_t ilen; + + /* See get_ilen() in target/s390x/internal.h. */ + switch (code[offset] >> 6) { + case 0: + ilen =3D 2; + break; + case 1: + case 2: + ilen =3D 4; + break; + default: + ilen =3D 6; + break; + } + + return ilen; +} + +static const cs_opt_skipdata cap_skipdata_s390x =3D { + .mnemonic =3D ".byte", + .callback =3D cap_skipdata_s390x_cb +}; + /* Initialize the Capstone library. */ /* ??? It would be nice to cache this. We would need one handle for the host and one for the target. For most targets we can reset specific @@ -208,6 +241,10 @@ static cs_err cap_disas_start(disassemble_info *info, = csh *handle) =20 /* "Disassemble" unknown insns as ".byte W,X,Y,Z". */ cs_option(*handle, CS_OPT_SKIPDATA, CS_OPT_ON); + if (info->cap_arch =3D=3D CS_ARCH_SYSZ) { + cs_option(*handle, CS_OPT_SKIPDATA_SETUP, + (uintptr_t)&cap_skipdata_s390x); + } =20 /* Allocate temp space for cs_disasm_iter. */ if (cap_insn =3D=3D NULL) { --=20 2.20.1