From nobody Wed May 8 23:34:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578451960; cv=none; d=zohomail.com; s=zohoarc; b=N426SfcnIS9WubAIxTYLvjqbG8wldA7YljiLysr6lUukbbbsXcNyfrpA3ZleyFcgy5UPaTcVmxmud3fRsP3KAXqMQ06TVFBhIDReGsi1X+buFYWL31NPXxhHRPF3qFqAMElljeixefjs1oxGjzZ4c4C7i+QWZ2ji+frN5ZCgp5k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578451960; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=W6iBhbYjdjQ7EjokCHxN3NoiKZUpQeh9HVi12XT+rpQ=; b=PgZsbEUEJl5k2f2RvJg8Aj0cv42ZvhXTMrpF/iOmmRelfKR7iz6fg+JIxzGtTUf50eV7Lgp6LbZIHovIOhqUOu7JT2LweS9w5RJSdofzmWuqX3LM3osb8YfIpImb2xAWz6E9Gtx2xrriU1CSogxRR+gt3Lmr5gRJhGHFKzqTX4I= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578451960455943.6948387231422; Tue, 7 Jan 2020 18:52:40 -0800 (PST) Received: from localhost ([::1]:34392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip1SY-0005WT-Q4 for importer@patchew.org; Tue, 07 Jan 2020 21:52:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52513) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ip1Rm-0004uQ-HN for qemu-devel@nongnu.org; Tue, 07 Jan 2020 21:51:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ip1Rl-0003nw-Hc for qemu-devel@nongnu.org; Tue, 07 Jan 2020 21:51:50 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:42582 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ip1Rj-0003hH-1Y; Tue, 07 Jan 2020 21:51:47 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 95FEBCD4BD9738D07B1D; Wed, 8 Jan 2020 10:51:41 +0800 (CST) Received: from DESKTOP-9NTIQGG.china.huawei.com (10.173.221.136) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Wed, 8 Jan 2020 10:51:35 +0800 From: To: Subject: [PATCH v2] nbd: fix uninitialized variable warning Date: Wed, 8 Jan 2020 10:51:32 +0800 Message-ID: <20200108025132.46956-1-pannengyuan@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.173.221.136] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, qemu-trivial@nongnu.org, Pan Nengyuan , qemu-devel@nongnu.org, Euler Robot Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan Fixes: /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request': /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized i= n this function [-Werror=3Dmaybe-uninitialized] int ret; Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- Changes v2 to v1: - change 'if(client->export_meta.bitmap)' into 'else' to fix uninitialized = warning and clean up pointless code (suggested by Eric Blake) --- nbd/server.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 24ebc1a805..87fcd2e7bf 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -2384,20 +2384,12 @@ static coroutine_fn int nbd_handle_request(NBDClien= t *client, !client->export_meta.bitmap, NBD_META_ID_BASE_ALLOCATION, errp); - if (ret < 0) { - return ret; - } - } - - if (client->export_meta.bitmap) { + } else { /* client->export_meta.bitmap */ ret =3D nbd_co_send_bitmap(client, request->handle, client->exp->export_bitmap, request->from, request->len, dont_fragment, true, NBD_META_ID_DIRTY_BITMAP, e= rrp); - if (ret < 0) { - return ret; - } } =20 return ret; --=20 2.21.0.windows.1