From nobody Tue Feb 10 13:37:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578410744; cv=none; d=zohomail.com; s=zohoarc; b=a3AuiEryAZNkCWxME2nWmo9hls8CX/u0gVAlpv4V15D/5/kOy+yCdtNQDAiSM1s/oVmrltUP5PQbfhZPm9uhg58AjqZIw3B9hMM9mSPOkVLgXV4DO+TitRVZwWf6+M1x8el7DjFtCSPC6MvFwwkF6Yxq+KHHuN4hbKi7FBPMais= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578410744; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U3QVwEMauewj5UNLItNA1yrc04E1MF3yTFfAWyYkVY0=; b=EkHHosXFa/uC9RBnRJhWQ9tVrI8eH/4NYhp5LJ1SjXo0+LfZwkvJGbcl3KZe+EIgjKK46ssARpY8erScG+/eRFGBPP8taOGAYo7tZHhx9u1hkyxPa8o8YukEayreFmG/IqeYl3buQlD6yxrPDEqooNox7NvcA+eRbkHuoW8tEYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578410744980120.0414610965995; Tue, 7 Jan 2020 07:25:44 -0800 (PST) Received: from localhost ([::1]:51414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioqjn-0008AO-IS for importer@patchew.org; Tue, 07 Jan 2020 10:25:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57638) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioqVF-0000pB-Bw for qemu-devel@nongnu.org; Tue, 07 Jan 2020 10:10:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioqVD-0006dl-Fg for qemu-devel@nongnu.org; Tue, 07 Jan 2020 10:10:40 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:41677 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ioqVD-0006dM-Bo for qemu-devel@nongnu.org; Tue, 07 Jan 2020 10:10:39 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-0muL2gLFMK6qVCl-pv8cmA-1; Tue, 07 Jan 2020 10:10:37 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C03AE1005516; Tue, 7 Jan 2020 15:10:33 +0000 (UTC) Received: from localhost (ovpn-112-42.ams2.redhat.com [10.36.112.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id C52D35D9E1; Tue, 7 Jan 2020 15:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578409839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U3QVwEMauewj5UNLItNA1yrc04E1MF3yTFfAWyYkVY0=; b=QQ70dCCf4tvlFyanY9lx21rIhOZH+Ju2GS/uVBILMJNphsScgd8ONJfWGP2ak9HvE627ks uefm5RfBzJeqsfzhidbZpu4t6Y3a0zVNY603wBfkS6QlJVLHaQyIZHGtuXKOElLEeKtC9Q S2l6mSx8RtQYycBrdzAlUxA14QrLtAo= From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PULL 29/37] mips/cps: fix setting saar property Date: Tue, 7 Jan 2020 19:04:34 +0400 Message-Id: <20200107150442.1727958-30-marcandre.lureau@redhat.com> In-Reply-To: <20200107150442.1727958-1-marcandre.lureau@redhat.com> References: <20200107150442.1727958-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 0muL2gLFMK6qVCl-pv8cmA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There is no "saar" property. Note: I haven't been able to test this code. Help welcome. May fix commit 043715d1e0fbb3e3411be3f898c5b77b7f90327a ("target/mips: Update ITU to utilize SAARI and SAAR CP0 registers") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Aleksandar Markovic --- hw/mips/cps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/cps.c b/hw/mips/cps.c index 1660f86908..c49868d5da 100644 --- a/hw/mips/cps.c +++ b/hw/mips/cps.c @@ -106,7 +106,7 @@ static void mips_cps_realize(DeviceState *dev, Error **= errp) object_property_set_bool(OBJECT(&s->itu), saar_present, "saar-pres= ent", &err); if (saar_present) { - qdev_prop_set_ptr(DEVICE(&s->itu), "saar", (void *)&env->CP0_S= AAR); + s->itu.saar =3D &env->CP0_SAAR; } object_property_set_bool(OBJECT(&s->itu), true, "realized", &err); if (err !=3D NULL) { --=20 2.25.0.rc1.20.g2443f3f80d