From nobody Tue Feb 10 10:19:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578037389; cv=none; d=zohomail.com; s=zohoarc; b=PDAqFNUbkEIN79Eu3Q8RotSe6B/97tQ9+IoV/dVDaH72xI4FNIkhWifXPM14VA2VTuTK90+acPBJospXVRnFdTZrE8NVEG9OgoNAx0gzImnV9uWQkuohpc7pSLrM0SZU3Zm38g34RnpeeCOXcvO/0vpo8F01D5fghVY8NQ11DwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578037389; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5RDsPGHVtFp+WeQ9UsInlf29HklykiZojApywSGS4Hs=; b=TSllAtAOfO1qZ8Asbgk5XCzIzJO68PM++BuoU/XdKUG2IQGWL02r0ln4pnBNP1nxL+zqYBYTsepje8mnNZMHkO8pBWeph1IRjrCg2nX/wYva7+ce7O59dp6+HCxwitVhG1QE3UeoCK7fJTqP+E6pTbe8DqRPrFiVkWqTRnjurqo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578037389252932.8254452656172; Thu, 2 Jan 2020 23:43:09 -0800 (PST) Received: from localhost ([::1]:49606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inHbw-0003o8-Ew for importer@patchew.org; Fri, 03 Jan 2020 02:43:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58027) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inHZm-0000U0-Pu for qemu-devel@nongnu.org; Fri, 03 Jan 2020 02:40:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inHZk-0000Bt-Bg for qemu-devel@nongnu.org; Fri, 03 Jan 2020 02:40:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:42526 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1inHZj-0000Am-VN for qemu-devel@nongnu.org; Fri, 03 Jan 2020 02:40:52 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-vKdZ6XIvO821G4_5dZ_HBQ-1; Fri, 03 Jan 2020 02:40:50 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52DD91801253; Fri, 3 Jan 2020 07:40:49 +0000 (UTC) Received: from localhost (ovpn-112-30.ams2.redhat.com [10.36.112.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6FCC67D54C; Fri, 3 Jan 2020 07:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578037251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5RDsPGHVtFp+WeQ9UsInlf29HklykiZojApywSGS4Hs=; b=LV2cgMW1tnAQF0+SFhMiriGmww69D8//wf7NFhfxxhFmOlM11oyf5zW6J6+45EPPUOdpBr +nfuYNNdjFlpSNGHAdP7jkXJX0tFxI2nYUSAzNAJmLaPaL1rscv0TsqjFqAZSHkyeSCKHf Sa1GjEWKv60n7gU79DuHh0HnLs1bUD8= From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/3] savevm: check RAM is pagesize aligned Date: Fri, 3 Jan 2020 11:40:00 +0400 Message-Id: <20200103074000.1006389-4-marcandre.lureau@redhat.com> In-Reply-To: <20200103074000.1006389-1-marcandre.lureau@redhat.com> References: <20200103074000.1006389-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: vKdZ6XIvO821G4_5dZ_HBQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , "Dr. David Alan Gilbert" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Stefan Berger , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Check the host pointer is correctly aligned, otherwise we may fail during migration in ram_block_discard_range(). Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- migration/savevm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index a71b930b91..bbb7e89682 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2910,6 +2910,11 @@ err_drain: =20 void vmstate_register_ram(MemoryRegion *mr, DeviceState *dev) { + RAMBlock *rb =3D mr->ram_block; + + assert(QEMU_PTR_IS_ALIGNED(qemu_ram_get_host_addr(rb), + qemu_ram_pagesize(rb))); + qemu_ram_set_idstr(mr->ram_block, memory_region_name(mr), dev); qemu_ram_set_migratable(mr->ram_block); --=20 2.24.0.308.g228f53135a