From nobody Tue Feb 10 01:50:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1577966522; cv=none; d=zohomail.com; s=zohoarc; b=mD18nsGxIupLIMwVgvnnmfsqDLaqfL1VlJgKn5YKxlVXEuItTFtVOgmPAo3TUwFjzrwyJnQ2TmfpCfwgwoIBX9RI1qt4oAz15HG8vqViqAtoU+eBZYC46ayjvGwVMlQd29pF2DrbIDsXT1v/Mz8EV8jNZWnPs3gqyJ8zaEj911k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577966522; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Uy7YsceqeObUlt59EYv1aZgf34yb/zm3rnX0WXuRV7M=; b=Q9GrCoQTBJ3olZt3mSxijWQFc+LJZ/o9NUZHYGwn8wj+j7Y8GPgRY29k8vC3HLMGWZLCTODsB/l26EJu6jHtu3CHffN+1DR3PyHYFHpo6Hb+lHjcP4TRpYTKfmuzaWK5pJKpGoyu3PF38dHkD5DP2qS0fi8EZ05RX1tB2NtZlrA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1577966522256625.3903960737082; Thu, 2 Jan 2020 04:02:02 -0800 (PST) Received: from localhost ([::1]:40288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imzAu-0000ui-QG for importer@patchew.org; Thu, 02 Jan 2020 07:02:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47707) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imz5v-0003Jd-3L for qemu-devel@nongnu.org; Thu, 02 Jan 2020 06:56:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imz5u-0007mP-3I for qemu-devel@nongnu.org; Thu, 02 Jan 2020 06:56:50 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:25364 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1imz5t-0007mI-VQ for qemu-devel@nongnu.org; Thu, 02 Jan 2020 06:56:50 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-i6Or8Zp_OlaCia1WHfKM0g-1; Thu, 02 Jan 2020 06:56:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5C89800D53 for ; Thu, 2 Jan 2020 11:56:46 +0000 (UTC) Received: from localhost (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C5B060BFB; Thu, 2 Jan 2020 11:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577966209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uy7YsceqeObUlt59EYv1aZgf34yb/zm3rnX0WXuRV7M=; b=T8XKDhna+V0czpb49ApP1rzxwduJBP38peOUdEQoVIkqOr+9VRJztjk/6rzThpZcuR9S+4 7DssChM7D2RT6iDqCx9mWLxqoSjlO3eR9MYsqLSyVDBjiEgrchSbP4Dv8nI+7S1cg+fBVy q3mLsKz9P4k964v25NOvlUKmkZ1jT/g= From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PULL 7/7] screendump: use qemu_unlink() Date: Thu, 2 Jan 2020 15:54:59 +0400 Message-Id: <20200102115459.854103-8-marcandre.lureau@redhat.com> In-Reply-To: <20200102115459.854103-1-marcandre.lureau@redhat.com> References: <20200102115459.854103-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: i6Or8Zp_OlaCia1WHfKM0g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Don't attempt to remove /dev/fdset files. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- ui/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/console.c b/ui/console.c index 587edf4ed4..e6ac462aa0 100644 --- a/ui/console.c +++ b/ui/console.c @@ -381,7 +381,7 @@ void qmp_screendump(const char *filename, bool has_devi= ce, const char *device, } =20 if (!ppm_save(fd, surface, errp)) { - unlink(filename); + qemu_unlink(filename); } } =20 --=20 2.24.0.308.g228f53135a