[PATCH 0/2] Fix Cooperlake CPU model

Xiaoyao Li posted 2 patches 4 years, 3 months ago
Test asan failed
Test FreeBSD failed
Test checkpatch failed
Test docker-mingw@fedora failed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191225063018.20038-1-xiaoyao.li@intel.com
Maintainers: Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++-
target/i386/cpu.h | 13 +++++++-----
2 files changed, 58 insertions(+), 6 deletions(-)
[PATCH 0/2] Fix Cooperlake CPU model
Posted by Xiaoyao Li 4 years, 3 months ago
Current Cooperlake CPU model lacks VMX features which are introduced by Paolo
several months ago, and it also lacks 2 security features in
MSR_IA32_ARCH_CAPABILITIES disclosed recently.

Xiaoyao Li (2):
  target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES
  target/i386: Add missed features to Cooperlake CPU model

 target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++-
 target/i386/cpu.h | 13 +++++++-----
 2 files changed, 58 insertions(+), 6 deletions(-)

-- 
2.19.1


Re: [PATCH 0/2] Fix Cooperlake CPU model
Posted by Paolo Bonzini 4 years, 2 months ago
On 25/12/19 07:30, Xiaoyao Li wrote:
> Current Cooperlake CPU model lacks VMX features which are introduced by Paolo
> several months ago, and it also lacks 2 security features in
> MSR_IA32_ARCH_CAPABILITIES disclosed recently.
> 
> Xiaoyao Li (2):
>   target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES
>   target/i386: Add missed features to Cooperlake CPU model
> 
>  target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++-
>  target/i386/cpu.h | 13 +++++++-----
>  2 files changed, 58 insertions(+), 6 deletions(-)
> 

Queued, thanks.

Paolo


Re: [PATCH 0/2] Fix Cooperlake CPU model
Posted by Zhang, Cathy 4 years ago
On 1/7/2020 9:31 PM, Paolo Bonzini wrote:
> On 25/12/19 07:30, Xiaoyao Li wrote:
>> Current Cooperlake CPU model lacks VMX features which are introduced by Paolo
>> several months ago, and it also lacks 2 security features in
>> MSR_IA32_ARCH_CAPABILITIES disclosed recently.
>>
>> Xiaoyao Li (2):
>>    target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES
>>    target/i386: Add missed features to Cooperlake CPU model
>>
>>   target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++-
>>   target/i386/cpu.h | 13 +++++++-----
>>   2 files changed, 58 insertions(+), 6 deletions(-)
>>
> Queued, thanks.
>
> Paolo

Hi Paolo,

Can I ask one question that will you put all the patches for Cooper Lake 
Cpu model into QEMU v5.0-rc0?


Re: [PATCH 0/2] Fix Cooperlake CPU model
Posted by Paolo Bonzini 4 years ago
On 16/03/20 02:39, Zhang, Cathy wrote:
> On 1/7/2020 9:31 PM, Paolo Bonzini wrote:
>> On 25/12/19 07:30, Xiaoyao Li wrote:
>>> Current Cooperlake CPU model lacks VMX features which are introduced
>>> by Paolo
>>> several months ago, and it also lacks 2 security features in
>>> MSR_IA32_ARCH_CAPABILITIES disclosed recently.
>>>
>>> Xiaoyao Li (2):
>>>    target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES
>>>    target/i386: Add missed features to Cooperlake CPU model
>>>
>>>   target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++-
>>>   target/i386/cpu.h | 13 +++++++-----
>>>   2 files changed, 58 insertions(+), 6 deletions(-)
>>>
>> Queued, thanks.
>>
>> Paolo
> 
> Hi Paolo,
> 
> Can I ask one question that will you put all the patches for Cooper Lake
> Cpu model into QEMU v5.0-rc0?

These are included already:

commit b952544fe8a061f0c0cccfd50a58220bc6ac94da
Merge: dc65a5bdc9 083b266f69
Author: Peter Maydell <peter.maydell@linaro.org>
Date:   Fri Jan 10 17:16:49 2020 +0000

    Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
    
    * Compat machines fix (Denis)
    * Command line parsing fixes (Michal, Peter, Xiaoyao)
    * Cooperlake CPU model fixes (Xiaoyao)
    * i386 gdb fix (mkdolata)
    * IOEventHandler cleanup (Philippe)
    * icount fix (Pavel)
    * RR support for random number sources (Pavel)
    * Kconfig fixes (Philippe)
    
Paolo


Re: [PATCH 0/2] Fix Cooperlake CPU model
Posted by Zhang, Cathy 4 years ago
On 3/16/2020 4:41 PM, Paolo Bonzini wrote:
> On 16/03/20 02:39, Zhang, Cathy wrote:
>> On 1/7/2020 9:31 PM, Paolo Bonzini wrote:
>>> On 25/12/19 07:30, Xiaoyao Li wrote:
>>>> Current Cooperlake CPU model lacks VMX features which are introduced
>>>> by Paolo
>>>> several months ago, and it also lacks 2 security features in
>>>> MSR_IA32_ARCH_CAPABILITIES disclosed recently.
>>>>
>>>> Xiaoyao Li (2):
>>>>     target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES
>>>>     target/i386: Add missed features to Cooperlake CPU model
>>>>
>>>>    target/i386/cpu.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++-
>>>>    target/i386/cpu.h | 13 +++++++-----
>>>>    2 files changed, 58 insertions(+), 6 deletions(-)
>>>>
>>> Queued, thanks.
>>>
>>> Paolo
>> Hi Paolo,
>>
>> Can I ask one question that will you put all the patches for Cooper Lake
>> Cpu model into QEMU v5.0-rc0?
> These are included already:
>
> commit b952544fe8a061f0c0cccfd50a58220bc6ac94da
> Merge: dc65a5bdc9 083b266f69
> Author: Peter Maydell <peter.maydell@linaro.org>
> Date:   Fri Jan 10 17:16:49 2020 +0000
>
>      Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
>      
>      * Compat machines fix (Denis)
>      * Command line parsing fixes (Michal, Peter, Xiaoyao)
>      * Cooperlake CPU model fixes (Xiaoyao)
>      * i386 gdb fix (mkdolata)
>      * IOEventHandler cleanup (Philippe)
>      * icount fix (Pavel)
>      * RR support for random number sources (Pavel)
>      * Kconfig fixes (Philippe)
>      
> Paolo
Yes, I see they are already in master, but not in v4.2 yet, so will they 
be in the next release v5.0?

Re: [PATCH 0/2] Fix Cooperlake CPU model
Posted by Paolo Bonzini 4 years ago
On 16/03/20 11:19, Zhang, Cathy wrote:
> Yes, I see they are already in master, but not in v4.2 yet, so will they
> be in the next release v5.0?

Yes, that's what master will become.

Paolo


Re: [PATCH 0/2] Fix Cooperlake CPU model
Posted by Zhang, Cathy 4 years ago
On 3/16/2020 6:24 PM, Paolo Bonzini wrote:
> On 16/03/20 11:19, Zhang, Cathy wrote:
>> Yes, I see they are already in master, but not in v4.2 yet, so will they
>> be in the next release v5.0?
> Yes, that's what master will become.
>
> Paolo
That's great! Thanks for your response!