[PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus

Philippe Mathieu-Daudé posted 1 patch 4 years, 3 months ago
Test asan failed
Test checkpatch failed
Test FreeBSD failed
Test docker-mingw@fedora failed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191224111628.3551-1-philmd@redhat.com
hw/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
The MC146818 sits on an ISA bus. Since it can not be used
without it, select ISA in the Kconfig.

Fixes: 82f5181777e
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig
index 45daa8d655..3dc2dd6888 100644
--- a/hw/rtc/Kconfig
+++ b/hw/rtc/Kconfig
@@ -17,6 +17,7 @@ config TWL92230
     depends on I2C
 
 config MC146818RTC
+    depends on ISA_BUS
     bool
 
 config SUN4V_RTC
-- 
2.21.0


Re: [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus
Posted by Paolo Bonzini 4 years, 2 months ago
On 24/12/19 12:16, Philippe Mathieu-Daudé wrote:
> The MC146818 sits on an ISA bus. Since it can not be used
> without it, select ISA in the Kconfig.
> 
> Fixes: 82f5181777e
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/rtc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig
> index 45daa8d655..3dc2dd6888 100644
> --- a/hw/rtc/Kconfig
> +++ b/hw/rtc/Kconfig
> @@ -17,6 +17,7 @@ config TWL92230
>      depends on I2C
>  
>  config MC146818RTC
> +    depends on ISA_BUS
>      bool
>  
>  config SUN4V_RTC
> 

Queued, thanks.

Paolo


Re: [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus
Posted by Stefano Garzarella 4 years, 3 months ago
On Tue, Dec 24, 2019 at 12:16:28PM +0100, Philippe Mathieu-Daudé wrote:
> The MC146818 sits on an ISA bus. Since it can not be used
> without it, select ISA in the Kconfig.
> 
> Fixes: 82f5181777e
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/rtc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

> 
> diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig
> index 45daa8d655..3dc2dd6888 100644
> --- a/hw/rtc/Kconfig
> +++ b/hw/rtc/Kconfig
> @@ -17,6 +17,7 @@ config TWL92230
>      depends on I2C
>  
>  config MC146818RTC
> +    depends on ISA_BUS
>      bool
>  
>  config SUN4V_RTC
> -- 
> 2.21.0
> 
>